From patchwork Wed Apr 10 19:41:54 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yongseok Koh X-Patchwork-Id: 52632 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id EA7C31B2AC; Wed, 10 Apr 2019 21:41:59 +0200 (CEST) Received: from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129]) by dpdk.org (Postfix) with ESMTP id 442C91B29A for ; Wed, 10 Apr 2019 21:41:58 +0200 (CEST) Received: from Internal Mail-Server by MTLPINE1 (envelope-from yskoh@mellanox.com) with ESMTPS (AES256-SHA encrypted); 10 Apr 2019 22:41:57 +0300 Received: from scfae-sc-2.mti.labs.mlnx (scfae-sc-2.mti.labs.mlnx [10.101.0.96]) by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id x3AJftZF003315; Wed, 10 Apr 2019 22:41:56 +0300 From: Yongseok Koh To: anatoly.burakov@intel.com Cc: dev@dpdk.org, bruce.richardson@intel.com, stable@dpdk.org Date: Wed, 10 Apr 2019 12:41:54 -0700 Message-Id: <20190410194154.43758-1-yskoh@mellanox.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20190409225937.9269-1-yskoh@mellanox.com> References: <20190409225937.9269-1-yskoh@mellanox.com> Subject: [dpdk-dev] [PATCH] examples/multi_process: fix buffer underrun X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" For client_server_mp, the total number of buffers for the mbuf mempool should be correctly calculated. Otherwise, having more clients will stop traffic. Fixes: af75078fece3 ("first public release") Cc: stable@dpdk.org Signed-off-by: Yongseok Koh --- v2: * split up the calculation examples/multi_process/client_server_mp/mp_server/init.c | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/examples/multi_process/client_server_mp/mp_server/init.c b/examples/multi_process/client_server_mp/mp_server/init.c index 30c8e44bc0..3af5dc6994 100644 --- a/examples/multi_process/client_server_mp/mp_server/init.c +++ b/examples/multi_process/client_server_mp/mp_server/init.c @@ -37,8 +37,6 @@ #include "args.h" #include "init.h" -#define MBUFS_PER_CLIENT 1536 -#define MBUFS_PER_PORT 1536 #define MBUF_CACHE_SIZE 512 #define RTE_MP_RX_DESC_DEFAULT 1024 @@ -63,8 +61,15 @@ struct port_info *ports; static int init_mbuf_pools(void) { - const unsigned num_mbufs = (num_clients * MBUFS_PER_CLIENT) \ - + (ports->num_ports * MBUFS_PER_PORT); + const unsigned int num_mbufs_server = + RTE_MP_RX_DESC_DEFAULT * ports->num_ports; + const unsigned int num_mbufs_client = + num_clients * (CLIENT_QUEUE_RINGSIZE + + RTE_MP_TX_DESC_DEFAULT * ports->num_ports); + const unsigned int num_mbufs_mp_cache = + (num_clients + 1) * MBUF_CACHE_SIZE; + const unsigned int num_mbufs = + num_mbufs_server + num_mbufs_client + num_mbufs_mp_cache; /* don't pass single-producer/single-consumer flags to mbuf create as it * seems faster to use a cache instead */