diff mbox series

doc: update release notes for windows support

Message ID 20190410210049.11416-1-pallavi.kadam@intel.com (mailing list archive)
State Superseded, archived
Delegated to: Thomas Monjalon
Headers
Series doc: update release notes for windows support |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Kadam, Pallavi April 10, 2019, 9 p.m. UTC 
  Added documentation for Windows support on 19.05 release.

Signed-off-by: Pallavi Kadam <pallavi.kadam@intel.com>
Reviewed-by: Anand Rawat <anand.rawat@intel.com>
---
 doc/guides/rel_notes/release_19_05.rst | 9 +++++++++
 1 file changed, 9 insertions(+)

Comments

Thomas Monjalon April 22, 2019, 10:42 p.m. UTC | #1 
10/04/2019 23:00, Pallavi Kadam:
> Added documentation for Windows support on 19.05 release.
> 
> Signed-off-by: Pallavi Kadam <pallavi.kadam@intel.com>
> Reviewed-by: Anand Rawat <anand.rawat@intel.com>
> ---
> +* **Added Windows Support.**
> +
> +  * Added Windows support to compile and build Hello World Sample Application.
> +  * Added Windows-specific EAL changes and meson changes.
> +  * Added windows support for kvargs.

You forgot the uppercase for Windows.

> +  * Updated meson for building DLL on windows using DEF files.
> +  * Added rte_os.h for essential os specific macros and typedefs
> +  * Updated make build system to include path for rte_os.h.

I think this is too much details for a release notes.
The useful information here is the first item explaining the
support level is for compiling helloworld.
Kadam, Pallavi April 23, 2019, 4:18 p.m. UTC | #2 
On 4/22/2019 3:42 PM, Thomas Monjalon wrote:
> 10/04/2019 23:00, Pallavi Kadam:
>> Added documentation for Windows support on 19.05 release.
>>
>> Signed-off-by: Pallavi Kadam <pallavi.kadam@intel.com>
>> Reviewed-by: Anand Rawat <anand.rawat@intel.com>
>> ---
>> +* **Added Windows Support.**
>> +
>> +  * Added Windows support to compile and build Hello World Sample Application.
>> +  * Added Windows-specific EAL changes and meson changes.
>> +  * Added windows support for kvargs.
> You forgot the uppercase for Windows.
>
>> +  * Updated meson for building DLL on windows using DEF files.
>> +  * Added rte_os.h for essential os specific macros and typedefs
>> +  * Updated make build system to include path for rte_os.h.
> I think this is too much details for a release notes.
> The useful information here is the first item explaining the
> support level is for compiling helloworld.
Ok, will reduce it in v2.
diff mbox series

Patch

diff --git a/doc/guides/rel_notes/release_19_05.rst b/doc/guides/rel_notes/release_19_05.rst
index dbdf07a0c..de5157651 100644
--- a/doc/guides/rel_notes/release_19_05.rst
+++ b/doc/guides/rel_notes/release_19_05.rst
@@ -68,6 +68,15 @@  New Features
   Added a new lock-free stack handler, which uses the newly added stack
   library.
 
+* **Added Windows Support.**
+
+  * Added Windows support to compile and build Hello World Sample Application.
+  * Added Windows-specific EAL changes and meson changes.
+  * Added windows support for kvargs.
+  * Updated meson for building DLL on windows using DEF files.
+  * Added rte_os.h for essential os specific macros and typedefs
+  * Updated make build system to include path for rte_os.h.
+
 * **Updated KNI module and PMD.**
 
   Updated the KNI kernel module to set the max_mtu according to the given