From patchwork Fri Apr 12 12:29:11 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gagandeep Singh X-Patchwork-Id: 52711 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4CA511B2AE; Fri, 12 Apr 2019 14:29:57 +0200 (CEST) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80047.outbound.protection.outlook.com [40.107.8.47]) by dpdk.org (Postfix) with ESMTP id 493A11B147; Fri, 12 Apr 2019 14:29:13 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5t/uhlu81MmfGJW+tPiCP5OH5gBuT+eIu15Jl3Pfe5s=; b=Hd0tPLwVJbNZzySKHGgoQDBDOWQ6014t65AsEYSwB2HRgg4uYKGR/vZ9dabpFJUNJ2DxHTCrKklKYSzP0RGZbJmqcDzwoUDCB+LPTyI2w5pmcVAggdwf55aTrd5dEwuwnOtuzmvriNCP21q/il6l3dGUHexvCqotEX4WHOSZ/zA= Received: from VE1PR04MB6365.eurprd04.prod.outlook.com (10.255.118.78) by VE1PR04MB6702.eurprd04.prod.outlook.com (20.179.235.203) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1792.17; Fri, 12 Apr 2019 12:29:12 +0000 Received: from VE1PR04MB6365.eurprd04.prod.outlook.com ([fe80::f5ad:f178:4c55:13e0]) by VE1PR04MB6365.eurprd04.prod.outlook.com ([fe80::f5ad:f178:4c55:13e0%3]) with mapi id 15.20.1792.016; Fri, 12 Apr 2019 12:29:12 +0000 From: Gagandeep Singh To: "dev@dpdk.org" , "ferruh.yigit@intel.com" CC: Gagandeep Singh , "stable@dpdk.org" Thread-Topic: [PATCH v4 13/13] net/enetc: fix crash at high speed traffic Thread-Index: AQHU8StV1QVVYGyOZkiYNFGDy1D3vA== Date: Fri, 12 Apr 2019 12:29:11 +0000 Message-ID: <20190412122840.1908-14-g.singh@nxp.com> References: <20190412105105.24351-1-g.singh@nxp.com> <20190412122840.1908-1-g.singh@nxp.com> In-Reply-To: <20190412122840.1908-1-g.singh@nxp.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: BMXPR01CA0029.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:c::15) To VE1PR04MB6365.eurprd04.prod.outlook.com (2603:10a6:803:12a::14) x-mailer: git-send-email 2.19.1 authentication-results: spf=none (sender IP is ) smtp.mailfrom=G.Singh@nxp.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [92.120.0.8] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c57e651b-7d18-471f-a317-08d6bf42779e x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600139)(711020)(4605104)(4618075)(2017052603328)(7193020); SRVR:VE1PR04MB6702; x-ms-traffictypediagnostic: VE1PR04MB6702: x-microsoft-antispam-prvs: x-forefront-prvs: 0005B05917 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(136003)(396003)(376002)(366004)(39860400002)(346002)(199004)(189003)(476003)(102836004)(97736004)(2616005)(5660300002)(52116002)(6486002)(76176011)(36756003)(11346002)(486006)(446003)(26005)(6506007)(386003)(256004)(14444005)(186003)(2906002)(4326008)(8936002)(50226002)(3846002)(14454004)(53936002)(86362001)(105586002)(478600001)(66066001)(106356001)(6116002)(1076003)(72206003)(81166006)(316002)(110136005)(54906003)(81156014)(68736007)(25786009)(305945005)(7736002)(99286004)(2501003)(4744005)(8676002)(71190400001)(71200400001)(6436002)(6512007); DIR:OUT; SFP:1101; SCL:1; SRVR:VE1PR04MB6702; H:VE1PR04MB6365.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: zRUWyQA+vtc2qU5Oapfm/5UzvjJwm7QdhD0h4zSxLnsSqDKUJOOcYNTgguFZFEO0dbwNnGd/lGa1dIGkGFtf3nsVmgfPUZd4ayd89m7Lkxy6ZxjtF+kXUEI1p6SDQ5aJ2MjacMBE6vivJlw5aUw4+CWqzc+K11fRz8W/hgdAMJ/YkK+T8yRxXtimqWjMk7FbigmrakpMuM6pfg9WaHZF8xcg3X3frLbp0AVgyrVwQUoTNtrHUh4ZACXWx0BOZjIq1JTCi0PduEhZK3651G3W4EaXLMaIM9NYK2EQ0Xpmb2kxojalvRaMDuyA8Tyip2IPBJGJudNjxfLsUBCk43xllKL90y84tcHw3Jl9+Cy7NEhDQi1Z9q4olZ3TVdKctaCONEDbU2VcmY8j6cisY4SvLKL2vYvAcgv5WZPRCuVspaA= MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: c57e651b-7d18-471f-a317-08d6bf42779e X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Apr 2019 12:29:11.9509 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6702 Subject: [dpdk-dev] [PATCH v4 13/13] net/enetc: fix crash at high speed traffic X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On xmit side, there should be a check whether BD ring has free BDs available before transmit a packet to avoid data corruption and buffer leak issue. Fixes: 469c6111a799 ("net/enetc: enable Rx and Tx") Cc: stable@dpdk.org Signed-off-by: Gagandeep Singh --- drivers/net/enetc/enetc_rxtx.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/net/enetc/enetc_rxtx.c b/drivers/net/enetc/enetc_rxtx.c index 0ce7dbee7..81b0ef3b1 100644 --- a/drivers/net/enetc/enetc_rxtx.c +++ b/drivers/net/enetc/enetc_rxtx.c @@ -49,11 +49,16 @@ enetc_xmit_pkts(void *tx_queue, uint16_t nb_pkts) { struct enetc_swbd *tx_swbd; - int i, start; + int i, start, bds_to_use; struct enetc_tx_bd *txbd; struct enetc_bdr *tx_ring = (struct enetc_bdr *)tx_queue; i = tx_ring->next_to_use; + + bds_to_use = enetc_bd_unused(tx_ring); + if (bds_to_use < nb_pkts) + nb_pkts = bds_to_use; + start = 0; while (nb_pkts--) { enetc_clean_tx_ring(tx_ring);