net/iavf: fix info get

Message ID 20190417160834.75103-1-qiming.yang@intel.com
State Accepted, archived
Delegated to: Ferruh Yigit
Headers show
Series
  • net/iavf: fix info get
Related show

Checks

Context Check Description
ci/Intel-compilation success Compilation OK
ci/intel-Performance-Testing success Performance Testing PASS
ci/mellanox-Performance-Testing success Performance Testing PASS
ci/checkpatch success coding style OK

Commit Message

Yang, Qiming April 17, 2019, 4:08 p.m.
iavf driver reset the dev_info structure. This action will clear
the setting in core library. This patch fix that issue.

Fixes: 69dd4c3d0898 ("net/avf: enable queue and device")

Signed-off-by: Qiming Yang <qiming.yang@intel.com>
---
 drivers/net/iavf/iavf_ethdev.c | 1 -
 1 file changed, 1 deletion(-)

Comments

David Marchand April 17, 2019, 8:46 a.m. | #1
On Wed, Apr 17, 2019 at 10:41 AM Qiming Yang <qiming.yang@intel.com> wrote:

> iavf driver reset the dev_info structure. This action will clear
> the setting in core library. This patch fix that issue.
>
> Fixes: 69dd4c3d0898 ("net/avf: enable queue and device")
>
"Cc: stable@dpdk.org" is supposed to be part of the commitlog.

See
http://doc.dpdk.org/guides/contributing/stable.html#what-changes-should-be-backported


> Signed-off-by: Qiming Yang <qiming.yang@intel.com>
> ---
>  drivers/net/iavf/iavf_ethdev.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/iavf/iavf_ethdev.c
> b/drivers/net/iavf/iavf_ethdev.c
> index 846e604..7825cbc 100644
> --- a/drivers/net/iavf/iavf_ethdev.c
> +++ b/drivers/net/iavf/iavf_ethdev.c
> @@ -498,7 +498,6 @@ iavf_dev_info_get(struct rte_eth_dev *dev, struct
> rte_eth_dev_info *dev_info)
>  {
>         struct iavf_info *vf =
> IAVF_DEV_PRIVATE_TO_VF(dev->data->dev_private);
>
> -       memset(dev_info, 0, sizeof(*dev_info));
>         dev_info->max_rx_queues = vf->vsi_res->num_queue_pairs;
>         dev_info->max_tx_queues = vf->vsi_res->num_queue_pairs;
>         dev_info->min_rx_bufsize = IAVF_BUF_SIZE_MIN;
> --
> 2.9.5
>
>
Reviewed-by: David Marchand <david.marchand@redhat.com>
Ferruh Yigit April 17, 2019, 12:34 p.m. | #2
On 4/17/2019 9:46 AM, David Marchand wrote:
> On Wed, Apr 17, 2019 at 10:41 AM Qiming Yang <qiming.yang@intel.com> wrote:
> 
>> iavf driver reset the dev_info structure. This action will clear
>> the setting in core library. This patch fix that issue.
>>
>> Fixes: 69dd4c3d0898 ("net/avf: enable queue and device")
>>
> "Cc: stable@dpdk.org" is supposed to be part of the commitlog.
> 
> See
> http://doc.dpdk.org/guides/contributing/stable.html#what-changes-should-be-backported
> 
> 
>> Signed-off-by: Qiming Yang <qiming.yang@intel.com>
>
> Reviewed-by: David Marchand <david.marchand@redhat.com>
> 

Applied to dpdk-next-net/master, thanks.

Patch

diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c
index 846e604..7825cbc 100644
--- a/drivers/net/iavf/iavf_ethdev.c
+++ b/drivers/net/iavf/iavf_ethdev.c
@@ -498,7 +498,6 @@  iavf_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)
 {
 	struct iavf_info *vf = IAVF_DEV_PRIVATE_TO_VF(dev->data->dev_private);
 
-	memset(dev_info, 0, sizeof(*dev_info));
 	dev_info->max_rx_queues = vf->vsi_res->num_queue_pairs;
 	dev_info->max_tx_queues = vf->vsi_res->num_queue_pairs;
 	dev_info->min_rx_bufsize = IAVF_BUF_SIZE_MIN;