[2/2] ethdev: promote function for port count as stable

Message ID 20190417225928.8962-2-thomas@monjalon.net
State Accepted, archived
Delegated to: Ferruh Yigit
Headers show
Series
  • [1/2] ethdev: avoid explicit check of valid port state
Related show

Checks

Context Check Description
ci/Intel-compilation success Compilation OK
ci/checkpatch warning coding style issues

Commit Message

Thomas Monjalon April 17, 2019, 10:59 p.m.
The function rte_eth_dev_count_total() was introduced one year ago
in the release 18.05. It can be declared non experimental in 19.05.

Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
---
 lib/librte_ethdev/rte_ethdev.c           | 2 +-
 lib/librte_ethdev/rte_ethdev.h           | 2 +-
 lib/librte_ethdev/rte_ethdev_version.map | 8 +++++++-
 3 files changed, 9 insertions(+), 3 deletions(-)

Comments

Ferruh Yigit April 18, 2019, 11:51 a.m. | #1
On 4/17/2019 11:59 PM, Thomas Monjalon wrote:
> The function rte_eth_dev_count_total() was introduced one year ago
> in the release 18.05. It can be declared non experimental in 19.05.
> 
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>

Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
Andrew Rybchenko April 18, 2019, 12:34 p.m. | #2
On 4/18/19 2:51 PM, Ferruh Yigit wrote:
> On 4/17/2019 11:59 PM, Thomas Monjalon wrote:
>> The function rte_eth_dev_count_total() was introduced one year ago
>> in the release 18.05. It can be declared non experimental in 19.05.
>>
>> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>

Acked-by: Andrew Rybchenko <arybchenko@solarflare.com>

Patch

diff --git a/lib/librte_ethdev/rte_ethdev.c b/lib/librte_ethdev/rte_ethdev.c
index cca15efca..4d99186e8 100644
--- a/lib/librte_ethdev/rte_ethdev.c
+++ b/lib/librte_ethdev/rte_ethdev.c
@@ -765,7 +765,7 @@  rte_eth_dev_count_avail(void)
 	return count;
 }
 
-uint16_t __rte_experimental
+uint16_t
 rte_eth_dev_count_total(void)
 {
 	uint16_t port, count = 0;
diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h
index 40a068fe8..aafc503db 100644
--- a/lib/librte_ethdev/rte_ethdev.h
+++ b/lib/librte_ethdev/rte_ethdev.h
@@ -1560,7 +1560,7 @@  uint16_t rte_eth_dev_count_avail(void);
  * @return
  *   The total count of Ethernet devices.
  */
-uint16_t __rte_experimental rte_eth_dev_count_total(void);
+uint16_t rte_eth_dev_count_total(void);
 
 /**
  * Convert a numerical speed in Mbps to a bitmap flag that can be used in
diff --git a/lib/librte_ethdev/rte_ethdev_version.map b/lib/librte_ethdev/rte_ethdev_version.map
index b37a4167d..afcd25599 100644
--- a/lib/librte_ethdev/rte_ethdev_version.map
+++ b/lib/librte_ethdev/rte_ethdev_version.map
@@ -229,11 +229,17 @@  DPDK_18.11 {
 
 } DPDK_18.08;
 
+DPDK_19.05 {
+	global:
+
+	rte_eth_dev_count_total;
+
+} DPDK_18.11;
+
 EXPERIMENTAL {
 	global:
 
 	rte_eth_devargs_parse;
-	rte_eth_dev_count_total;
 	rte_eth_dev_create;
 	rte_eth_dev_destroy;
 	rte_eth_dev_get_module_eeprom;