net/i40e: fix print of not supported admin queue msg

Message ID 1555566747-72489-1-git-send-email-beilei.xing@intel.com
State Accepted, archived
Delegated to: Qi Zhang
Headers show
Series
  • net/i40e: fix print of not supported admin queue msg
Related show

Checks

Context Check Description
ci/intel-Performance-Testing success Performance Testing PASS
ci/mellanox-Performance-Testing success Performance Testing PASS
ci/Intel-compilation success Compilation OK
ci/checkpatch success coding style OK

Commit Message

Beilei Xing April 18, 2019, 5:52 a.m.
When launch testpmd with VF and quit testpmd, there'll
be lots of messages "i40evf_handle_aq_msg(): Request 0
is not supported yet", which are triggered during VF
reset and VF needn't do anything. So cancel alarm handler
before VF reset to ignore the admin queue messages.

Fixes: e0e6a7f2154e ("net/i40e: cancel alarm handler at the end of closure")
Cc: stable@dpdk.org

Signed-off-by: Beilei Xing <beilei.xing@intel.com>
---
 drivers/net/i40e/i40e_ethdev_vf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Zhang, Qi Z April 18, 2019, 8:45 a.m. | #1
> -----Original Message-----
> From: Xing, Beilei
> Sent: Thursday, April 18, 2019 1:52 PM
> To: Zhang, Qi Z <qi.z.zhang@intel.com>
> Cc: dev@dpdk.org; stable@dpdk.org
> Subject: [PATCH] net/i40e: fix print of not supported admin queue msg
> 
> When launch testpmd with VF and quit testpmd, there'll be lots of messages
> "i40evf_handle_aq_msg(): Request 0 is not supported yet", which are triggered
> during VF reset and VF needn't do anything. So cancel alarm handler before VF
> reset to ignore the admin queue messages.
> 
> Fixes: e0e6a7f2154e ("net/i40e: cancel alarm handler at the end of closure")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Beilei Xing <beilei.xing@intel.com>

Acked-by: Qi Zhang <qi.z.zhang@intel.com>

Applied to dpdk-next-net-intel.

Thanks
Qi

Patch

diff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_ethdev_vf.c
index 87c45f2..a348972 100644
--- a/drivers/net/i40e/i40e_ethdev_vf.c
+++ b/drivers/net/i40e/i40e_ethdev_vf.c
@@ -2324,11 +2324,11 @@  i40evf_dev_close(struct rte_eth_dev *dev)
 	 */
 	i40evf_dev_promiscuous_disable(dev);
 	i40evf_dev_allmulticast_disable(dev);
+	rte_eal_alarm_cancel(i40evf_dev_alarm_handler, dev);
 
 	i40evf_reset_vf(dev);
 	i40e_shutdown_adminq(hw);
 	i40evf_disable_irq0(hw);
-	rte_eal_alarm_cancel(i40evf_dev_alarm_handler, dev);
 	hw->adapter_closed = 1;
 }