app/test: fix missing header

Message ID 20190419120327.29752-1-bruce.richardson@intel.com
State Accepted, archived
Headers show
Series
  • app/test: fix missing header
Related show

Checks

Context Check Description
ci/mellanox-Performance-Testing success Performance Testing PASS
ci/intel-Performance-Testing success Performance Testing PASS
ci/checkpatch success coding style OK

Commit Message

Bruce Richardson April 19, 2019, 12:03 p.m.
Build of test_compressdev.c fails on FreeBSD due to the missing
include of unistd.h, to provide the function usleep.

Fixes: b06aa643cac4 ("test/compress: add initial unit tests")
Cc: pablo.de.lara.guarch@intel.com
Cc: stable@dpdk.org

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
I sent this previously, but I don't think it made the public list, so resending.
Apologies to anyone who gets this twice!
---
 app/test/test_compressdev.c | 1 +
 1 file changed, 1 insertion(+)

Comments

David Marchand April 19, 2019, 12:09 p.m. | #1
nit: "test/compress:" for the title prefix ?

On Fri, Apr 19, 2019 at 2:03 PM Bruce Richardson <bruce.richardson@intel.com>
wrote:

> Build of test_compressdev.c fails on FreeBSD due to the missing
> include of unistd.h, to provide the function usleep.
>
> Fixes: b06aa643cac4 ("test/compress: add initial unit tests")
> Cc: pablo.de.lara.guarch@intel.com
> Cc: stable@dpdk.org
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
> I sent this previously, but I don't think it made the public list, so
> resending.
> Apologies to anyone who gets this twice!
> ---
>  app/test/test_compressdev.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/app/test/test_compressdev.c b/app/test/test_compressdev.c
> index 404b98f60..121514af5 100644
> --- a/app/test/test_compressdev.c
> +++ b/app/test/test_compressdev.c
> @@ -5,6 +5,7 @@
>  #include <zlib.h>
>  #include <math.h>
>  #include <stdlib.h>
> +#include <unistd.h>
>
>  #include <rte_cycles.h>
>  #include <rte_malloc.h>
> --
> 2.20.1
>
>
Tested on FreeBSD 10.4.
Reviewed-by: David Marchand <david.marchand@redhat.com>
Bruce Richardson April 19, 2019, 12:12 p.m. | #2
On Fri, Apr 19, 2019 at 02:09:51PM +0200, David Marchand wrote:
>    nit: "test/compress:" for the title prefix ?

maybe so, half the time I never know what to prefix autotest stuff like
this with! :-) Thomas, please fix on apply, if possible.

>    On Fri, Apr 19, 2019 at 2:03 PM Bruce Richardson
>    <[1]bruce.richardson@intel.com> wrote:
> 
>      Build of test_compressdev.c fails on FreeBSD due to the missing
>      include of unistd.h, to provide the function usleep.
>      Fixes: b06aa643cac4 ("test/compress: add initial unit tests")
>      Cc: [2]pablo.de.lara.guarch@intel.com
>      Cc: [3]stable@dpdk.org
>      Signed-off-by: Bruce Richardson <[4]bruce.richardson@intel.com>
>      ---
>      I sent this previously, but I don't think it made the public list,
>      so resending.
>      Apologies to anyone who gets this twice!
>      ---
>       app/test/test_compressdev.c | 1 +
>       1 file changed, 1 insertion(+)
>      diff --git a/app/test/test_compressdev.c
>      b/app/test/test_compressdev.c
>      index 404b98f60..121514af5 100644
>      --- a/app/test/test_compressdev.c
>      +++ b/app/test/test_compressdev.c
>      @@ -5,6 +5,7 @@
>       #include <zlib.h>
>       #include <math.h>
>       #include <stdlib.h>
>      +#include <unistd.h>
>       #include <rte_cycles.h>
>       #include <rte_malloc.h>
>      --
>      2.20.1
> 
>    Tested on FreeBSD 10.4.
>    Reviewed-by: David Marchand <[5]david.marchand@redhat.com>
>    --
>    David Marchand
> 
Thanks,
/Bruce
Thomas Monjalon April 19, 2019, 9:17 p.m. | #3
19/04/2019 14:12, Bruce Richardson:
> On Fri, Apr 19, 2019 at 02:09:51PM +0200, David Marchand wrote:
> >    nit: "test/compress:" for the title prefix ?
> 
> maybe so, half the time I never know what to prefix autotest stuff like
> this with! :-) Thomas, please fix on apply, if possible.

In this case, you can just copy the prefix from the "Fixes:" line :)

> >    On Fri, Apr 19, 2019 at 2:03 PM Bruce Richardson
> >    <[1]bruce.richardson@intel.com> wrote:
> > 
> >      Build of test_compressdev.c fails on FreeBSD due to the missing
> >      include of unistd.h, to provide the function usleep.
> >      Fixes: b06aa643cac4 ("test/compress: add initial unit tests")
> >      Cc: [2]pablo.de.lara.guarch@intel.com
> >      Cc: [3]stable@dpdk.org
> >      Signed-off-by: Bruce Richardson <[4]bruce.richardson@intel.com>
> > 
> >    Tested on FreeBSD 10.4.
> >    Reviewed-by: David Marchand <[5]david.marchand@redhat.com>

Applied, thanks

Patch

diff --git a/app/test/test_compressdev.c b/app/test/test_compressdev.c
index 404b98f60..121514af5 100644
--- a/app/test/test_compressdev.c
+++ b/app/test/test_compressdev.c
@@ -5,6 +5,7 @@ 
 #include <zlib.h>
 #include <math.h>
 #include <stdlib.h>
+#include <unistd.h>
 
 #include <rte_cycles.h>
 #include <rte_malloc.h>