[v3] test/compress: fix max mbuf size test case

Message ID 1555692768-17046-1-git-send-email-fiona.trahe@intel.com
State Accepted, archived
Headers show
Series
  • [v3] test/compress: fix max mbuf size test case
Related show

Checks

Context Check Description
ci/intel-Performance-Testing success Performance Testing PASS
ci/mellanox-Performance-Testing success Performance Testing PASS
ci/checkpatch success coding style OK

Commit Message

Trahe, Fiona April 19, 2019, 4:52 p.m.
Fixed the compilation error:

../app/test/test_compressdev.c:1949:11: note: previous
definition of 'i' was here

../app/test/test_compressdev.c:1992:2: error: 'for' loop
initial declarations are only allowed in C99 mode

../app/test/test_compressdev.c:1992:2: note: use option
-std=c99 or -std=gnu99 to compile your code

../app/test/test_compressdev.c:1996:19: warning: assignment
from incompatible pointer type [enabled by default]

Fixes: 355b02eedc65 ("test/compress: add max mbuf size test case")

Signed-off-by: Tomasz Jozwiak <tomaszx.jozwiak@intel.com>
Signed-off-by: Fiona Trahe <fiona.trahe@intel.com>
---
v3 changes:
 - moved idx variable to improve code clarity and consistency
   with other tests

v2 changes:
 - added compile error to commit msg

 app/test/test_compressdev.c | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

Comments

Thomas Monjalon April 19, 2019, 9:06 p.m. | #1
19/04/2019 18:52, Fiona Trahe:
> Fixed the compilation error:
> 
> ../app/test/test_compressdev.c:1949:11: note: previous
> definition of 'i' was here
> 
> ../app/test/test_compressdev.c:1992:2: error: 'for' loop
> initial declarations are only allowed in C99 mode
> 
> ../app/test/test_compressdev.c:1992:2: note: use option
> -std=c99 or -std=gnu99 to compile your code
> 
> ../app/test/test_compressdev.c:1996:19: warning: assignment
> from incompatible pointer type [enabled by default]
> 
> Fixes: 355b02eedc65 ("test/compress: add max mbuf size test case")
> 
> Signed-off-by: Tomasz Jozwiak <tomaszx.jozwiak@intel.com>
> Signed-off-by: Fiona Trahe <fiona.trahe@intel.com>
> ---
> v3 changes:
>  - moved idx variable to improve code clarity and consistency
>    with other tests
> 
> v2 changes:
>  - added compile error to commit msg

Applied, thanks

Patch

diff --git a/app/test/test_compressdev.c b/app/test/test_compressdev.c
index 404b98f60..8d6dbf00d 100644
--- a/app/test/test_compressdev.c
+++ b/app/test/test_compressdev.c
@@ -1948,6 +1948,7 @@  test_compressdev_deflate_stateless_dynamic_big(void)
 	struct comp_testsuite_params *ts_params = &testsuite_params;
 	uint16_t i = 0;
 	int ret = TEST_SUCCESS;
+	int j;
 	const struct rte_compressdev_capabilities *capab;
 	char *test_buffer = NULL;
 
@@ -1970,7 +1971,7 @@  test_compressdev_deflate_stateless_dynamic_big(void)
 	struct interim_data_params int_data = {
 		(const char * const *)&test_buffer,
 		1,
-		NULL,
+		&i,
 		&ts_params->def_comp_xform,
 		&ts_params->def_decomp_xform,
 		1
@@ -1989,11 +1990,9 @@  test_compressdev_deflate_stateless_dynamic_big(void)
 
 	/* fill the buffer with data based on rand. data */
 	srand(BIG_DATA_TEST_SIZE);
-	for (uint32_t i = 0; i < BIG_DATA_TEST_SIZE - 1; ++i)
-		test_buffer[i] = (uint8_t)(rand() % ((uint8_t)-1)) | 1;
-
+	for (j = 0; j < BIG_DATA_TEST_SIZE - 1; ++j)
+		test_buffer[j] = (uint8_t)(rand() % ((uint8_t)-1)) | 1;
 	test_buffer[BIG_DATA_TEST_SIZE-1] = 0;
-	int_data.buf_idx = &i;
 
 	/* Compress with compressdev, decompress with Zlib */
 	test_data.zlib_dir = ZLIB_DECOMPRESS;