diff mbox series

[DPDK] changed default-target from linux to linuxapp for back-compatibility of validate-abi.sh

Message ID 1556093889-446674-1-git-send-email-peng.huang@intel.com (mailing list archive)
State Superseded, archived
Headers
Series [DPDK] changed default-target from linux to linuxapp for back-compatibility of validate-abi.sh |

Checks

Context Check Description
ci/checkpatch warning coding style issues
ci/Intel-compilation success Compilation OK
ci/mellanox-Performance-Testing success Performance Testing PASS
ci/intel-Performance-Testing fail Performance Testing issues

Commit Message

Huang, Peng April 24, 2019, 8:18 a.m. UTC 
  Signed-off-by: Peng Huang <peng.huang@intel.com>
---
 devtools/validate-abi.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Bruce Richardson April 24, 2019, 8:56 a.m. UTC | #1 
On Wed, Apr 24, 2019 at 08:18:09AM +0000, Peng Huang wrote:
> Signed-off-by: Peng Huang <peng.huang@intel.com>
> ---

I think you need a fuller description of the problem here - that although
"linux" is the new target name, we still need to use "linuxapp" for testing
historical versions. 

Fixes tag also needed.

/Bruce

>  devtools/validate-abi.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/devtools/validate-abi.sh b/devtools/validate-abi.sh
> index 54df2e4..138436d 100755
> --- a/devtools/validate-abi.sh
> +++ b/devtools/validate-abi.sh
> @@ -9,7 +9,7 @@ set -e
>  abicheck=abi-compliance-checker
>  abidump=abi-dumper
>  default_dst=abi-check
> -default_target=x86_64-native-linux-gcc
> +default_target=x86_64-native-linuxapp-gcc
>  
>  # trap on error
>  err_report() {
> --
diff mbox series

Patch

diff --git a/devtools/validate-abi.sh b/devtools/validate-abi.sh
index 54df2e4..138436d 100755
--- a/devtools/validate-abi.sh
+++ b/devtools/validate-abi.sh
@@ -9,7 +9,7 @@  set -e
 abicheck=abi-compliance-checker
 abidump=abi-dumper
 default_dst=abi-check
-default_target=x86_64-native-linux-gcc
+default_target=x86_64-native-linuxapp-gcc
 
 # trap on error
 err_report() {