diff mbox series

[19.08,1/6] ipc: handle unsupported ipc in init

Message ID	b0b218f0265ee9814de64f284d0d2d896ab01fa1.1556195690.git.anatoly.burakov@intel.com (mailing list archive)
State	Accepted, archived
Delegated to:	Thomas Monjalon
Headers	From: Anatoly Burakov <anatoly.burakov@intel.com> To: dev@dpdk.org Cc: Bruce Richardson <bruce.richardson@intel.com>, herakliusz.lipiec@intel.com Date: Thu, 25 Apr 2019 13:45:14 +0100 Message-Id: <b0b218f0265ee9814de64f284d0d2d896ab01fa1.1556195690.git.anatoly.burakov@intel.com> Subject: [dpdk-dev] [PATCH 19.08 1/6] ipc: handle unsupported ipc in init Precedence: list Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org>
Series	[19.08,1/6] ipc: handle unsupported ipc in init \| [19.08,1/6] ipc: handle unsupported ipc in init [19.08,2/6] ipc: handle unsupported ipc in action register [19.08,3/6] ipc: don't unregister action if ipc unsupported [19.08,4/6] ipc: handle unsupported ipc in sendmsg [19.08,5/6] ipc: handle unsupported ipc in sync request [19.08,6/6] ipc: handle unsupported ipc in async request

Checks

Context	Check	Description
ci/checkpatch	success	coding style OK

Commit Message

Burakov, Anatoly April 25, 2019, 12:45 p.m. UTC

  Currently, IPC API will silently ignore unsupported IPC.
Fix the API call and its callers to explicitly handle
unsupported IPC cases.

Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
---
 lib/librte_eal/common/eal_common_proc.c | 3 ++-
 lib/librte_eal/freebsd/eal/eal.c        | 2 +-
 lib/librte_eal/linux/eal/eal.c          | 2 +-
 3 files changed, 4 insertions(+), 3 deletions(-)

Comments

Thomas Monjalon June 5, 2019, 9:29 a.m. UTC | #1

25/04/2019 14:45, Anatoly Burakov:
> Currently, IPC API will silently ignore unsupported IPC.
> Fix the API call and its callers to explicitly handle
> unsupported IPC cases.
> 
> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>

Series applied thanks.

Note that title is changed to have IPC uppercase
while "ipc:" module name is kept lowercase.

diff mbox series

Patch

diff --git a/lib/librte_eal/common/eal_common_proc.c b/lib/librte_eal/common/eal_common_proc.c
index b46d644b3..a4581e3b4 100644
--- a/lib/librte_eal/common/eal_common_proc.c
+++ b/lib/librte_eal/common/eal_common_proc.c
@@ -568,7 +568,8 @@  rte_mp_channel_init(void)
 	 */
 	if (internal_config.no_shconf) {
 		RTE_LOG(DEBUG, EAL, "No shared files mode enabled, IPC will be disabled\n");
-		return 0;
+		rte_errno = ENOTSUP;
+		return -1;
 	}
 
 	/* create filter path */
diff --git a/lib/librte_eal/freebsd/eal/eal.c b/lib/librte_eal/freebsd/eal/eal.c
index c6ac9028f..4eaa53195 100644
--- a/lib/librte_eal/freebsd/eal/eal.c
+++ b/lib/librte_eal/freebsd/eal/eal.c
@@ -671,7 +671,7 @@  rte_eal_init(int argc, char **argv)
 	/* Put mp channel init before bus scan so that we can init the vdev
 	 * bus through mp channel in the secondary process before the bus scan.
 	 */
-	if (rte_mp_channel_init() < 0) {
+	if (rte_mp_channel_init() < 0 && rte_errno != ENOTSUP) {
 		rte_eal_init_alert("failed to init mp channel");
 		if (rte_eal_process_type() == RTE_PROC_PRIMARY) {
 			rte_errno = EFAULT;
diff --git a/lib/librte_eal/linux/eal/eal.c b/lib/librte_eal/linux/eal/eal.c
index 161399619..3e1d6eb6a 100644
--- a/lib/librte_eal/linux/eal/eal.c
+++ b/lib/librte_eal/linux/eal/eal.c
@@ -1014,7 +1014,7 @@  rte_eal_init(int argc, char **argv)
 	/* Put mp channel init before bus scan so that we can init the vdev
 	 * bus through mp channel in the secondary process before the bus scan.
 	 */
-	if (rte_mp_channel_init() < 0) {
+	if (rte_mp_channel_init() < 0 && rte_errno != ENOTSUP) {
 		rte_eal_init_alert("failed to init mp channel");
 		if (rte_eal_process_type() == RTE_PROC_PRIMARY) {
 			rte_errno = EFAULT;