build: add unused parameter warnings to meson build
Checks
Commit Message
To improve code quality we want to turn on as many warnings as we can in
the DPDK code, so turn on the "unused-parameter" warning in meson builds to
match that of the make builds. To ensure correct compilation, disable the
warning selectively for driver base code that otherwise would have issues.
Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
config/meson.build | 1 +
drivers/net/i40e/base/meson.build | 3 ++-
drivers/net/ice/base/meson.build | 1 +
drivers/net/ixgbe/base/meson.build | 4 +++-
4 files changed, 7 insertions(+), 2 deletions(-)
Comments
On Wed, 2019-05-15 at 12:38 +0100, Bruce Richardson wrote:
> To improve code quality we want to turn on as many warnings as we can
> in
> the DPDK code, so turn on the "unused-parameter" warning in meson
> builds to
> match that of the make builds. To ensure correct compilation, disable
> the
> warning selectively for driver base code that otherwise would have
> issues.
>
> Signed-off-by: Bruce Richardson <
> bruce.richardson@intel.com
> >
> ---
> config/meson.build | 1 +
> drivers/net/i40e/base/meson.build | 3 ++-
> drivers/net/ice/base/meson.build | 1 +
> drivers/net/ixgbe/base/meson.build | 4 +++-
> 4 files changed, 7 insertions(+), 2 deletions(-)
Acked-by: Luca Boccassi <bluca@debian.org>
15/05/2019 16:39, Luca Boccassi:
> On Wed, 2019-05-15 at 12:38 +0100, Bruce Richardson wrote:
> > To improve code quality we want to turn on as many warnings as we can
> > in
> > the DPDK code, so turn on the "unused-parameter" warning in meson
> > builds to
> > match that of the make builds. To ensure correct compilation, disable
> > the
> > warning selectively for driver base code that otherwise would have
> > issues.
> >
> > Signed-off-by: Bruce Richardson <
> > bruce.richardson@intel.com
>
> Acked-by: Luca Boccassi <bluca@debian.org>
Applied, thanks
@@ -143,6 +143,7 @@ add_project_arguments('-include', 'rte_config.h', language: 'c')
# enable extra warnings and disable any unwanted warnings
warning_flags = [
+ '-Wunused-parameter',
'-Wsign-compare',
'-Wcast-qual',
'-Wno-address-of-packed-member'
@@ -13,7 +13,8 @@ sources = [
error_cflags = ['-Wno-sign-compare', '-Wno-unused-value',
'-Wno-format', '-Wno-error=format-security',
- '-Wno-strict-aliasing', '-Wno-unused-but-set-variable'
+ '-Wno-strict-aliasing', '-Wno-unused-but-set-variable',
+ '-Wno-unused-parameter',
]
c_args = cflags
if allow_experimental_apis
@@ -16,6 +16,7 @@ sources = [
error_cflags = ['-Wno-unused-value',
'-Wno-unused-but-set-variable',
'-Wno-unused-variable',
+ '-Wno-unused-parameter',
]
c_args = cflags
@@ -18,7 +18,9 @@ sources = [
]
error_cflags = ['-Wno-unused-value',
- '-Wno-unused-but-set-variable']
+ '-Wno-unused-but-set-variable',
+ '-Wno-unused-parameter',
+ ]
c_args = cflags
if allow_experimental_apis
c_args += '-DALLOW_EXPERIMENTAL_API'