diff mbox series

[17/25] mempool: use new tailq locking API

Message ID	abad7640365fbaf85a759d9488b93c988c73bac5.1559147228.git.anatoly.burakov@intel.com (mailing list archive)
State	Superseded, archived
Headers	From: Anatoly Burakov <anatoly.burakov@intel.com> To: dev@dpdk.org Cc: Olivier Matz <olivier.matz@6wind.com>, Andrew Rybchenko <arybchenko@solarflare.com>, stephen@networkplumber.org, thomas@monjalon.net, david.marchand@redhat.com Date: Wed, 29 May 2019 17:31:03 +0100 Message-Id: <abad7640365fbaf85a759d9488b93c988c73bac5.1559147228.git.anatoly.burakov@intel.com> In-Reply-To: <cover.1559147228.git.anatoly.burakov@intel.com> References: <cover.1559147228.git.anatoly.burakov@intel.com> In-Reply-To: <cover.1559147228.git.anatoly.burakov@intel.com> References: <cover.1559147228.git.anatoly.burakov@intel.com> Subject: [dpdk-dev] [PATCH 17/25] mempool: use new tailq locking API Precedence: list Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org>
Series	Make shared memory config non-public \| [00/25] Make shared memory config non-public [01/25] eal: add API to lock/unlock memory hotplug [02/25] bus/fslmc: use new memory locking API [03/25] net/mlx4: use new memory locking API [04/25] net/mlx5: use new memory locking API [05/25] net/virtio: use new memory locking API [06/25] mem: use new memory locking API [07/25] malloc: use new memory locking API [08/25] vfio: use new memory locking API [09/25] eal: add EAL tailq list lock/unlock API [10/25] acl: use new tailq locking API [11/25] distributor: use new tailq locking API [12/25] efd: use new tailq locking API [13/25] eventdev: use new tailq locking API [14/25] hash: use new tailq locking API [15/25] lpm: use new tailq locking API [16/25] member: use new tailq locking API [17/25] mempool: use new tailq locking API [18/25] reorder: use new tailq locking API [19/25] ring: use new tailq locking API [20/25] stack: use new tailq locking API [21/25] eal: add new API to lock/unlock mempool list [22/25] mempool: use new mempool list locking API [23/25] eal: remove unused macros [24/25] net/ena: fix direct access to shared memory config [25/25] eal: hide shared memory config

Checks

Context	Check	Description
ci/checkpatch	success	coding style OK
ci/Intel-compilation	fail	Compilation issues

Commit Message

Burakov, Anatoly May 29, 2019, 4:31 p.m. UTC

  Replace usages of direct access to shared memory config with
calls to the new API.

Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
---
 lib/librte_mempool/rte_mempool.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

Comments

Andrew Rybchenko May 29, 2019, 4:47 p.m. UTC | #1

On 5/29/19 7:31 PM, Anatoly Burakov wrote:
> Replace usages of direct access to shared memory config with
> calls to the new API.
>
> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>

Reviewed-by: Andrew Rybchenko <arybchenko@solarflare.com>

diff mbox series

Patch

diff --git a/lib/librte_mempool/rte_mempool.c b/lib/librte_mempool/rte_mempool.c
index 69bd2a65c..aacfdafdd 100644
--- a/lib/librte_mempool/rte_mempool.c
+++ b/lib/librte_mempool/rte_mempool.c
@@ -711,7 +711,7 @@  rte_mempool_free(struct rte_mempool *mp)
 		return;
 
 	mempool_list = RTE_TAILQ_CAST(rte_mempool_tailq.head, rte_mempool_list);
-	rte_rwlock_write_lock(RTE_EAL_TAILQ_RWLOCK);
+	rte_eal_mcfg_tailq_write_lock();
 	/* find out tailq entry */
 	TAILQ_FOREACH(te, mempool_list, next) {
 		if (te->data == (void *)mp)
@@ -722,7 +722,7 @@  rte_mempool_free(struct rte_mempool *mp)
 		TAILQ_REMOVE(mempool_list, te, next);
 		rte_free(te);
 	}
-	rte_rwlock_write_unlock(RTE_EAL_TAILQ_RWLOCK);
+	rte_eal_mcfg_tailq_write_unlock();
 
 	rte_mempool_free_memchunks(mp);
 	rte_mempool_ops_free(mp);
@@ -898,9 +898,9 @@  rte_mempool_create_empty(const char *name, unsigned n, unsigned elt_size,
 
 	te->data = mp;
 
-	rte_rwlock_write_lock(RTE_EAL_TAILQ_RWLOCK);
+	rte_eal_mcfg_tailq_write_lock();
 	TAILQ_INSERT_TAIL(mempool_list, te, next);
-	rte_rwlock_write_unlock(RTE_EAL_TAILQ_RWLOCK);
+	rte_eal_mcfg_tailq_write_unlock();
 	rte_rwlock_write_unlock(RTE_EAL_MEMPOOL_RWLOCK);
 
 	return mp;