app/test-compress-perf: fix reliance on integer endianness (CI:328524)
Checks
Commit Message
This patch fixes Coverity Issue 328524:
Reliance on integer endianness (INCOMPATIBLE_CAST) in function *parse_window_sz*.
Signed-off-by: Artur Trybula <arturx.trybula@intel.com>
---
app/test-compress-perf/comp_perf_options_parse.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
Comments
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Artur Trybula
> Sent: Monday, June 3, 2019 2:51 PM
> To: dev@dpdk.org; Trahe, Fiona <fiona.trahe@intel.com>; Trybula, ArturX
> <arturx.trybula@intel.com>; Dybkowski, AdamX <adamx.dybkowski@intel.com>
> Subject: [dpdk-dev] [PATCH] app/test-compress-perf: fix reliance on
> integer endianness (CI:328524)
>
> This patch fixes Coverity Issue 328524:
> Reliance on integer endianness (INCOMPATIBLE_CAST) in function
> *parse_window_sz*.
This patch should have a fixes line. The usual message would include:
Fixes: e0b6287c035d ("app/compress-perf: add parser")
Coverity issue: 328524
John
@@ -364,12 +364,14 @@ parse_max_num_sgl_segs(struct comp_test_data *test_data, const char *arg)
static int
parse_window_sz(struct comp_test_data *test_data, const char *arg)
{
- int ret = parse_uint16_t((uint16_t *)&test_data->window_sz, arg);
+ uint16_t tmp;
+ int ret = parse_uint16_t(&tmp, arg);
if (ret) {
RTE_LOG(ERR, USER1, "Failed to parse window size\n");
return -1;
}
+ test_data->window_sz = (int)tmp;
return 0;
}