diff mbox series

test/eal: add ut cases for in-memory and single-file-segment

Message ID 1560519475-9666-1-git-send-email-pallantlax.poornima@intel.com (mailing list archive)
State Superseded, archived
Delegated to: Thomas Monjalon
Headers
Series test/eal: add ut cases for in-memory and single-file-segment |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK
ci/intel-Performance-Testing success Performance Testing PASS
ci/mellanox-Performance-Testing success Performance Testing PASS

Commit Message

Poornima, PallantlaX June 14, 2019, 1:37 p.m. UTC 
  Added unit test case for eal command line 'in-memory' option
which will cover below functions.
get_seg_memfd()
test_memfd_create()
pagesz_flags()

Added unit test case for eal command line 'single-file-segments' option
which will cover resize_hugefile().

Signed-off-by: Pallantla Poornima <pallantlax.poornima@intel.com>
---
 app/test/test_eal_flags.c | 69 +++++++++++++++++++++++++++++++++++++++
 1 file changed, 69 insertions(+)

Comments

Anatoly Burakov June 25, 2019, 10:22 a.m. UTC | #1 
On 14-Jun-19 2:37 PM, Pallantla Poornima wrote:
> Added unit test case for eal command line 'in-memory' option
> which will cover below functions.
> get_seg_memfd()
> test_memfd_create()
> pagesz_flags()
> 
> Added unit test case for eal command line 'single-file-segments' option
> which will cover resize_hugefile().
> 
> Signed-off-by: Pallantla Poornima <pallantlax.poornima@intel.com>
> ---
>   app/test/test_eal_flags.c | 69 +++++++++++++++++++++++++++++++++++++++
>   1 file changed, 69 insertions(+)
> 
> diff --git a/app/test/test_eal_flags.c b/app/test/test_eal_flags.c
> index 9112c96d0..2b2cccaec 100644
> --- a/app/test/test_eal_flags.c
> +++ b/app/test/test_eal_flags.c
> @@ -978,6 +978,7 @@ test_file_prefix(void)
>   	 *    mem mode
>   	 */
>   	char prefix[PATH_MAX] = "";
> +	char tmp[PATH_MAX];
>   
>   #ifdef RTE_EXEC_ENV_FREEBSD
>   	return 0;
> @@ -1010,6 +1011,26 @@ test_file_prefix(void)
>   	const char *argv4[] = {prgname, "-c", "1", "-n", "2", "-m",
>   			DEFAULT_MEM_SIZE, "--file-prefix=" memtest2 };
>   
> +	/* primary process with inmemory mode */
> +	const char * const argv5[] = {prgname, "-c", "1", "-n", "2", "-m",
> +		DEFAULT_MEM_SIZE, "--in-memory" };
> +
> +	/* primary process with memtest1 and inmemory mode */
> +	const char * const argv6[] = {prgname, "-c", "1", "-n", "2", "-m",
> +		DEFAULT_MEM_SIZE, "--in-memory",
> +		"--file-prefix=" memtest1 };
> +
> +	snprintf(tmp, PATH_MAX, "--file-prefix=%s", prefix);

No need to do this, you can just add `"--file-prefix", prefix` into 
below line and it'll work. The syntax is either "--flag=param" or 
"--flag param" - both are valid.

Otherwise,

Reviewed-by: Anatoly Burakov <anatoly.burakov@intel.com>
diff mbox series

Patch

diff --git a/app/test/test_eal_flags.c b/app/test/test_eal_flags.c
index 9112c96d0..2b2cccaec 100644
--- a/app/test/test_eal_flags.c
+++ b/app/test/test_eal_flags.c
@@ -978,6 +978,7 @@  test_file_prefix(void)
 	 *    mem mode
 	 */
 	char prefix[PATH_MAX] = "";
+	char tmp[PATH_MAX];
 
 #ifdef RTE_EXEC_ENV_FREEBSD
 	return 0;
@@ -1010,6 +1011,26 @@  test_file_prefix(void)
 	const char *argv4[] = {prgname, "-c", "1", "-n", "2", "-m",
 			DEFAULT_MEM_SIZE, "--file-prefix=" memtest2 };
 
+	/* primary process with inmemory mode */
+	const char * const argv5[] = {prgname, "-c", "1", "-n", "2", "-m",
+		DEFAULT_MEM_SIZE, "--in-memory" };
+
+	/* primary process with memtest1 and inmemory mode */
+	const char * const argv6[] = {prgname, "-c", "1", "-n", "2", "-m",
+		DEFAULT_MEM_SIZE, "--in-memory",
+		"--file-prefix=" memtest1 };
+
+	snprintf(tmp, PATH_MAX, "--file-prefix=%s", prefix);
+
+	/* primary process with parent file-prefix and inmemory mode */
+	const char * const argv7[] = {prgname, "-c", "1", "-n", "2", "-m",
+		DEFAULT_MEM_SIZE, "--in-memory", tmp};
+
+	/* primary process with memtest1 and single-file-segments mode */
+	const char * const argv8[] = {prgname, "-c", "1", "-n", "2", "-m",
+		DEFAULT_MEM_SIZE, "--single-file-segments",
+		"--file-prefix=" memtest1 };
+
 	/* check if files for current prefix are present */
 	if (process_hugefiles(prefix, HUGEPAGE_CHECK_EXISTS) != 1) {
 		printf("Error - hugepage files for %s were not created!\n", prefix);
@@ -1130,6 +1151,54 @@  test_file_prefix(void)
 		return -1;
 	}
 
+	/* this process will run in in-memory mode, so it should not leave any
+	 * hugepage files behind.
+	 */
+
+	/* test case to check eal-options with --in-memory mode */
+	if (launch_proc(argv5) != 0) {
+		printf("Error - failed to run with in-memory mode\n");
+		return -1;
+	}
+
+	/*test case to check eal-options with --in-memory mode with
+	 * custom file-prefix.
+	 */
+	if (launch_proc(argv6) != 0) {
+		printf("Error - failed to run with in-memory mode\n");
+		return -1;
+	}
+
+	/* check if hugefiles for memtest1 are present */
+	if (process_hugefiles(memtest1, HUGEPAGE_CHECK_EXISTS) != 0) {
+		printf("Error - hugepage files for %s were created and not deleted!\n",
+				memtest1);
+		return -1;
+	}
+
+	/* test case to check eal-options with --in-memory mode with
+	 * parent file-prefix.
+	 */
+	if (launch_proc(argv7) != 0) {
+		printf("Error - failed to run with --file-prefix=%s\n", prefix);
+		return -1;
+	}
+
+	/* this process will run in single file mode, so it should not leave any
+	 * hugepage files behind.
+	 */
+	if (launch_proc(argv8) != 0) {
+		printf("Error - failed to run with single-file-segments mode\n");
+		return -1;
+	}
+
+	/* check if hugefiles for memtest1 are present */
+	if (process_hugefiles(memtest1, HUGEPAGE_CHECK_EXISTS) != 0) {
+		printf("Error - hugepage files for %s were not deleted!\n",
+				memtest1);
+		return -1;
+	}
+
 	return 0;
 }