mempool/octeontx2: fix build with ICC
diff mbox series

Message ID 20190626230742.26195-1-stephen@networkplumber.org
State Accepted, archived
Delegated to: Ferruh Yigit
Headers show
Series
  • mempool/octeontx2: fix build with ICC
Related show

Checks

Context Check Description
ci/checkpatch warning coding style issues
ci/intel-Performance-Testing success Performance Testing PASS
ci/mellanox-Performance-Testing success Performance Testing PASS
ci/Intel-compilation fail apply issues

Commit Message

Stephen Hemminger June 26, 2019, 11:07 p.m. UTC
The Intel compiler is pickier about casts and generates:
otx2_mempool_ops.c(344): error #191: type qualifier is meaningless on cast type
  	int64_t * const addr = (int64_t * const)
  	                        ^
This is because of the nature of const.
In this example, the expression is being cast into a pointer
that can not be modified. This is meanlingless because the
expression is already a lvalue.

See https://en.wikipedia.org/wiki/Const_(computer_programming)

Fixes: d7a0da3c0043 ("mempool/octeontx2: add fast path mempool ops")
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 drivers/mempool/octeontx2/otx2_mempool_ops.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Ferruh Yigit June 27, 2019, 7:57 a.m. UTC | #1
On 6/27/2019 12:07 AM, Stephen Hemminger wrote:
> The Intel compiler is pickier about casts and generates:
> otx2_mempool_ops.c(344): error #191: type qualifier is meaningless on cast type
>   	int64_t * const addr = (int64_t * const)
>   	                        ^
> This is because of the nature of const.
> In this example, the expression is being cast into a pointer
> that can not be modified. This is meanlingless because the
> expression is already a lvalue.
> 
> See https://en.wikipedia.org/wiki/Const_(computer_programming)
> 
> Fixes: d7a0da3c0043 ("mempool/octeontx2: add fast path mempool ops")
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>


Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>

Applied, thanks.

Patch
diff mbox series

diff --git a/drivers/mempool/octeontx2/otx2_mempool_ops.c b/drivers/mempool/octeontx2/otx2_mempool_ops.c
index 25170015a397..97146d1fe4e3 100644
--- a/drivers/mempool/octeontx2/otx2_mempool_ops.c
+++ b/drivers/mempool/octeontx2/otx2_mempool_ops.c
@@ -341,7 +341,7 @@  otx2_npa_deq(struct rte_mempool *mp, void **obj_table, unsigned int n)
 	unsigned int index;
 	uint64_t obj;
 
-	int64_t * const addr = (int64_t * const)
+	int64_t * const addr = (int64_t *)
 			(npa_lf_aura_handle_to_base(mp->pool_id) +
 				NPA_LF_AURA_OP_ALLOCX(0));
 	for (index = 0; index < n; index++, obj_table++) {