From patchwork Wed Jun 26 23:07:42 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 55430 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C6A172C2B; Thu, 27 Jun 2019 01:07:53 +0200 (CEST) Received: from mail-pl1-f194.google.com (mail-pl1-f194.google.com [209.85.214.194]) by dpdk.org (Postfix) with ESMTP id D71FC2BF7 for ; Thu, 27 Jun 2019 01:07:52 +0200 (CEST) Received: by mail-pl1-f194.google.com with SMTP id b7so156801pls.6 for ; Wed, 26 Jun 2019 16:07:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=pX1z2AN1g0aZmXyWGMFJFGyzr8T0s/8BHup1yaMwJA0=; b=kErmtLFoUH/2z/BaD+evjMeNEpAncnIDIRskit4+deoo5+ZiecgaL8Vd8L1FWN1imA qh2K0ozOclGtifx/btTqx+JiaLkerSDTiAC8ucGiLwbkMPt1OoSDb/rDuZLTeHKr1cwy 7A4SXA+w/ioYaebn/1Ru1KkWXHEyOwtyh7s/YtqGGiMgfYgI9241Oj4BDz83u5ZblkBh lzwSTnysBzf1mxw9Pyme93BkteBxEFTh8o6kWuhra29ORb8m7l8F4m4CygCU6JR+r8e8 C/aCuYElP9c0qIwTi6osfBC7MFsJZlipa7A/miYWb5wJDrfzkX2Vrcy+Yt6gB+F89hKd lyGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=pX1z2AN1g0aZmXyWGMFJFGyzr8T0s/8BHup1yaMwJA0=; b=B9duJtEp9pGw5PtP/ahWZmzL3b8l34zpBVvhOW8rxoV7kWInICSypLrXecqac0Qqc7 9+/pzw2BRmcU7FJpOo0LC3ixj9cyJU29wpT4rtwue196H9ug72QYZey896VNv1F2hP1a Cx1B9vXLKns6mhzDyaezEJL2FlJMSh8BdUAbfUi2Wf2KPqG3uRE1Mwqa7XDDLb6mPdgt 5YuYtbEeqGKt1AuEeJAeA1XJhEYbs/DvuGh9TmiznHOGYhVWW49KgxVCgmE+6w7gHRxg +mIqAoKJsaFZSTVm46XFNokV/Cz8n7pLyLMwZ7Jx+mpO/IYBVGcf6fKJN3dJyJCkhkvm BjZw== X-Gm-Message-State: APjAAAUpJVfzU62FqGEhSyLLpu3NUknu3YJFWz2k900Byf+lzmCmfAc1 +da+yy9wEBKgEiN1/gz9kOjgcw== X-Google-Smtp-Source: APXvYqwe5p2wDIgcVINd3YKd4sAkYIRSqEBw3P8iOi5dXD5i0qce6OAxQUStSaNBRHrvOeq54B9Ngg== X-Received: by 2002:a17:902:fa2:: with SMTP id 31mr731443plz.38.1561590471869; Wed, 26 Jun 2019 16:07:51 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id f197sm299801pfa.161.2019.06.26.16.07.51 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Wed, 26 Jun 2019 16:07:51 -0700 (PDT) From: Stephen Hemminger To: jerinj@marvell.com Cc: dev@dpdk.org, Stephen Hemminger Date: Wed, 26 Jun 2019 16:07:42 -0700 Message-Id: <20190626230742.26195-1-stephen@networkplumber.org> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH] mempool/octeontx2: fix build with ICC X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The Intel compiler is pickier about casts and generates: otx2_mempool_ops.c(344): error #191: type qualifier is meaningless on cast type int64_t * const addr = (int64_t * const) ^ This is because of the nature of const. In this example, the expression is being cast into a pointer that can not be modified. This is meanlingless because the expression is already a lvalue. See https://en.wikipedia.org/wiki/Const_(computer_programming) Fixes: d7a0da3c0043 ("mempool/octeontx2: add fast path mempool ops") Signed-off-by: Stephen Hemminger Reviewed-by: Ferruh Yigit --- drivers/mempool/octeontx2/otx2_mempool_ops.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mempool/octeontx2/otx2_mempool_ops.c b/drivers/mempool/octeontx2/otx2_mempool_ops.c index 25170015a397..97146d1fe4e3 100644 --- a/drivers/mempool/octeontx2/otx2_mempool_ops.c +++ b/drivers/mempool/octeontx2/otx2_mempool_ops.c @@ -341,7 +341,7 @@ otx2_npa_deq(struct rte_mempool *mp, void **obj_table, unsigned int n) unsigned int index; uint64_t obj; - int64_t * const addr = (int64_t * const) + int64_t * const addr = (int64_t *) (npa_lf_aura_handle_to_base(mp->pool_id) + NPA_LF_AURA_OP_ALLOCX(0)); for (index = 0; index < n; index++, obj_table++) {