diff mbox series

[2/3] event/sw: fix to set positive rte_errno

Message ID 1562234612-631-3-git-send-email-arybchenko@solarflare.com (mailing list archive)
State Accepted, archived
Delegated to: Jerin Jacob
Headers
Series eventdev fixes to set positive rte_errno |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation fail apply issues

Commit Message

Andrew Rybchenko July 4, 2019, 10:03 a.m. UTC 
  From: Dilshod Urazov <Dilshod.Urazov@oktetlabs.ru>

Fixes: 371a688fc159 ("event/sw: support linking queues to ports")
Cc: stable@dpdk.org

Signed-off-by: Dilshod Urazov <Dilshod.Urazov@oktetlabs.ru>
Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
---
 drivers/event/sw/sw_evdev.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

Comments

Van Haaren, Harry July 4, 2019, 10:43 a.m. UTC | #1 
> -----Original Message-----
> From: Andrew Rybchenko [mailto:arybchenko@solarflare.com]
> Sent: Thursday, July 4, 2019 11:04 AM
> To: Jerin Jacob <jerinj@marvell.com>; Van Haaren, Harry
> <harry.van.haaren@intel.com>
> Cc: dev@dpdk.org; Dilshod Urazov <Dilshod.Urazov@oktetlabs.ru>;
> stable@dpdk.org
> Subject: [PATCH 2/3] event/sw: fix to set positive rte_errno
> 
> From: Dilshod Urazov <Dilshod.Urazov@oktetlabs.ru>
> 
> Fixes: 371a688fc159 ("event/sw: support linking queues to ports")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Dilshod Urazov <Dilshod.Urazov@oktetlabs.ru>
> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
> ---
>  drivers/event/sw/sw_evdev.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)

Code changes are fine, I see you're updating eventdev header in 1/3, all good for git master.

Not sure if it should be backported to stable? (and stable is on CC at the moment..)
I would suggest dropping this from stable - given stable should try to minimize change.

Acked-by: Harry van Haaren <harry.van.haaren@intel.com>
diff mbox series

Patch

diff --git a/drivers/event/sw/sw_evdev.c b/drivers/event/sw/sw_evdev.c
index 1175d6c..fb8e8be 100644
--- a/drivers/event/sw/sw_evdev.c
+++ b/drivers/event/sw/sw_evdev.c
@@ -38,12 +38,12 @@ 
 
 		/* check for qid map overflow */
 		if (q->cq_num_mapped_cqs >= RTE_DIM(q->cq_map)) {
-			rte_errno = -EDQUOT;
+			rte_errno = EDQUOT;
 			break;
 		}
 
 		if (p->is_directed && p->num_qids_mapped > 0) {
-			rte_errno = -EDQUOT;
+			rte_errno = EDQUOT;
 			break;
 		}
 
@@ -59,12 +59,12 @@ 
 		if (q->type == SW_SCHED_TYPE_DIRECT) {
 			/* check directed qids only map to one port */
 			if (p->num_qids_mapped > 0) {
-				rte_errno = -EDQUOT;
+				rte_errno = EDQUOT;
 				break;
 			}
 			/* check port only takes a directed flow */
 			if (num > 1) {
-				rte_errno = -EDQUOT;
+				rte_errno = EDQUOT;
 				break;
 			}