test/compress: clarify out-of-space error messages

Message ID 1562347150-19022-1-git-send-email-fiona.trahe@intel.com
State Accepted
Delegated to: akhil goyal
Headers show
Series
  • test/compress: clarify out-of-space error messages
Related show

Checks

Context Check Description
ci/Intel-compilation success Compilation OK
ci/intel-Performance-Testing success Performance Testing PASS
ci/mellanox-Performance-Testing success Performance Testing PASS
ci/checkpatch success coding style OK

Commit Message

Trahe, Fiona July 5, 2019, 5:19 p.m.
Use ERR rather than INFO to warn that it's a negative test else
the errors are seen but the warning to expect them isn't.
Also add comment to make it easier to follow code.

Signed-off-by: Fiona Trahe <fiona.trahe@intel.com>
---
 app/test/test_compressdev.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

Comments

Dybkowski, AdamX July 18, 2019, 12:39 p.m. | #1
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Fiona Trahe
> Sent: Friday, 5 July, 2019 19:19
> To: dev@dpdk.org
> Cc: akhil.goyal@nxp.com; Trahe, Fiona <fiona.trahe@intel.com>
> Subject: [dpdk-dev] [PATCH] test/compress: clarify out-of-space error 
> messages
> 
> Use ERR rather than INFO to warn that it's a negative test else the 
> errors are seen but the warning to expect them isn't.
> Also add comment to make it easier to follow code.
> 
> Signed-off-by: Fiona Trahe <fiona.trahe@intel.com>
> ---

Acked-by: Adam Dybkowski <adamx.dybkowski@intel.com>
Akhil Goyal July 18, 2019, 3:24 p.m. | #2
> >
> > Use ERR rather than INFO to warn that it's a negative test else the
> > errors are seen but the warning to expect them isn't.
> > Also add comment to make it easier to follow code.
> >
> > Signed-off-by: Fiona Trahe <fiona.trahe@intel.com>
> > ---
> 
> Acked-by: Adam Dybkowski <adamx.dybkowski@intel.com>

Applied to dpdk-next-crypto

Thanks.

Patch

diff --git a/app/test/test_compressdev.c b/app/test/test_compressdev.c
index cf78775..65889c2 100644
--- a/app/test/test_compressdev.c
+++ b/app/test/test_compressdev.c
@@ -1870,7 +1870,7 @@  struct test_data_params {
 	uint16_t i;
 	const struct rte_compressdev_capabilities *capab;
 
-	RTE_LOG(INFO, USER1, "This is a negative test errors are expected\n");
+	RTE_LOG(ERR, USER1, "This is a negative test errors are expected\n");
 
 	capab = rte_compressdev_capability_get(0, RTE_COMP_ALGO_DEFLATE);
 	TEST_ASSERT(capab != NULL, "Failed to retrieve device capabilities");
@@ -1901,7 +1901,7 @@  struct test_data_params {
 		RTE_COMP_OP_STATELESS,
 		LB_BOTH,
 		ZLIB_DECOMPRESS,
-		1,
+		1,  /* run out-of-space test */
 		0
 	};
 	/* Compress with compressdev, decompress with Zlib */