From patchwork Thu Jul 11 03:11:54 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 56318 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 24FD92F42; Thu, 11 Jul 2019 05:12:04 +0200 (CEST) Received: from mail-pf1-f195.google.com (mail-pf1-f195.google.com [209.85.210.195]) by dpdk.org (Postfix) with ESMTP id DCB2E2E81 for ; Thu, 11 Jul 2019 05:12:02 +0200 (CEST) Received: by mail-pf1-f195.google.com with SMTP id g2so2045505pfq.0 for ; Wed, 10 Jul 2019 20:12:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=AYW0ZVXUo5eJIWVE5yi5iKPtETGMN01jefNBEmshdtk=; b=pFZAXBzxgUf1OLbdC6uOGD/GWjokSm1TCiekV21CMCeWgfwmN0WP/Ep1x4TK9sSiwZ Fpkin69rQ0e+s601IYAz0MViKeanejVcBYMwhdHHXDQItky0MjyuH9wf/Y3FnW8MZVOD WA0SoIp5rwun1rq9HWWEsb2qMWIIsT1GRhOO21Qv6Sewsq+3vfO+QQ/XHKZCxsbYWtDT Hn3gOZS6jreJtyUjebFqvQ0xF4P7nB6mfpL4b8OTPKWT+FESSDyhAQ1Yx0pF3u/v8Diy AA0+W9hu+1uCs/HyFD5eEdURtlpptVsCt67wLq9s3Lwtanbyrpo1PlUbb+TQxhEjYD7c SyiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=AYW0ZVXUo5eJIWVE5yi5iKPtETGMN01jefNBEmshdtk=; b=DzguqxqYbQwrYrKEfHIvdXio0OlWrlSzdds5jHpf1K7WPr59uckOJn+6qdq44hZRwt +iJ46sC5NhhvPno2/phovkNEUi5VX4uzqyaHmlRJW0P8uryz4O/F8pq3uUimX/f4xLmq YVpOXR07AvctSmUrkhMqyNxFkQsAogUfbGTcD5hbnocz4syDPfcUIXLNNv35tr6CHwer 5XAZwfdn0axGVCFxJgIdMIff2gLlKQ2dx/HktKsGx5nylYKA1L8lK2dcqhAE/veIzE6J mjBmS831slR3ANmtpEM7vlfrLmwb8ipQlAywDtKkWZLvmDrFh95hKQqAsmRRqYdC/kJF EOVw== X-Gm-Message-State: APjAAAXYuA218DPkBOZodopH2PXB9DlpeHlNAeEpFHOzCJs1wNyA5IWk /SGw4Gh6g4YR/Pn+CpXbrSw= X-Google-Smtp-Source: APXvYqxuyXs2Jn1SHrxHIR+D6RcjO0O4tqBSBB7aqVu5CNomXQlP9hlNpPV5RkdfXUoy1qSAzVp0PA== X-Received: by 2002:a17:90a:36a7:: with SMTP id t36mr2053012pjb.34.1562814721759; Wed, 10 Jul 2019 20:12:01 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id x13sm4574180pfn.6.2019.07.10.20.12.00 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Wed, 10 Jul 2019 20:12:01 -0700 (PDT) From: Stephen Hemminger To: jerinj@marvell.com, ndabilpuram@marvell.com, vattunuru@marvell.com Cc: dev@dpdk.org, Stephen Hemminger Date: Wed, 10 Jul 2019 20:11:54 -0700 Message-Id: <20190711031154.16029-1-stephen@networkplumber.org> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH] octeontx2: do not put escape sequences in log X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Putting color escape sequences in the log look pretty for the developer but fails in real world DPDK usage. A real application will put DPDK log to syslog, and syslog does not handle escape sequences. Fixes: dd543124cd93 ("common/octeontx2: add runtime log infra") Signed-off-by: Stephen Hemminger --- drivers/common/octeontx2/otx2_common.h | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/common/octeontx2/otx2_common.h b/drivers/common/octeontx2/otx2_common.h index cdb25d9ed203..e53d411f065d 100644 --- a/drivers/common/octeontx2/otx2_common.h +++ b/drivers/common/octeontx2/otx2_common.h @@ -69,12 +69,9 @@ extern int otx2_logtype_tm; extern int otx2_logtype_tim; extern int otx2_logtype_dpi; -#define OTX2_CLNRM "\x1b[0m" -#define OTX2_CLRED "\x1b[31m" - -#define otx2_err(fmt, args...) \ - RTE_LOG(ERR, PMD, ""OTX2_CLRED"%s():%u " fmt OTX2_CLNRM"\n", \ - __func__, __LINE__, ## args) +#define otx2_err(fmt, args...) \ + RTE_LOG(ERR, PMD, "%s():%u " fmt "\n", \ + __func__, __LINE__, ## args) #define otx2_info(fmt, args...) \ RTE_LOG(INFO, PMD, fmt"\n", ## args)