[1/9] net/tap: remove redundant declarations

Message ID 20190711200309.6134-2-stephen@networkplumber.org
State Accepted
Delegated to: Ferruh Yigit
Headers show
Series
  • redundant rte_vdev_driver declarations
Related show

Checks

Context Check Description
ci/Intel-compilation success Compilation OK
ci/mellanox-Performance-Testing success Performance Testing PASS
ci/intel-Performance-Testing success Performance Testing PASS
ci/checkpatch success coding style OK

Commit Message

Stephen Hemminger July 11, 2019, 8:03 p.m.
The rte_vdev_drivers are declared twice.
The first one is not necessary.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 drivers/net/tap/rte_eth_tap.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Wiles, Keith July 11, 2019, 9:29 p.m. | #1
> On Jul 11, 2019, at 3:03 PM, Stephen Hemminger <stephen@networkplumber.org> wrote:
> 
> The rte_vdev_drivers are declared twice.
> The first one is not necessary.
> 
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
> drivers/net/tap/rte_eth_tap.c | 2 --
> 1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c
> index 3841842f01f8..64bd049110e1 100644
> --- a/drivers/net/tap/rte_eth_tap.c
> +++ b/drivers/net/tap/rte_eth_tap.c
> @@ -71,8 +71,6 @@
> #define TAP_IOV_DEFAULT_MAX 1024
> 
> static int tap_devices_count;
> -static struct rte_vdev_driver pmd_tap_drv;
> -static struct rte_vdev_driver pmd_tun_drv;
> 
> static const char *valid_arguments[] = {
> 	ETH_TAP_IFACE_ARG,
> -- 
> 2.20.1
> 
Acked-by: Keith Wiles <keith.wiles@intel.com>

Regards,
Keith

Patch

diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c
index 3841842f01f8..64bd049110e1 100644
--- a/drivers/net/tap/rte_eth_tap.c
+++ b/drivers/net/tap/rte_eth_tap.c
@@ -71,8 +71,6 @@ 
 #define TAP_IOV_DEFAULT_MAX 1024
 
 static int tap_devices_count;
-static struct rte_vdev_driver pmd_tap_drv;
-static struct rte_vdev_driver pmd_tun_drv;
 
 static const char *valid_arguments[] = {
 	ETH_TAP_IFACE_ARG,