[6/9] net/ring: remove redundant rte_vdev_drive declaration

Message ID 20190711200309.6134-7-stephen@networkplumber.org
State Accepted
Delegated to: Ferruh Yigit
Headers show
Series
  • redundant rte_vdev_driver declarations
Related show

Checks

Context Check Description
ci/Intel-compilation success Compilation OK
ci/checkpatch success coding style OK

Commit Message

Stephen Hemminger July 11, 2019, 8:03 p.m.
The rte_vdev_driver is declared twice.
The first one is not necessary.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 drivers/net/ring/rte_eth_ring.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Bruce Richardson July 12, 2019, 8:31 a.m. | #1
On Thu, Jul 11, 2019 at 01:03:06PM -0700, Stephen Hemminger wrote:
> The rte_vdev_driver is declared twice.
> The first one is not necessary.
> 
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
>  drivers/net/ring/rte_eth_ring.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/net/ring/rte_eth_ring.c b/drivers/net/ring/rte_eth_ring.c
> index 65c2813ba1bc..eb347bce61b7 100644
> --- a/drivers/net/ring/rte_eth_ring.c
> +++ b/drivers/net/ring/rte_eth_ring.c
> @@ -248,8 +248,6 @@ static const struct eth_dev_ops ops = {
>  	.mac_addr_add = eth_mac_addr_add,
>  };
>  
> -static struct rte_vdev_driver pmd_ring_drv;
> -
>  static int
>  do_eth_dev_ring_create(const char *name,
>  		struct rte_ring * const rx_queues[],
> -- 
Acked-by: Bruce Richardson <bruce.richardson@intel.com>

Patch

diff --git a/drivers/net/ring/rte_eth_ring.c b/drivers/net/ring/rte_eth_ring.c
index 65c2813ba1bc..eb347bce61b7 100644
--- a/drivers/net/ring/rte_eth_ring.c
+++ b/drivers/net/ring/rte_eth_ring.c
@@ -248,8 +248,6 @@  static const struct eth_dev_ops ops = {
 	.mac_addr_add = eth_mac_addr_add,
 };
 
-static struct rte_vdev_driver pmd_ring_drv;
-
 static int
 do_eth_dev_ring_create(const char *name,
 		struct rte_ring * const rx_queues[],