[v3] app/testpmd: fix show port info routine

Message ID 1563273274-30219-1-git-send-email-viacheslavo@mellanox.com (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers
Series [v3] app/testpmd: fix show port info routine |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation fail Compilation issues
ci/mellanox-Performance-Testing success Performance Testing PASS
ci/intel-Performance-Testing success Performance Testing PASS

Commit Message

Slava Ovsiienko July 16, 2019, 10:34 a.m. UTC
  This patch updates "show port info [port_id]" command to display
the tx_desc_lim.nb_seg_max and tx_desc_lim.nb_mtu_seg_max fields
of rte_eth_dev_info structure.

Fixes: 4fb7e803eb1a ("ethdev: add Tx preparation")
Cc: stable@dpdk.org

Signed-off-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>
---
v3: tag fixed in commit log message
v2: addressed comments, converted to fix with backporting
v1: http://patches.dpdk.org/patch/56476/
---
 app/test-pmd/config.c | 4 ++++
 1 file changed, 4 insertions(+)
  

Comments

Iremonger, Bernard July 16, 2019, 10:44 a.m. UTC | #1
> -----Original Message-----
> From: Viacheslav Ovsiienko [mailto:viacheslavo@mellanox.com]
> Sent: Tuesday, July 16, 2019 11:35 AM
> To: dev@dpdk.org
> Cc: Iremonger, Bernard <bernard.iremonger@intel.com>; stable@dpdk.org
> Subject: [PATCH v3] app/testpmd: fix show port info routine
> 
> This patch updates "show port info [port_id]" command to display the
> tx_desc_lim.nb_seg_max and tx_desc_lim.nb_mtu_seg_max fields of
> rte_eth_dev_info structure.
> 
> Fixes: 4fb7e803eb1a ("ethdev: add Tx preparation")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>

Acked-by: Bernard Iremonger <bernard.iremonger@intel.com>
  
Ferruh Yigit July 17, 2019, 2:37 p.m. UTC | #2
On 7/16/2019 11:44 AM, Iremonger, Bernard wrote:
>> -----Original Message-----
>> From: Viacheslav Ovsiienko [mailto:viacheslavo@mellanox.com]
>> Sent: Tuesday, July 16, 2019 11:35 AM
>> To: dev@dpdk.org
>> Cc: Iremonger, Bernard <bernard.iremonger@intel.com>; stable@dpdk.org
>> Subject: [PATCH v3] app/testpmd: fix show port info routine
>>
>> This patch updates "show port info [port_id]" command to display the
>> tx_desc_lim.nb_seg_max and tx_desc_lim.nb_mtu_seg_max fields of
>> rte_eth_dev_info structure.
>>
>> Fixes: 4fb7e803eb1a ("ethdev: add Tx preparation")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>
> 
> Acked-by: Bernard Iremonger <bernard.iremonger@intel.com>
> 

Applied to dpdk-next-net/master, thanks.
  

Patch

diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
index 1d80470..ba43be5 100644
--- a/app/test-pmd/config.c
+++ b/app/test-pmd/config.c
@@ -509,6 +509,10 @@ 
 	printf("Min possible number of TXDs per queue: %hu\n",
 		dev_info.tx_desc_lim.nb_min);
 	printf("TXDs number alignment: %hu\n", dev_info.tx_desc_lim.nb_align);
+	printf("Max segment number per packet: %hu\n",
+		dev_info.tx_desc_lim.nb_seg_max);
+	printf("Max segment number per MTU/TSO: %hu\n",
+		dev_info.tx_desc_lim.nb_mtu_seg_max);
 
 	/* Show switch info only if valid switch domain and port id is set */
 	if (dev_info.switch_info.domain_id !=