diff mbox series

net/mlx5: fix define of added tunnel layer bit

Message ID 70e5550c339eb720592d2b364069f74f232137a3.1563478168.git.dekelp@mellanox.com (mailing list archive)
State Accepted, archived
Delegated to: Raslan Darawsheh
Headers
Series net/mlx5: fix define of added tunnel layer bit |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation fail Compilation issues
ci/mellanox-Performance-Testing success Performance Testing PASS
ci/intel-Performance-Testing success Performance Testing PASS

Commit Message

Dekel Peled July 18, 2019, 7:41 p.m. UTC 
  The new define MLX5_FLOW_LAYER_IPIP is using the same value as
existing define MLX5_FLOW_LAYER_GRE_KEY.
This patch updates the values to be in order.

Fixes: 1b5624cd9062 ("net/mlx5: support IP-in-IP tunnel")
Signed-off-by: Dekel Peled <dekelp@mellanox.com>
---
 drivers/net/mlx5/mlx5_flow.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Xiaoyu Min July 19, 2019, 2:58 a.m. UTC | #1 
On Thu, 19-07-18, 22:41, Dekel Peled wrote:
> The new define MLX5_FLOW_LAYER_IPIP is using the same value as
> existing define MLX5_FLOW_LAYER_GRE_KEY.
> This patch updates the values to be in order.
> 
> Fixes: 1b5624cd9062 ("net/mlx5: support IP-in-IP tunnel")
> Signed-off-by: Dekel Peled <dekelp@mellanox.com>
> ---
>  drivers/net/mlx5/mlx5_flow.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/mlx5/mlx5_flow.h b/drivers/net/mlx5/mlx5_flow.h
> index ece967a..3f96bec 100644
> --- a/drivers/net/mlx5/mlx5_flow.h
> +++ b/drivers/net/mlx5/mlx5_flow.h
> @@ -58,8 +58,8 @@
>  #define MLX5_FLOW_LAYER_ICMP6 (1u << 19)
>  #define MLX5_FLOW_LAYER_GRE_KEY (1u << 20)
>  
> -#define MLX5_FLOW_LAYER_IPIP (1u << 20)
> -#define MLX5_FLOW_LAYER_IPV6_ENCAP (1u << 21)
> +#define MLX5_FLOW_LAYER_IPIP (1u << 21)
> +#define MLX5_FLOW_LAYER_IPV6_ENCAP (1u << 22)
>  
>  /* Outer Masks. */
>  #define MLX5_FLOW_LAYER_OUTER_L3 \
> -- 
> 1.8.3.1
> 
Acked-by: Xiaoyu Min <jackmin@mellanox.com>
Slava Ovsiienko July 19, 2019, 4:28 a.m. UTC | #2 
> -----Original Message-----
> From: Dekel Peled <dekelp@mellanox.com>
> Sent: Thursday, July 18, 2019 22:42
> To: Yongseok Koh <yskoh@mellanox.com>; Slava Ovsiienko
> <viacheslavo@mellanox.com>; Shahaf Shuler <shahafs@mellanox.com>
> Cc: Jack Min <jackmin@mellanox.com>; Ori Kam <orika@mellanox.com>;
> dev@dpdk.org
> Subject: [PATCH] net/mlx5: fix define of added tunnel layer bit
> 
> The new define MLX5_FLOW_LAYER_IPIP is using the same value as existing
> define MLX5_FLOW_LAYER_GRE_KEY.
> This patch updates the values to be in order.
> 
> Fixes: 1b5624cd9062 ("net/mlx5: support IP-in-IP tunnel")
> Signed-off-by: Dekel Peled <dekelp@mellanox.com>
Acked-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>

> ---
>  drivers/net/mlx5/mlx5_flow.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/mlx5/mlx5_flow.h b/drivers/net/mlx5/mlx5_flow.h
> index ece967a..3f96bec 100644
> --- a/drivers/net/mlx5/mlx5_flow.h
> +++ b/drivers/net/mlx5/mlx5_flow.h
> @@ -58,8 +58,8 @@
>  #define MLX5_FLOW_LAYER_ICMP6 (1u << 19)  #define
> MLX5_FLOW_LAYER_GRE_KEY (1u << 20)
> 
> -#define MLX5_FLOW_LAYER_IPIP (1u << 20) -#define
> MLX5_FLOW_LAYER_IPV6_ENCAP (1u << 21)
> +#define MLX5_FLOW_LAYER_IPIP (1u << 21) #define
> +MLX5_FLOW_LAYER_IPV6_ENCAP (1u << 22)
> 
>  /* Outer Masks. */
>  #define MLX5_FLOW_LAYER_OUTER_L3 \
> --
> 1.8.3.1
Raslan Darawsheh July 21, 2019, 7:51 a.m. UTC | #3 
Hi,

> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Dekel Peled
> Sent: Thursday, July 18, 2019 10:42 PM
> To: Yongseok Koh <yskoh@mellanox.com>; Slava Ovsiienko
> <viacheslavo@mellanox.com>; Shahaf Shuler <shahafs@mellanox.com>
> Cc: Jack Min <jackmin@mellanox.com>; Ori Kam <orika@mellanox.com>;
> dev@dpdk.org
> Subject: [dpdk-dev] [PATCH] net/mlx5: fix define of added tunnel layer bit
> 
> The new define MLX5_FLOW_LAYER_IPIP is using the same value as existing
> define MLX5_FLOW_LAYER_GRE_KEY.
> This patch updates the values to be in order.
> 
> Fixes: 1b5624cd9062 ("net/mlx5: support IP-in-IP tunnel")
> Signed-off-by: Dekel Peled <dekelp@mellanox.com>
> ---
>  drivers/net/mlx5/mlx5_flow.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/mlx5/mlx5_flow.h b/drivers/net/mlx5/mlx5_flow.h
> index ece967a..3f96bec 100644
> --- a/drivers/net/mlx5/mlx5_flow.h
> +++ b/drivers/net/mlx5/mlx5_flow.h
> @@ -58,8 +58,8 @@
>  #define MLX5_FLOW_LAYER_ICMP6 (1u << 19)  #define
> MLX5_FLOW_LAYER_GRE_KEY (1u << 20)
> 
> -#define MLX5_FLOW_LAYER_IPIP (1u << 20) -#define
> MLX5_FLOW_LAYER_IPV6_ENCAP (1u << 21)
> +#define MLX5_FLOW_LAYER_IPIP (1u << 21) #define
> +MLX5_FLOW_LAYER_IPV6_ENCAP (1u << 22)
> 
>  /* Outer Masks. */
>  #define MLX5_FLOW_LAYER_OUTER_L3 \
> --
> 1.8.3.1

Applied to next-net-mlx,

Kindest regards
Raslan Darawsheh
diff mbox series

Patch

diff --git a/drivers/net/mlx5/mlx5_flow.h b/drivers/net/mlx5/mlx5_flow.h
index ece967a..3f96bec 100644
--- a/drivers/net/mlx5/mlx5_flow.h
+++ b/drivers/net/mlx5/mlx5_flow.h
@@ -58,8 +58,8 @@ 
 #define MLX5_FLOW_LAYER_ICMP6 (1u << 19)
 #define MLX5_FLOW_LAYER_GRE_KEY (1u << 20)
 
-#define MLX5_FLOW_LAYER_IPIP (1u << 20)
-#define MLX5_FLOW_LAYER_IPV6_ENCAP (1u << 21)
+#define MLX5_FLOW_LAYER_IPIP (1u << 21)
+#define MLX5_FLOW_LAYER_IPV6_ENCAP (1u << 22)
 
 /* Outer Masks. */
 #define MLX5_FLOW_LAYER_OUTER_L3 \