[v1] net/ice: remove unnecessary type cast in rx/tx ring setup
diff mbox series

Message ID 1563929545-25010-1-git-send-email-haiyue.wang@intel.com
State Accepted, archived
Delegated to: Qi Zhang
Headers show
Series
  • [v1] net/ice: remove unnecessary type cast in rx/tx ring setup
Related show

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation fail Compilation issues

Commit Message

Haiyue Wang July 24, 2019, 12:52 a.m. UTC
The memzone's start virtual address pointer (addr) is of type void *,
no need to add type cast.

Signed-off-by: Haiyue Wang <haiyue.wang@intel.com>
---
 drivers/net/ice/ice_rxtx.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Ye Xiaolong July 24, 2019, 8:17 a.m. UTC | #1
On 07/24, Haiyue Wang wrote:
>The memzone's start virtual address pointer (addr) is of type void *,
>no need to add type cast.
>
>Signed-off-by: Haiyue Wang <haiyue.wang@intel.com>
>---
> drivers/net/ice/ice_rxtx.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/drivers/net/ice/ice_rxtx.c b/drivers/net/ice/ice_rxtx.c
>index 3353f23..0282b53 100644
>--- a/drivers/net/ice/ice_rxtx.c
>+++ b/drivers/net/ice/ice_rxtx.c
>@@ -664,7 +664,7 @@ ice_rx_queue_setup(struct rte_eth_dev *dev,
> 	memset(rz->addr, 0, ring_size);
> 
> 	rxq->rx_ring_dma = rz->iova;
>-	rxq->rx_ring = (union ice_rx_desc *)rz->addr;
>+	rxq->rx_ring = rz->addr;
> 
> #ifdef RTE_LIBRTE_ICE_RX_ALLOW_BULK_ALLOC
> 	len = (uint16_t)(nb_desc + ICE_RX_MAX_BURST);
>@@ -882,7 +882,7 @@ ice_tx_queue_setup(struct rte_eth_dev *dev,
> 	txq->tx_deferred_start = tx_conf->tx_deferred_start;
> 
> 	txq->tx_ring_dma = tz->iova;
>-	txq->tx_ring = (struct ice_tx_desc *)tz->addr;
>+	txq->tx_ring = tz->addr;
> 
> 	/* Allocate software ring */
> 	txq->sw_ring =
>-- 
>2.7.4
>

Reviewed-by: Xiaolong Ye <xiaolong.ye@intel.com>
Zhang, Qi Z July 24, 2019, 1:02 p.m. UTC | #2
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Ye Xiaolong
> Sent: Wednesday, July 24, 2019 4:18 PM
> To: Wang, Haiyue <haiyue.wang@intel.com>
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v1] net/ice: remove unnecessary type cast in
> rx/tx ring setup

Should be "Rx/Tx"
> 
> On 07/24, Haiyue Wang wrote:
> >The memzone's start virtual address pointer (addr) is of type void *,
> >no need to add type cast.
> >
> >Signed-off-by: Haiyue Wang <haiyue.wang@intel.com>
> >---
> 
> Reviewed-by: Xiaolong Ye <xiaolong.ye@intel.com>

Applied to dpdk-next-net-intel.

Thanks
Qi

Patch
diff mbox series

diff --git a/drivers/net/ice/ice_rxtx.c b/drivers/net/ice/ice_rxtx.c
index 3353f23..0282b53 100644
--- a/drivers/net/ice/ice_rxtx.c
+++ b/drivers/net/ice/ice_rxtx.c
@@ -664,7 +664,7 @@  ice_rx_queue_setup(struct rte_eth_dev *dev,
 	memset(rz->addr, 0, ring_size);
 
 	rxq->rx_ring_dma = rz->iova;
-	rxq->rx_ring = (union ice_rx_desc *)rz->addr;
+	rxq->rx_ring = rz->addr;
 
 #ifdef RTE_LIBRTE_ICE_RX_ALLOW_BULK_ALLOC
 	len = (uint16_t)(nb_desc + ICE_RX_MAX_BURST);
@@ -882,7 +882,7 @@  ice_tx_queue_setup(struct rte_eth_dev *dev,
 	txq->tx_deferred_start = tx_conf->tx_deferred_start;
 
 	txq->tx_ring_dma = tz->iova;
-	txq->tx_ring = (struct ice_tx_desc *)tz->addr;
+	txq->tx_ring = tz->addr;
 
 	/* Allocate software ring */
 	txq->sw_ring =