diff mbox series

net/bnxt: fix a check in rxq start op

Message ID 20191007194151.63131-1-ajit.khaparde@broadcom.com (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers
Series net/bnxt: fix a check in rxq start op |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/iol-compilation success Compile Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/Intel-compilation success Compilation OK
ci/iol-mellanox-Performance success Performance Testing PASS

Commit Message

Ajit Khaparde Oct. 7, 2019, 7:41 p.m. UTC 
  From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>

This patch fixes a wrong check in rxq start operation.
Driver should check for rxq start state.

Fixes: 4316e043cbcb ("net/bnxt: fix RxQ stop/start handling")
Signed-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
Reviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
---
 drivers/net/bnxt/bnxt_ring.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Ferruh Yigit Oct. 8, 2019, 9:54 a.m. UTC | #1 
On 10/7/2019 8:41 PM, Ajit Khaparde wrote:
> From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
> 
> This patch fixes a wrong check in rxq start operation.
> Driver should check for rxq start state.
> 
> Fixes: 4316e043cbcb ("net/bnxt: fix RxQ stop/start handling")
> Signed-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
> Reviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>

Squashed into relevant commit in next-net, thanks.
diff mbox series

Patch

diff --git a/drivers/net/bnxt/bnxt_ring.c b/drivers/net/bnxt/bnxt_ring.c
index a6e0915e2d..d31e4f3964 100644
--- a/drivers/net/bnxt/bnxt_ring.c
+++ b/drivers/net/bnxt/bnxt_ring.c
@@ -612,7 +612,7 @@  int bnxt_alloc_hwrm_rx_ring(struct bnxt *bp, int queue_index)
 	if (rc)
 		goto err_out;
 
-	if (!rxq->rx_started) {
+	if (rxq->rx_started) {
 		if (bnxt_init_one_rx_ring(rxq)) {
 			RTE_LOG(ERR, PMD,
 				"bnxt_init_one_rx_ring failed!\n");