doc: remove Flow Director feature from hns3.ini and hns3_vf.ini
diff mbox series

Message ID 1570760993-32369-1-git-send-email-xavier.huwei@huawei.com
State Accepted
Delegated to: Ferruh Yigit
Headers show
Series
  • doc: remove Flow Director feature from hns3.ini and hns3_vf.ini
Related show

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Wei Hu (Xavier) Oct. 11, 2019, 2:29 a.m. UTC
This patch removes deprecated feature 'Flow Director' from hns3.ini
and hns3_vf.ini because the feature has been removed from the
feature list in the following commit:
Commit 030febb6642c ("doc: remove deprecated ethdev features")

Signed-off-by: Wei Hu (Xavier) <xavier.huwei@huawei.com>
Signed-off-by: Chunsong Feng <fengchunsong@huawei.com>
---
 doc/guides/nics/features/hns3.ini    | 1 -
 doc/guides/nics/features/hns3_vf.ini | 1 -
 2 files changed, 2 deletions(-)

Comments

Ferruh Yigit Oct. 15, 2019, 11:11 a.m. UTC | #1
On 10/11/2019 3:29 AM, Wei Hu (Xavier) wrote:
> This patch removes deprecated feature 'Flow Director' from hns3.ini
> and hns3_vf.ini because the feature has been removed from the
> feature list in the following commit:
> Commit 030febb6642c ("doc: remove deprecated ethdev features")
> 
> Signed-off-by: Wei Hu (Xavier) <xavier.huwei@huawei.com>
> Signed-off-by: Chunsong Feng <fengchunsong@huawei.com>
> ---
>  doc/guides/nics/features/hns3.ini    | 1 -
>  doc/guides/nics/features/hns3_vf.ini | 1 -
>  2 files changed, 2 deletions(-)
> 
> diff --git a/doc/guides/nics/features/hns3.ini b/doc/guides/nics/features/hns3.ini
> index 308048c..6df789e 100644
> --- a/doc/guides/nics/features/hns3.ini
> +++ b/doc/guides/nics/features/hns3.ini
> @@ -16,7 +16,6 @@ RSS key update       = Y
>  RSS reta update      = Y
>  DCB                  = Y
>  VLAN filter          = Y
> -Flow director        = Y
>  Flow control         = Y
>  Flow API             = Y
>  CRC offload          = Y
> diff --git a/doc/guides/nics/features/hns3_vf.ini b/doc/guides/nics/features/hns3_vf.ini
> index a152ca5..41497c4 100644
> --- a/doc/guides/nics/features/hns3_vf.ini
> +++ b/doc/guides/nics/features/hns3_vf.ini
> @@ -13,7 +13,6 @@ RSS hash             = Y
>  RSS key update       = Y
>  RSS reta update      = Y
>  VLAN filter          = Y
> -Flow director        = Y
>  Flow API             = Y
>  CRC offload          = Y
>  VLAN offload         = Y
> 

Indeed I am for adding that feature back to list, sent a mail for it:
https://mails.dpdk.org/archives/dev/2019-October/147203.html

Will proceed with this patch based on its result.
Thomas Monjalon Oct. 25, 2019, 11:08 a.m. UTC | #2
15/10/2019 13:11, Ferruh Yigit:
> On 10/11/2019 3:29 AM, Wei Hu (Xavier) wrote:
> > This patch removes deprecated feature 'Flow Director' from hns3.ini
> > and hns3_vf.ini because the feature has been removed from the
> > feature list in the following commit:
> > Commit 030febb6642c ("doc: remove deprecated ethdev features")
> > 
> > Signed-off-by: Wei Hu (Xavier) <xavier.huwei@huawei.com>
> > Signed-off-by: Chunsong Feng <fengchunsong@huawei.com>
> > ---
> >  doc/guides/nics/features/hns3.ini    | 1 -
> >  doc/guides/nics/features/hns3_vf.ini | 1 -
> >  2 files changed, 2 deletions(-)

Now we need to add hinic to this fix.

> Indeed I am for adding that feature back to list, sent a mail for it:
> https://mails.dpdk.org/archives/dev/2019-October/147203.html

This can be a long discussion.

> Will proceed with this patch based on its result.

Please fix the doc and let's discuss about how to improve the doc in a second step.
Ferruh Yigit Oct. 31, 2019, 7:04 p.m. UTC | #3
On 10/25/2019 12:08 PM, Thomas Monjalon wrote:
> 15/10/2019 13:11, Ferruh Yigit:
>> On 10/11/2019 3:29 AM, Wei Hu (Xavier) wrote:
>>> This patch removes deprecated feature 'Flow Director' from hns3.ini
>>> and hns3_vf.ini because the feature has been removed from the
>>> feature list in the following commit:
>>> Commit 030febb6642c ("doc: remove deprecated ethdev features")
>>>
>>> Signed-off-by: Wei Hu (Xavier) <xavier.huwei@huawei.com>
>>> Signed-off-by: Chunsong Feng <fengchunsong@huawei.com>
>>> ---
>>>  doc/guides/nics/features/hns3.ini    | 1 -
>>>  doc/guides/nics/features/hns3_vf.ini | 1 -
>>>  2 files changed, 2 deletions(-)
> 
> Now we need to add hinic to this fix.
> 
>> Indeed I am for adding that feature back to list, sent a mail for it:
>> https://mails.dpdk.org/archives/dev/2019-October/147203.html
> 
> This can be a long discussion.
> 
>> Will proceed with this patch based on its result.
> 
> Please fix the doc and let's discuss about how to improve the doc in a second step.
> 

Applied to dpdk-next-net/master, thanks.

Patch
diff mbox series

diff --git a/doc/guides/nics/features/hns3.ini b/doc/guides/nics/features/hns3.ini
index 308048c..6df789e 100644
--- a/doc/guides/nics/features/hns3.ini
+++ b/doc/guides/nics/features/hns3.ini
@@ -16,7 +16,6 @@  RSS key update       = Y
 RSS reta update      = Y
 DCB                  = Y
 VLAN filter          = Y
-Flow director        = Y
 Flow control         = Y
 Flow API             = Y
 CRC offload          = Y
diff --git a/doc/guides/nics/features/hns3_vf.ini b/doc/guides/nics/features/hns3_vf.ini
index a152ca5..41497c4 100644
--- a/doc/guides/nics/features/hns3_vf.ini
+++ b/doc/guides/nics/features/hns3_vf.ini
@@ -13,7 +13,6 @@  RSS hash             = Y
 RSS key update       = Y
 RSS reta update      = Y
 VLAN filter          = Y
-Flow director        = Y
 Flow API             = Y
 CRC offload          = Y
 VLAN offload         = Y