[v1] doc: update cross build tool links and fix compiling issue
diff mbox series

Message ID 1570848014-20125-1-git-send-email-joyce.kong@arm.com
State Superseded
Headers show
Series
  • [v1] doc: update cross build tool links and fix compiling issue
Related show

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Joyce Kong (Arm Technology China) Oct. 12, 2019, 2:40 a.m. UTC
Update cross build tool links as newer cross build tools
version are provided on Linaro.
And remove the command 'git checkout' which results in
compiling error when cross building.

Fixes: 01add9da25cd ("doc: add cross compiling guide")
Cc: stable@dpdk.org

Signed-off-by: Joyce Kong <joyce.kong@arm.com>
---
 doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst | 15 +++++++--------
 1 file changed, 7 insertions(+), 8 deletions(-)

Comments

Jerin Jacob Oct. 12, 2019, 1:03 p.m. UTC | #1
On Sat, Oct 12, 2019 at 8:10 AM Joyce Kong <joyce.kong@arm.com> wrote:
>
> Update cross build tool links as newer cross build tools
> version are provided on Linaro.
> And remove the command 'git checkout' which results in
> compiling error when cross building.
>
> Fixes: 01add9da25cd ("doc: add cross compiling guide")
> Cc: stable@dpdk.org
>
> Signed-off-by: Joyce Kong <joyce.kong@arm.com>
> ---
>  doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst | 15 +++++++--------
>  1 file changed, 7 insertions(+), 8 deletions(-)
>
> diff --git a/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst b/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst
> index 28a8e09..09f1ab0 100644
> --- a/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst
> +++ b/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst
> @@ -16,19 +16,19 @@ Obtain the cross tool chain
>  The latest cross compile tool chain can be downloaded from:
>  https://developer.arm.com/open-source/gnu-toolchain/gnu-a/downloads.
>
> -Following is the step to get the version 8.2, latest one at the time of this writing.
> +Following is the step to get the version 8.3, latest one at the time of this writing.
>
>  .. code-block:: console
>
> -   wget https://developer.arm.com/-/media/Files/downloads/gnu-a/8.2-2019.01/gcc-arm-8.2-2019.01-x86_64-aarch64-linux-gnu.tar.xz
> +   wget https://developer.arm.com/-/media/Files/downloads/gnu-a/8.3-2019.03/binrel/gcc-arm-8.3-2019.03-x86_64-aarch64-linux-gnu.tar.xz

Could you use the URL with "latest" as softlink so that we don't need
to update this page as when a new
toolchain released?

Since it owned by ARM, if the soft link scheme does not exist on the
"https://developer.arm.com/-/media/Files/downloads", I hope it can be
added. It will be a good addition. Thoughts?
Joyce Kong (Arm Technology China) Oct. 23, 2019, 5:47 a.m. UTC | #2
Hi Jerin,

> -----Original Message-----
> From: Jerin Jacob <jerinjacobk@gmail.com>
> Sent: Saturday, October 12, 2019 9:04 PM
> To: Joyce Kong (Arm Technology China) <Joyce.Kong@arm.com>
> Cc: dpdk-dev <dev@dpdk.org>; nd <nd@arm.com>; thomas@monjalon.net;
> jerinj@marvell.com; Honnappa Nagarahalli
> <Honnappa.Nagarahalli@arm.com>; Gavin Hu (Arm Technology China)
> <Gavin.Hu@arm.com>; stable@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v1] doc: update cross build tool links and fix
> compiling issue
> 
> On Sat, Oct 12, 2019 at 8:10 AM Joyce Kong <joyce.kong@arm.com> wrote:
> >
> > Update cross build tool links as newer cross build tools version are
> > provided on Linaro.
> > And remove the command 'git checkout' which results in compiling error
> > when cross building.
> >
> > Fixes: 01add9da25cd ("doc: add cross compiling guide")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Joyce Kong <joyce.kong@arm.com>
> > ---
> >  doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst | 15
> > +++++++--------
> >  1 file changed, 7 insertions(+), 8 deletions(-)
> >
> > diff --git a/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst
> > b/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst
> > index 28a8e09..09f1ab0 100644
> > --- a/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst
> > +++ b/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst
> > @@ -16,19 +16,19 @@ Obtain the cross tool chain  The latest cross
> > compile tool chain can be downloaded from:
> >  https://developer.arm.com/open-source/gnu-toolchain/gnu-a/downloads.
> >
> > -Following is the step to get the version 8.2, latest one at the time of this
> writing.
> > +Following is the step to get the version 8.3, latest one at the time of this
> writing.
> >
> >  .. code-block:: console
> >
> > -   wget https://developer.arm.com/-/media/Files/downloads/gnu-a/8.2-
> 2019.01/gcc-arm-8.2-2019.01-x86_64-aarch64-linux-gnu.tar.xz
> > +   wget
> > + https://developer.arm.com/-/media/Files/downloads/gnu-a/8.3-
> 2019.03/
> > + binrel/gcc-arm-8.3-2019.03-x86_64-aarch64-linux-gnu.tar.xz
> 
> Could you use the URL with "latest" as softlink so that we don't need to
> update this page as when a new toolchain released?
> 
> Since it owned by ARM, if the soft link scheme does not exist on the
> "https://developer.arm.com/-/media/Files/downloads", I hope it can be
> added. It will be a good addition. Thoughts?

As the latest soft link doesn't exist, I changed the cross building example from
8.3 to a common description like gcc-arm-<version>-x86_64-aarch64-linux-gnu.

Patch
diff mbox series

diff --git a/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst b/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst
index 28a8e09..09f1ab0 100644
--- a/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst
+++ b/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst
@@ -16,19 +16,19 @@  Obtain the cross tool chain
 The latest cross compile tool chain can be downloaded from:
 https://developer.arm.com/open-source/gnu-toolchain/gnu-a/downloads.
 
-Following is the step to get the version 8.2, latest one at the time of this writing.
+Following is the step to get the version 8.3, latest one at the time of this writing.
 
 .. code-block:: console
 
-   wget https://developer.arm.com/-/media/Files/downloads/gnu-a/8.2-2019.01/gcc-arm-8.2-2019.01-x86_64-aarch64-linux-gnu.tar.xz
+   wget https://developer.arm.com/-/media/Files/downloads/gnu-a/8.3-2019.03/binrel/gcc-arm-8.3-2019.03-x86_64-aarch64-linux-gnu.tar.xz
 
 Unzip and add into the PATH
 ---------------------------
 
 .. code-block:: console
 
-   tar -xvf gcc-arm-8.2-2019.01-x86_64-aarch64-linux-gnu.tar.xz
-   export PATH=$PATH:<cross_install_dir>/gcc-arm-8.2-2019.01-x86_64-aarch64-linux-gnu/bin
+   tar -xvf gcc-arm-8.3-2019.03-x86_64-aarch64-linux-gnu.tar.xz
+   export PATH=$PATH:<cross_install_dir>/gcc-arm-8.3-2019.03-x86_64-aarch64-linux-gnu/bin
 
 .. note::
 
@@ -50,7 +50,6 @@  NUMA is required by most modern machines, not needed for non-NUMA architectures.
 
    git clone https://github.com/numactl/numactl.git
    cd numactl
-   git checkout v2.0.11 -b v2.0.11
    ./autogen.sh
    autoconf -i
    ./configure --host=aarch64-linux-gnu CC=aarch64-linux-gnu-gcc --prefix=<numa install dir>
@@ -71,9 +70,9 @@  Copy the NUMA header files and lib to the cross compiler's directories:
 
 .. code-block:: console
 
-   cp <numa_install_dir>/include/numa*.h <cross_install_dir>/gcc-arm-8.2-2019.01-x86_64-aarch64-linux-gnu/bin/../aarch64-linux-gnu/libc/usr/include/
-   cp <numa_install_dir>/lib/libnuma.a <cross_install_dir>/gcc-arm-8.2-2019.01-x86_64-aarch64-linux-gnu/lib/gcc/aarch64-linux-gnu/8.2/
-   cp <numa_install_dir>/lib/libnuma.so <cross_install_dir>/gcc-arm-8.2-2019.01-x86_64-aarch64-linux-gnu/lib/gcc/aarch64-linux-gnu/8.2/
+   cp <numa_install_dir>/include/numa*.h <cross_install_dir>/gcc-arm-8.3-2019.03-x86_64-aarch64-linux-gnu/bin/../aarch64-linux-gnu/libc/usr/include/
+   cp <numa_install_dir>/lib/libnuma.a <cross_install_dir>/gcc-arm-8.3-2019.03-x86_64-aarch64-linux-gnu/lib/gcc/aarch64-linux-gnu/8.3/
+   cp <numa_install_dir>/lib/libnuma.so <cross_install_dir>/gcc-arm-8.3-2019.03-x86_64-aarch64-linux-gnu/lib/gcc/aarch64-linux-gnu/8.3/
 
 .. _configure_and_cross_compile_dpdk_build: