[v2] net/ice: fix RSS rule destroy
Checks
Commit Message
This patch changes RSS rule destroy interface from ice_rem_vsi_rss_cfg()
to ice_rem_rss_cfg(). To coordinate with input set change, it should
destroy a specific flow rule but not all vsi cfg.
Fixes: 5ad3db8d4bdd ("net/ice: enable advanced RSS")
Signed-off-by: Simei Su <simei.su@intel.com>
---
drivers/net/ice/ice_hash.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
Comments
> -----Original Message-----
> From: Su, Simei <simei.su@intel.com>
> Sent: Monday, November 11, 2019 3:55 PM
> To: Zhang, Qi Z <qi.z.zhang@intel.com>; Xing, Beilei <beilei.xing@intel.com>;
> Ye, Xiaolong <xiaolong.ye@intel.com>
> Cc: dev@dpdk.org; Su, Simei <simei.su@intel.com>
> Subject: [PATCH v2] net/ice: fix RSS rule destroy
>
> This patch changes RSS rule destroy interface from ice_rem_vsi_rss_cfg() to
> ice_rem_rss_cfg(). To coordinate with input set change, it should destroy a
> specific flow rule but not all vsi cfg.
>
> Fixes: 5ad3db8d4bdd ("net/ice: enable advanced RSS")
>
> Signed-off-by: Simei Su <simei.su@intel.com>
Acked-by: Qi Zhang <qi.z.zhang@intel.com>
On 11/11, Simei Su wrote:
>This patch changes RSS rule destroy interface from ice_rem_vsi_rss_cfg()
>to ice_rem_rss_cfg(). To coordinate with input set change, it should
>destroy a specific flow rule but not all vsi cfg.
>
>Fixes: 5ad3db8d4bdd ("net/ice: enable advanced RSS")
>
>Signed-off-by: Simei Su <simei.su@intel.com>
>---
> drivers/net/ice/ice_hash.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
>diff --git a/drivers/net/ice/ice_hash.c b/drivers/net/ice/ice_hash.c
>index 8dc3146..57e7d55 100644
>--- a/drivers/net/ice/ice_hash.c
>+++ b/drivers/net/ice/ice_hash.c
>@@ -530,7 +530,8 @@ struct ice_hash_match_type ice_hash_type_list[] = {
> (1 << VSIQF_HASH_CTL_HASH_SCHEME_S);
> ICE_WRITE_REG(hw, VSIQF_HASH_CTL(vsi->vsi_id), reg);
> } else {
>- ret = ice_rem_vsi_rss_cfg(hw, vsi->idx);
>+ ret = ice_rem_rss_cfg(hw, vsi->idx,
>+ filter_ptr->hashed_flds, filter_ptr->packet_hdr);
> if (ret) {
> rte_flow_error_set(error, EINVAL,
> RTE_FLOW_ERROR_TYPE_HANDLE, NULL,
>--
>1.8.3.1
>
Applied to dpdk-next-net-intel. Thanks.
@@ -530,7 +530,8 @@ struct ice_hash_match_type ice_hash_type_list[] = {
(1 << VSIQF_HASH_CTL_HASH_SCHEME_S);
ICE_WRITE_REG(hw, VSIQF_HASH_CTL(vsi->vsi_id), reg);
} else {
- ret = ice_rem_vsi_rss_cfg(hw, vsi->idx);
+ ret = ice_rem_rss_cfg(hw, vsi->idx,
+ filter_ptr->hashed_flds, filter_ptr->packet_hdr);
if (ret) {
rte_flow_error_set(error, EINVAL,
RTE_FLOW_ERROR_TYPE_HANDLE, NULL,