[v2,1/6] net/bnxt: add missing checks for firmware reset
diff mbox series

Message ID 20191113150700.2517-2-ajit.khaparde@broadcom.com
State Accepted, archived
Delegated to: Ajit Khaparde
Headers show
  • bnxt patchset with bug fixes
Related show


Context Check Description
ci/iol-mellanox-Performance success Performance Testing PASS
ci/Intel-compilation success Compilation OK
ci/iol-compilation success Compile Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/checkpatch warning coding style issues

Commit Message

Ajit Khaparde Nov. 13, 2019, 3:06 p.m. UTC
From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>

Driver should fail the eth_dev_ops callbacks and accessing
Tx and Rx queues when device is in reset or in error state.
Added missing checks for fw reset in few routines.

Fixes: be14720def9c ("net/bnxt: support FW reset")

Reviewed-by: Santoshkumar Karanappa Rastapur <santosh.rastapur@broadcom.com>
Signed-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
Signed-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
 drivers/net/bnxt/bnxt_ethdev.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff mbox series

diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c
index e39b87365..94dbe2f1d 100644
--- a/drivers/net/bnxt/bnxt_ethdev.c
+++ b/drivers/net/bnxt/bnxt_ethdev.c
@@ -2067,8 +2067,12 @@  static void
 bnxt_rxq_info_get_op(struct rte_eth_dev *dev, uint16_t queue_id,
 	struct rte_eth_rxq_info *qinfo)
+	struct bnxt *bp = dev->data->dev_private;
 	struct bnxt_rx_queue *rxq;
+	if (is_bnxt_in_error(bp))
+		return;
 	rxq = dev->data->rx_queues[queue_id];
 	qinfo->mp = rxq->mb_pool;
@@ -2084,8 +2088,12 @@  static void
 bnxt_txq_info_get_op(struct rte_eth_dev *dev, uint16_t queue_id,
 	struct rte_eth_txq_info *qinfo)
+	struct bnxt *bp = dev->data->dev_private;
 	struct bnxt_tx_queue *txq;
+	if (is_bnxt_in_error(bp))
+		return;
 	txq = dev->data->tx_queues[queue_id];
 	qinfo->nb_desc = txq->nb_tx_desc;