[2/3] ethdev: decrease verbosity of not disabled offload logs
Checks
Commit Message
Right now a PMD decides if it is critical that an offload cannot
be disabled (i.e. not requested, but still enabled). If PMD treaks
it as OK, we should not spam logs with corresponding messsages
by default. Default log level in ethdev is INFO, so change the
message level to DEBUG.
Fixes: 1daa33805824 ("ethdev: validate offloads set by PMD")
Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
---
lib/librte_ethdev/rte_ethdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On 11/14/2019 4:40 PM, Andrew Rybchenko wrote:
> Right now a PMD decides if it is critical that an offload cannot
> be disabled (i.e. not requested, but still enabled). If PMD treaks
> it as OK, we should not spam logs with corresponding messsages
> by default. Default log level in ethdev is INFO, so change the
> message level to DEBUG.
>
> Fixes: 1daa33805824 ("ethdev: validate offloads set by PMD")
>
> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
On Thu, 14 Nov 2019 16:40:51 +0000
Andrew Rybchenko <arybchenko@solarflare.com> wrote:
> Right now a PMD decides if it is critical that an offload cannot
> be disabled (i.e. not requested, but still enabled). If PMD treaks
> it as OK, we should not spam logs with corresponding messsages
> by default. Default log level in ethdev is INFO, so change the
> message level to DEBUG.
>
> Fixes: 1daa33805824 ("ethdev: validate offloads set by PMD")
>
> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
Acked-by: Stephen Hemminger <stephen@networkplumber.org>
@@ -1204,7 +1204,7 @@ validate_offloads(uint16_t port_id, uint64_t req_offloads,
/* Chech if offload couldn't be disabled. */
if (offload & set_offloads) {
- RTE_ETHDEV_LOG(INFO,
+ RTE_ETHDEV_LOG(DEBUG,
"Port %u failed to disable %s offload %s\n",
port_id, offload_type, offload_name(offload));
}