diff mbox series

[3/3] ethdev: improve message about not disabled offload

Message ID 1573749654-30038-3-git-send-email-arybchenko@solarflare.com (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers
Series [1/3] drivers/net: fix RSS hash offload set if Rx mode is RSS only |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK
ci/travis-robot success Travis build: passed

Commit Message

Andrew Rybchenko Nov. 14, 2019, 4:40 p.m. UTC 
  Avoid usaged of "failed" in the message about not requested but
enabled offload, since it is not a failure.

Fixes: 1daa33805824 ("ethdev: validate offloads set by PMD")

Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
---
 lib/librte_ethdev/rte_ethdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Ferruh Yigit Nov. 14, 2019, 4:53 p.m. UTC | #1 
On 11/14/2019 4:40 PM, Andrew Rybchenko wrote:
> Avoid usaged of "failed" in the message about not requested but
> enabled offload, since it is not a failure.
> 
> Fixes: 1daa33805824 ("ethdev: validate offloads set by PMD")
> 
> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>

Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
Stephen Hemminger Nov. 14, 2019, 4:58 p.m. UTC | #2 
On Thu, 14 Nov 2019 16:40:52 +0000
Andrew Rybchenko <arybchenko@solarflare.com> wrote:

> Avoid usaged of "failed" in the message about not requested but
> enabled offload, since it is not a failure.
> 
> Fixes: 1daa33805824 ("ethdev: validate offloads set by PMD")
> 
> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>

Acked-by: Stephen Hemminger <stephen@networkplumber.org>
diff mbox series

Patch

diff --git a/lib/librte_ethdev/rte_ethdev.c b/lib/librte_ethdev/rte_ethdev.c
index 19ca08b04a..76d4a20ed3 100644
--- a/lib/librte_ethdev/rte_ethdev.c
+++ b/lib/librte_ethdev/rte_ethdev.c
@@ -1205,7 +1205,7 @@  validate_offloads(uint16_t port_id, uint64_t req_offloads,
 		/* Chech if offload couldn't be disabled. */
 		if (offload & set_offloads) {
 			RTE_ETHDEV_LOG(DEBUG,
-				"Port %u failed to disable %s offload %s\n",
+				"Port %u %s offload %s is not requested but enabled\n",
 				port_id, offload_type, offload_name(offload));
 		}