| Message ID | 1574165536-2586-2-git-send-email-arybchenko@solarflare.com |
|---|---|
| State | Accepted, archived |
| Delegated to: | Ferruh Yigit |
| Headers | show |
| Series |
|
| Related | show |
| Context | Check | Description |
|---|---|---|
| ci/Intel-compilation | success | Compilation OK |
| ci/checkpatch | success | coding style OK |
On 11/19/2019 12:12 PM, Andrew Rybchenko wrote: > The offload was added, but the deprecation notice was not removed. > > Fixes: 5d308972954c ("ethdev: add mbuf RSS update as an offload") > > Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
On 11/19/2019 3:04 PM, Ferruh Yigit wrote: > On 11/19/2019 12:12 PM, Andrew Rybchenko wrote: >> The offload was added, but the deprecation notice was not removed. >> >> Fixes: 5d308972954c ("ethdev: add mbuf RSS update as an offload") >> >> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com> > > Acked-by: Ferruh Yigit <ferruh.yigit@intel.com> > Applied to dpdk-next-net/master, thanks.
diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst index 65076acb13..afa94b43e2 100644 --- a/doc/guides/rel_notes/deprecation.rst +++ b/doc/guides/rel_notes/deprecation.rst @@ -59,13 +59,12 @@ Deprecation Notices - ``rte_eth_dev_stop`` - ``rte_eth_dev_close`` -* ethdev: New offload flags ``DEV_RX_OFFLOAD_RSS_HASH`` and - ``DEV_RX_OFFLOAD_FLOW_MARK`` will be added in 19.11. +* ethdev: New offload flags ``DEV_RX_OFFLOAD_FLOW_MARK`` will be added in 19.11. This will allow application to enable or disable PMDs from updating - ``rte_mbuf::hash::rss`` and ``rte_mbuf::hash::fdir`` respectively. + ``rte_mbuf::hash::fdir``. This scheme will allow PMDs to avoid writes to ``rte_mbuf`` fields on Rx and thereby improve Rx performance if application wishes do so. - In 19.11 PMDs will still update the fields even when the offloads are not + In 19.11 PMDs will still update the field even when the offload is not enabled. * cryptodev: support for using IV with all sizes is added, J0 still can
The offload was added, but the deprecation notice was not removed. Fixes: 5d308972954c ("ethdev: add mbuf RSS update as an offload") Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com> --- v2: - 'offloads are' -> 'offload is' in the last sentence doc/guides/rel_notes/deprecation.rst | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)