From patchwork Mon Dec 2 07:48:51 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Xiaolong Ye X-Patchwork-Id: 63453 X-Patchwork-Delegate: xiaolong.ye@intel.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 706F5A04B5; Mon, 2 Dec 2019 09:01:53 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 52C921BFEE; Mon, 2 Dec 2019 08:58:35 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id BF98F1BFCA for ; Mon, 2 Dec 2019 08:58:26 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Dec 2019 23:58:26 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,268,1571727600"; d="scan'208";a="207993463" Received: from dpdk_yexl_af_xdp.sh.intel.com ([10.67.119.186]) by fmsmga008.fm.intel.com with ESMTP; 01 Dec 2019 23:58:25 -0800 From: Xiaolong Ye To: Beilei Xing , Qi Zhang Cc: dev@dpdk.org, Xiaolong Ye , Jacob Keller Date: Mon, 2 Dec 2019 15:48:51 +0800 Message-Id: <20191202074935.97629-26-xiaolong.ye@intel.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20191202074935.97629-1-xiaolong.ye@intel.com> References: <20191202074935.97629-1-xiaolong.ye@intel.com> Subject: [dpdk-dev] [PATCH 25/69] net/i40e/base: add opcodes reserved comments X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" When there are opcodes wrapped behind feature flags, we should indicate that the opcode number is reserved if the define is not set. This helps ensure that we do not attempt to re-use an opcode number in multiple ways, as this could break PF and VF matches. Signed-off-by: Jacob Keller Reviewed-by: Stillwell Jr Paul M Reviewed-by: Williams Mitch A Reviewed-by: Brandeburg Jesse Signed-off-by: Xiaolong Ye --- drivers/net/i40e/base/virtchnl.h | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/i40e/base/virtchnl.h b/drivers/net/i40e/base/virtchnl.h index 0d7825089..d0d612571 100644 --- a/drivers/net/i40e/base/virtchnl.h +++ b/drivers/net/i40e/base/virtchnl.h @@ -107,11 +107,15 @@ enum virtchnl_ops { VIRTCHNL_OP_EVENT = 17, /* must ALWAYS be 17 */ #ifdef VIRTCHNL_SOL_VF_SUPPORT VIRTCHNL_OP_GET_ADDNL_SOL_CONFIG = 19, +#else + /* opcode 19 is reserved */ #endif #ifdef VIRTCHNL_IWARP VIRTCHNL_OP_IWARP = 20, /* advanced opcode */ VIRTCHNL_OP_CONFIG_IWARP_IRQ_MAP = 21, /* advanced opcode */ VIRTCHNL_OP_RELEASE_IWARP_IRQ_MAP = 22, /* advanced opcode */ +#else + /* opcodes 20, 21, and 22 are reserved */ #endif VIRTCHNL_OP_CONFIG_RSS_KEY = 23, VIRTCHNL_OP_CONFIG_RSS_LUT = 24,