From patchwork Wed Dec 11 11:01:40 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Monjalon X-Patchwork-Id: 63751 Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8544DA04F6; Wed, 11 Dec 2019 12:01:48 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B98602C6A; Wed, 11 Dec 2019 12:01:47 +0100 (CET) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 11C2B2C6A; Wed, 11 Dec 2019 12:01:45 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 7E46E222EF; Wed, 11 Dec 2019 06:01:45 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Wed, 11 Dec 2019 06:01:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; s=mesmtp; bh=A5U35YXIN9 0KdmSzgRIHcNJc7ANx38+cXhGT7TawmpY=; b=VdXZX1PTT5NbIfFaFORqcmLJ/h TyYt9eg5gjZBL2ie+gHMLBcL13Dv1ngDGrSOeXC7egJ8xHdQifrIQxLRtfRMqFWL 98jyBuclPtZliiCuLD9fw7+mHKPkHGBWl3nWXaLNKIQXUj7Dza9ABgvF0fNPmkA1 ZnFOuIrwjKm465YU4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:date:from :in-reply-to:message-id:mime-version:references:subject:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; bh=A5U35YXIN90KdmSzgRIHcNJc7ANx38+cXhGT7TawmpY=; b=aPL0SQoC zZbB9W/8Pc17OfIZZEOqkfzN2WMIPS57Isnwn59pztJk7hZsIKRy0UAHPqkP+97n Ip2EWJ7f/NxqPtXU44Uz6smmm5tuHDFOegu7/xqIVkKfb66/Y/uDrQ3ADkHjUyH+ LotvpZmKLrVMAt2N3MCMwZCD22ofSROl+bhdU0QkQtkCxfgDUz1AdvZKqe7ClWxN 98M1lgYdETL7MENf8ES7vBHMo+7QLOO+494S7cbK4VNwP8epOOxJsWYCAErCUfqk GR2UfybEEjfxqA+4CAH318/kkEJSzgCUWfwlNDK05bAAcdroqeI/j2TVoy6VUBhe wJ9bWrNBB9G6Rg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedrudelhedgudekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkffojghfggfgsedtkeertdertddtnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecuff homhgrihhnpehgihhthhhusgdrtghomhenucfkphepjeejrddufeegrddvtdefrddukeeg necurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvg htnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.monjalon.net (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id C5CF5306010D; Wed, 11 Dec 2019 06:01:43 -0500 (EST) From: Thomas Monjalon To: John McNamara , Marko Kovacevic Cc: Robin Jarry , Bruce Richardson , dev@dpdk.org, stable@dpdk.org Date: Wed, 11 Dec 2019 12:01:40 +0100 Message-Id: <20191211110140.1290875-1-thomas@monjalon.net> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191209210000.906000-1-thomas@monjalon.net> References: <20191209210000.906000-1-thomas@monjalon.net> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH v2] doc: fix build with python 3.8 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" After upgrading to python-3.8.0, a syntax mismatch is revealed: doc/guides/conf.py:240: SyntaxWarning: "is not" with a literal. Did you mean "!="? if value is not '': Removing "is not ''" seems the right thing to do. A patch may also be needed in the RTD theme package: https://github.com/readthedocs/sphinx_rtd_theme/commit/a49a812c.diff (not included in release 0.4.3) Fixes: 9db3f52126fb ("doc: generate NIC overview table from ini files") Cc: stable@dpdk.org Signed-off-by: Thomas Monjalon Acked-by: Bruce Richardson --- v1: if value != '' v2: if value --- doc/guides/conf.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/guides/conf.py b/doc/guides/conf.py index e2b52e2df9..0892c06dec 100644 --- a/doc/guides/conf.py +++ b/doc/guides/conf.py @@ -237,7 +237,7 @@ def generate_overview_table(output_filename, table_id, section, table_name, titl ini_filename)) continue - if value is not '': + if value: # Get the first letter only. ini_data[ini_filename][name] = value[0]