eal: improve user notification for too low memzone segments

Message ID 20191216154406.3827-1-arturx.trybula@intel.com (mailing list archive)
State Superseded, archived
Delegated to: akhil goyal
Headers
Series eal: improve user notification for too low memzone segments |

Checks

Context Check Description
ci/checkpatch warning coding style issues
ci/iol-testing success Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/travis-robot warning Travis build: failed
ci/Intel-compilation fail apply issues

Commit Message

Artur Trybula Dec. 16, 2019, 3:44 p.m. UTC
  In case of too low number of memzone segements user notification
was misleading. This patch improves the description by providing
better explanation about the cause.

Signed-off-by: Artur Trybula <arturx.trybula@intel.com>
---
 lib/librte_eal/common/eal_common_memzone.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
  

Comments

Fiona Trahe Dec. 16, 2019, 4:05 p.m. UTC | #1
Including Anatoly as maintainer for lib/librte_eal/common/eal_common_mem*

> -----Original Message-----
> From: Trybula, ArturX <arturx.trybula@intel.com>
> Sent: Monday, December 16, 2019 3:44 PM
> To: dev@dpdk.org; Trahe, Fiona <fiona.trahe@intel.com>; shallyv@marvell.com; Dybkowski, AdamX
> <adamx.dybkowski@intel.com>; Danilewicz, MarcinX <marcinx.danilewicz@intel.com>; Trybula, ArturX
> <arturx.trybula@intel.com>; akhil.goyal@nxp.com
> Subject: [PATCH] eal: improve user notification for too low memzone segments
> 
> In case of too low number of memzone segements user notification
> was misleading. This patch improves the description by providing
> better explanation about the cause.
> 
> Signed-off-by: Artur Trybula <arturx.trybula@intel.com>
> ---
>  lib/librte_eal/common/eal_common_memzone.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/librte_eal/common/eal_common_memzone.c
> b/lib/librte_eal/common/eal_common_memzone.c
> index 99b8d6531..c1acbbb3c 100644
> --- a/lib/librte_eal/common/eal_common_memzone.c
> +++ b/lib/librte_eal/common/eal_common_memzone.c
> @@ -71,7 +71,7 @@ memzone_reserve_aligned_thread_unsafe(const char *name, size_t len,
> 
>  	/* no more room in config */
>  	if (arr->count >= arr->len) {
> -		RTE_LOG(ERR, EAL, "%s(): No more room in config\n", __func__);
> +		RTE_LOG(ERR, EAL, "%s(): Number of requested memzone segments exceeds
> RTE_MAX_MEMZONE\n", __func__);
>  		rte_errno = ENOSPC;
>  		return NULL;
>  	}
> --
> 2.17.1
  

Patch

diff --git a/lib/librte_eal/common/eal_common_memzone.c b/lib/librte_eal/common/eal_common_memzone.c
index 99b8d6531..c1acbbb3c 100644
--- a/lib/librte_eal/common/eal_common_memzone.c
+++ b/lib/librte_eal/common/eal_common_memzone.c
@@ -71,7 +71,7 @@  memzone_reserve_aligned_thread_unsafe(const char *name, size_t len,
 
 	/* no more room in config */
 	if (arr->count >= arr->len) {
-		RTE_LOG(ERR, EAL, "%s(): No more room in config\n", __func__);
+		RTE_LOG(ERR, EAL, "%s(): Number of requested memzone segments exceeds RTE_MAX_MEMZONE\n", __func__);
 		rte_errno = ENOSPC;
 		return NULL;
 	}