[v2] net/ice: use the copy API to do MAC assignment
diff mbox series

Message ID 20200103020204.11356-1-haiyue.wang@intel.com
State Superseded
Headers show
Series
  • [v2] net/ice: use the copy API to do MAC assignment
Related show

Checks

Context Check Description
ci/Intel-compilation success Compilation OK
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-nxp-Performance success Performance Testing PASS
ci/iol-testing success Testing PASS
ci/travis-robot success Travis build: passed
ci/checkpatch success coding style OK

Commit Message

Haiyue Wang Jan. 3, 2020, 2:02 a.m. UTC
Use the fast copy an Ethernet address API to do MAC assignment, instead
of calling rte_memcpy function.

Signed-off-by: Haiyue Wang <haiyue.wang@intel.com>
---
v2: Update the commit title and message, use the rte_ether_addr_copy API
    instead of just changing the length definition to make code style clean.

 drivers/net/ice/ice_ethdev.c | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

Comments

Yang, Qiming Jan. 3, 2020, 2:23 a.m. UTC | #1
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Haiyue Wang
> Sent: Friday, January 3, 2020 10:02 AM
> To: dev@dpdk.org; stephen@networkplumber.org; Zhang, Qi Z
> <qi.z.zhang@intel.com>; Ye, Xiaolong <xiaolong.ye@intel.com>
> Cc: Wang, Haiyue <haiyue.wang@intel.com>
> Subject: [dpdk-dev] [PATCH v2] net/ice: use the copy API to do MAC
> assignment
> 
> Use the fast copy an Ethernet address API to do MAC assignment, instead of

I think the grammar is not right. Do you want to say 'Use rte_ether_addr_copy API to copy an Ethernet address'?

> calling rte_memcpy function.
> 
> Signed-off-by: Haiyue Wang <haiyue.wang@intel.com>
> ---
> v2: Update the commit title and message, use the rte_ether_addr_copy API
>     instead of just changing the length definition to make code style clean.
> 
>  drivers/net/ice/ice_ethdev.c | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c index
> 2cbd82c94..d104df26f 100644
> --- a/drivers/net/ice/ice_ethdev.c
> +++ b/drivers/net/ice/ice_ethdev.c
> @@ -873,7 +873,7 @@ ice_add_mac_filter(struct ice_vsi *vsi, struct
> rte_ether_addr *mac_addr)
>  		ret = -ENOMEM;
>  		goto DONE;
>  	}
> -	rte_memcpy(&f->mac_info.mac_addr, mac_addr, ETH_ADDR_LEN);
> +	rte_ether_addr_copy(mac_addr, &f->mac_info.mac_addr);
>  	TAILQ_INSERT_TAIL(&vsi->mac_list, f, next);
>  	vsi->mac_num++;
> 
> @@ -1660,16 +1660,16 @@ ice_setup_vsi(struct ice_pf *pf, enum
> ice_vsi_type type)
> 
>  	if (type == ICE_VSI_PF) {
>  		/* MAC configuration */
> -		rte_memcpy(pf->dev_addr.addr_bytes,
> -			   hw->port_info->mac.perm_addr,
> -			   ETH_ADDR_LEN);
> +		rte_ether_addr_copy((struct rte_ether_addr *)
> +					hw->port_info->mac.perm_addr,
> +				    &pf->dev_addr);
> 
> -		rte_memcpy(&mac_addr, &pf->dev_addr,
> RTE_ETHER_ADDR_LEN);
> +		rte_ether_addr_copy(&pf->dev_addr, &mac_addr);
>  		ret = ice_add_mac_filter(vsi, &mac_addr);
>  		if (ret != ICE_SUCCESS)
>  			PMD_INIT_LOG(ERR, "Failed to add dflt MAC filter");
> 
> -		rte_memcpy(&mac_addr, &broadcast,
> RTE_ETHER_ADDR_LEN);
> +		rte_ether_addr_copy(&broadcast, &mac_addr);
>  		ret = ice_add_mac_filter(vsi, &mac_addr);
>  		if (ret != ICE_SUCCESS)
>  			PMD_INIT_LOG(ERR, "Failed to add MAC filter"); @@
> -3267,7 +3267,7 @@ static int ice_macaddr_set(struct rte_eth_dev *dev,
>  		PMD_DRV_LOG(ERR, "Failed to add mac filter");
>  		return -EIO;
>  	}
> -	memcpy(&pf->dev_addr, mac_addr, ETH_ADDR_LEN);
> +	rte_ether_addr_copy(mac_addr, &pf->dev_addr);
> 
>  	flags = ICE_AQC_MAN_MAC_UPDATE_LAA_WOL;
>  	ret = ice_aq_manage_mac_write(hw, mac_addr->addr_bytes, flags,
> NULL);
> --
> 2.17.1
Haiyue Wang Jan. 3, 2020, 2:59 a.m. UTC | #2
> -----Original Message-----
> From: Yang, Qiming <qiming.yang@intel.com>
> Sent: Friday, January 3, 2020 10:23
> To: Wang, Haiyue <haiyue.wang@intel.com>; dev@dpdk.org; stephen@networkplumber.org; Zhang, Qi Z
> <qi.z.zhang@intel.com>; Ye, Xiaolong <xiaolong.ye@intel.com>
> Cc: Wang, Haiyue <haiyue.wang@intel.com>
> Subject: RE: [dpdk-dev] [PATCH v2] net/ice: use the copy API to do MAC assignment
> 
> 
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Haiyue Wang
> > Sent: Friday, January 3, 2020 10:02 AM
> > To: dev@dpdk.org; stephen@networkplumber.org; Zhang, Qi Z
> > <qi.z.zhang@intel.com>; Ye, Xiaolong <xiaolong.ye@intel.com>
> > Cc: Wang, Haiyue <haiyue.wang@intel.com>
> > Subject: [dpdk-dev] [PATCH v2] net/ice: use the copy API to do MAC
> > assignment
> >
> > Use the fast copy an Ethernet address API to do MAC assignment, instead of
> 
> I think the grammar is not right. Do you want to say 'Use rte_ether_addr_copy API to copy an Ethernet
> address'?

Yes, I copied the rte_ether_addr_copy's comment 'Fast copy an Ethernet address. ' ;-)
> 
> > calling rte_memcpy function.
> >
> > Signed-off-by: Haiyue Wang <haiyue.wang@intel.com>
> > ---
> > v2: Update the commit title and message, use the rte_ether_addr_copy API
> >     instead of just changing the length definition to make code style clean.
> >
> >  drivers/net/ice/ice_ethdev.c | 14 +++++++-------
> >  1 file changed, 7 insertions(+), 7 deletions(-)
> >
> > diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c index
> > 2cbd82c94..d104df26f 100644
> > --- a/drivers/net/ice/ice_ethdev.c
> > +++ b/drivers/net/ice/ice_ethdev.c
> > @@ -873,7 +873,7 @@ ice_add_mac_filter(struct ice_vsi *vsi, struct
> > rte_ether_addr *mac_addr)
> >  		ret = -ENOMEM;
> >  		goto DONE;
> >  	}
> > -	rte_memcpy(&f->mac_info.mac_addr, mac_addr, ETH_ADDR_LEN);
> > +	rte_ether_addr_copy(mac_addr, &f->mac_info.mac_addr);
> >  	TAILQ_INSERT_TAIL(&vsi->mac_list, f, next);
> >  	vsi->mac_num++;
> >
> > @@ -1660,16 +1660,16 @@ ice_setup_vsi(struct ice_pf *pf, enum
> > ice_vsi_type type)
> >
> >  	if (type == ICE_VSI_PF) {
> >  		/* MAC configuration */
> > -		rte_memcpy(pf->dev_addr.addr_bytes,
> > -			   hw->port_info->mac.perm_addr,
> > -			   ETH_ADDR_LEN);
> > +		rte_ether_addr_copy((struct rte_ether_addr *)
> > +					hw->port_info->mac.perm_addr,
> > +				    &pf->dev_addr);
> >
> > -		rte_memcpy(&mac_addr, &pf->dev_addr,
> > RTE_ETHER_ADDR_LEN);
> > +		rte_ether_addr_copy(&pf->dev_addr, &mac_addr);
> >  		ret = ice_add_mac_filter(vsi, &mac_addr);
> >  		if (ret != ICE_SUCCESS)
> >  			PMD_INIT_LOG(ERR, "Failed to add dflt MAC filter");
> >
> > -		rte_memcpy(&mac_addr, &broadcast,
> > RTE_ETHER_ADDR_LEN);
> > +		rte_ether_addr_copy(&broadcast, &mac_addr);
> >  		ret = ice_add_mac_filter(vsi, &mac_addr);
> >  		if (ret != ICE_SUCCESS)
> >  			PMD_INIT_LOG(ERR, "Failed to add MAC filter"); @@
> > -3267,7 +3267,7 @@ static int ice_macaddr_set(struct rte_eth_dev *dev,
> >  		PMD_DRV_LOG(ERR, "Failed to add mac filter");
> >  		return -EIO;
> >  	}
> > -	memcpy(&pf->dev_addr, mac_addr, ETH_ADDR_LEN);
> > +	rte_ether_addr_copy(mac_addr, &pf->dev_addr);
> >
> >  	flags = ICE_AQC_MAN_MAC_UPDATE_LAA_WOL;
> >  	ret = ice_aq_manage_mac_write(hw, mac_addr->addr_bytes, flags,
> > NULL);
> > --
> > 2.17.1

Patch
diff mbox series

diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c
index 2cbd82c94..d104df26f 100644
--- a/drivers/net/ice/ice_ethdev.c
+++ b/drivers/net/ice/ice_ethdev.c
@@ -873,7 +873,7 @@  ice_add_mac_filter(struct ice_vsi *vsi, struct rte_ether_addr *mac_addr)
 		ret = -ENOMEM;
 		goto DONE;
 	}
-	rte_memcpy(&f->mac_info.mac_addr, mac_addr, ETH_ADDR_LEN);
+	rte_ether_addr_copy(mac_addr, &f->mac_info.mac_addr);
 	TAILQ_INSERT_TAIL(&vsi->mac_list, f, next);
 	vsi->mac_num++;
 
@@ -1660,16 +1660,16 @@  ice_setup_vsi(struct ice_pf *pf, enum ice_vsi_type type)
 
 	if (type == ICE_VSI_PF) {
 		/* MAC configuration */
-		rte_memcpy(pf->dev_addr.addr_bytes,
-			   hw->port_info->mac.perm_addr,
-			   ETH_ADDR_LEN);
+		rte_ether_addr_copy((struct rte_ether_addr *)
+					hw->port_info->mac.perm_addr,
+				    &pf->dev_addr);
 
-		rte_memcpy(&mac_addr, &pf->dev_addr, RTE_ETHER_ADDR_LEN);
+		rte_ether_addr_copy(&pf->dev_addr, &mac_addr);
 		ret = ice_add_mac_filter(vsi, &mac_addr);
 		if (ret != ICE_SUCCESS)
 			PMD_INIT_LOG(ERR, "Failed to add dflt MAC filter");
 
-		rte_memcpy(&mac_addr, &broadcast, RTE_ETHER_ADDR_LEN);
+		rte_ether_addr_copy(&broadcast, &mac_addr);
 		ret = ice_add_mac_filter(vsi, &mac_addr);
 		if (ret != ICE_SUCCESS)
 			PMD_INIT_LOG(ERR, "Failed to add MAC filter");
@@ -3267,7 +3267,7 @@  static int ice_macaddr_set(struct rte_eth_dev *dev,
 		PMD_DRV_LOG(ERR, "Failed to add mac filter");
 		return -EIO;
 	}
-	memcpy(&pf->dev_addr, mac_addr, ETH_ADDR_LEN);
+	rte_ether_addr_copy(mac_addr, &pf->dev_addr);
 
 	flags = ICE_AQC_MAN_MAC_UPDATE_LAA_WOL;
 	ret = ice_aq_manage_mac_write(hw, mac_addr->addr_bytes, flags, NULL);