diff mbox series

build: skip processing docs folder if docs disabled

Message ID 20200103144613.2892178-1-bruce.richardson@intel.com (mailing list archive)
State Superseded, archived
Headers
Series build: skip processing docs folder if docs disabled |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/travis-robot warning Travis build: failed
ci/Intel-compilation success Compilation OK

Commit Message

Bruce Richardson Jan. 3, 2020, 2:46 p.m. UTC 
  While each target is set to be ignored if the docs are disabled in the
meson build, there is little reason to process the docs folder at all.

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
 doc/meson.build | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Thomas Monjalon Feb. 16, 2020, 10:07 a.m. UTC | #1 
03/01/2020 15:46, Bruce Richardson:
> While each target is set to be ignored if the docs are disabled in the
> meson build, there is little reason to process the docs folder at all.
> 
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
> +if not get_option('enable_docs')
> +	subdir_done()
> +endif

Why this patch is marked as superseded in patchwork?
David Marchand Feb. 16, 2020, 2:17 p.m. UTC | #2 
On Sun, Feb 16, 2020 at 11:07 AM Thomas Monjalon <thomas@monjalon.net> wrote:
>
> 03/01/2020 15:46, Bruce Richardson:
> > While each target is set to be ignored if the docs are disabled in the
> > meson build, there is little reason to process the docs folder at all.
> >
> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> > ---
> > +if not get_option('enable_docs')
> > +     subdir_done()
> > +endif
>
> Why this patch is marked as superseded in patchwork?
>

Because there were other series superseding it.
https://patchwork.dpdk.org/project/dpdk/list/?series=8032&state=%2A&archive=both
https://patchwork.dpdk.org/project/dpdk/list/?series=8039&state=%2A&archive=both
https://patchwork.dpdk.org/project/dpdk/list/?series=8056&state=%2A&archive=both

Then after testing and discussion, it was dropped.
http://inbox.dpdk.org/dev/CAJFAV8wNAtWf0a3s=XMqz+itgKgOMNybDHtCDN-ihpJNM8yzvQ@mail.gmail.com/
diff mbox series

Patch

diff --git a/doc/meson.build b/doc/meson.build
index c5410d85d..c49ec8476 100644
--- a/doc/meson.build
+++ b/doc/meson.build
@@ -1,6 +1,10 @@ 
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright(c) 2018 Luca Boccassi <bluca@debian.org>
 
+if not get_option('enable_docs')
+	subdir_done()
+endif
+
 doc_targets = []
 doc_target_names = []
 subdir('api')