examples/fips_validation: fix parsing of cipher length for AES-GCM
diff mbox series

Message ID 1578303191-24846-1-git-send-email-marchana@marvell.com
State Accepted
Delegated to: akhil goyal
Headers show
Series
  • examples/fips_validation: fix parsing of cipher length for AES-GCM
Related show

Checks

Context Check Description
ci/Intel-compilation success Compilation OK
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-nxp-Performance success Performance Testing PASS
ci/iol-testing success Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/checkpatch success coding style OK

Commit Message

Archana Muniganti Jan. 6, 2020, 9:33 a.m. UTC
From: Sucharitha Sarananaga <ssarananaga@marvell.com>

Cipher length need to be updated in case of AES-GCM decryption.

Fixes: 4aaad2995e13 ("examples/fips_validation: support GCM parsing")

Signed-off-by: Archana Muniganti <marchana@marvell.com>
Signed-off-by: Sucharitha Sarananaga <ssarananaga@marvell.com>
---
 examples/fips_validation/fips_validation_gcm.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Archana Muniganti Jan. 6, 2020, 1:44 p.m. UTC | #1
Hi Akhil,

Please see inline.

Thanks,
Archana

> -----Original Message-----
> From: Akhil Goyal <akhil.goyal@nxp.com>
> Sent: Monday, January 6, 2020 3:09 PM
> To: Archana Muniganti <marchana@marvell.com>;
> marko.kovacevic@intel.com; roy.fan.zhang@intel.com
> Cc: Sucharitha Sarananaga <ssarananaga@marvell.com>; Anoob Joseph
> <anoobj@marvell.com>; Abed Mohammad Kamaluddin
> <akamaluddin@marvell.com>; Jerin Jacob Kollanukkaran
> <jerinj@marvell.com>; dev@dpdk.org; stable@dpdk.org
> Subject: [EXT] RE: [PATCH] examples/fips_validation: fix parsing of cipher
> length for AES-GCM
> 
> External Email
> 
> ----------------------------------------------------------------------
> > From: Sucharitha Sarananaga <ssarananaga@marvell.com>
> >
> > Cipher length need to be updated in case of AES-GCM decryption.
> >
> > Fixes: 4aaad2995e13 ("examples/fips_validation: support GCM parsing")
> >
> > Signed-off-by: Archana Muniganti <marchana@marvell.com>
> > Signed-off-by: Sucharitha Sarananaga <ssarananaga@marvell.com>
> > ---
> >  examples/fips_validation/fips_validation_gcm.c | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/examples/fips_validation/fips_validation_gcm.c
> > b/examples/fips_validation/fips_validation_gcm.c
> > index ea48ddf..f295025 100644
> > --- a/examples/fips_validation/fips_validation_gcm.c
> > +++ b/examples/fips_validation/fips_validation_gcm.c
> > @@ -19,6 +19,7 @@
> >  #define PTLEN_STR	"PTlen = "
> >  #define AADLEN_STR	"AADlen = "
> >  #define TAGLEN_STR	"Taglen = "
> > +#define CTLEN_STR	"PTlen = "
> Typo. Should be CTlen
[Archana] NIST request file for AES-GCM test vectors contains 'PTlen =' field.
This field holds plain text length when encrypt test vectors are used. And same
field holds cipher text length when decrypt test vectors are used.
Hence added a new macro that will be used in AES-GCM 'decryption'
Anoob Joseph Jan. 7, 2020, 7:16 a.m. UTC | #2
> -----Original Message-----
> From: Archana Muniganti <marchana@marvell.com>
> Sent: Monday, January 6, 2020 3:03 PM
> To: marko.kovacevic@intel.com; roy.fan.zhang@intel.com;
> akhil.goyal@nxp.com
> Cc: Sucharitha Sarananaga <ssarananaga@marvell.com>; Anoob Joseph
> <anoobj@marvell.com>; Abed Mohammad Kamaluddin
> <akamaluddin@marvell.com>; Jerin Jacob Kollanukkaran <jerinj@marvell.com>;
> dev@dpdk.org; stable@dpdk.org; Archana Muniganti
> <marchana@marvell.com>
> Subject: [PATCH] examples/fips_validation: fix parsing of cipher length for AES-
> GCM
> 
> From: Sucharitha Sarananaga <ssarananaga@marvell.com>
> 
> Cipher length need to be updated in case of AES-GCM decryption.
> 
> Fixes: 4aaad2995e13 ("examples/fips_validation: support GCM parsing")
> 
> Signed-off-by: Archana Muniganti <marchana@marvell.com>
> Signed-off-by: Sucharitha Sarananaga <ssarananaga@marvell.com>
 
Acked-by: Anoob Joseph <anoobj@marvell.com>
Akhil Goyal Feb. 5, 2020, 12:29 p.m. UTC | #3
> >
> > From: Sucharitha Sarananaga <ssarananaga@marvell.com>
> >
> > Cipher length need to be updated in case of AES-GCM decryption.
> >
> > Fixes: 4aaad2995e13 ("examples/fips_validation: support GCM parsing")
> >
> > Signed-off-by: Archana Muniganti <marchana@marvell.com>
> > Signed-off-by: Sucharitha Sarananaga <ssarananaga@marvell.com>
> 
> Acked-by: Anoob Joseph <anoobj@marvell.com>

Applied to dpdk-next-crypto

Thanks.

Patch
diff mbox series

diff --git a/examples/fips_validation/fips_validation_gcm.c b/examples/fips_validation/fips_validation_gcm.c
index ea48ddf..f295025 100644
--- a/examples/fips_validation/fips_validation_gcm.c
+++ b/examples/fips_validation/fips_validation_gcm.c
@@ -19,6 +19,7 @@ 
 #define PTLEN_STR	"PTlen = "
 #define AADLEN_STR	"AADlen = "
 #define TAGLEN_STR	"Taglen = "
+#define CTLEN_STR	"PTlen = "
 
 #define COUNT_STR	"Count = "
 #define KEY_STR		"Key = "
@@ -46,6 +47,7 @@  struct fips_test_callback gcm_interim_vectors[] = {
 		{KEYLEN_STR, parser_read_uint32_bit_val, &vec.aead.key},
 		{IVLEN_STR, parser_read_uint32_bit_val, &vec.iv},
 		{PTLEN_STR, parser_read_uint32_bit_val, &vec.pt},
+		{CTLEN_STR, parser_read_uint32_bit_val, &vec.ct},
 		{AADLEN_STR, parser_read_uint32_bit_val, &vec.aead.aad},
 		{TAGLEN_STR, parser_read_uint32_bit_val,
 				&vec.aead.digest},