net/e1000: use macro PCI_PRI_FMT for PCI log format

Message ID 1578918028-23280-1-git-send-email-wangyunjian@huawei.com (mailing list archive)
State Accepted, archived
Delegated to: xiaolong ye
Headers
Series net/e1000: use macro PCI_PRI_FMT for PCI log format |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-testing success Testing PASS
ci/iol-nxp-Performance success Performance Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/Intel-compilation success Compilation OK
ci/travis-robot warning Travis build: failed

Commit Message

Yunjian Wang Jan. 13, 2020, 12:20 p.m. UTC
  Use PCI_PRI_FMT instead of "%04d:%02d:%02d:%d" print format.

Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>
---
 drivers/net/e1000/em_ethdev.c  | 2 +-
 drivers/net/e1000/igb_ethdev.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
  

Comments

Xiaolong Ye Feb. 2, 2020, 6:55 a.m. UTC | #1
On 01/13, Yunjian Wang wrote:
>Use PCI_PRI_FMT instead of "%04d:%02d:%02d:%d" print format.
>
>Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>
>---
> drivers/net/e1000/em_ethdev.c  | 2 +-
> drivers/net/e1000/igb_ethdev.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/drivers/net/e1000/em_ethdev.c b/drivers/net/e1000/em_ethdev.c
>index 080cbe2df..188cda350 100644
>--- a/drivers/net/e1000/em_ethdev.c
>+++ b/drivers/net/e1000/em_ethdev.c
>@@ -1605,7 +1605,7 @@ eth_em_interrupt_action(struct rte_eth_dev *dev,
> 	} else {
> 		PMD_INIT_LOG(INFO, " Port %d: Link Down", dev->data->port_id);
> 	}
>-	PMD_INIT_LOG(DEBUG, "PCI Address: %04d:%02d:%02d:%d",
>+	PMD_INIT_LOG(DEBUG, "PCI Address: " PCI_PRI_FMT,
> 		     pci_dev->addr.domain, pci_dev->addr.bus,
> 		     pci_dev->addr.devid, pci_dev->addr.function);
> 
>diff --git a/drivers/net/e1000/igb_ethdev.c b/drivers/net/e1000/igb_ethdev.c
>index a3e30dbe5..30e303c9b 100644
>--- a/drivers/net/e1000/igb_ethdev.c
>+++ b/drivers/net/e1000/igb_ethdev.c
>@@ -2914,7 +2914,7 @@ eth_igb_interrupt_action(struct rte_eth_dev *dev,
> 				     dev->data->port_id);
> 		}
> 
>-		PMD_INIT_LOG(DEBUG, "PCI Address: %04d:%02d:%02d:%d",
>+		PMD_INIT_LOG(DEBUG, "PCI Address: " PCI_PRI_FMT,
> 			     pci_dev->addr.domain,
> 			     pci_dev->addr.bus,
> 			     pci_dev->addr.devid,
>-- 
>2.19.1
>
>

Acked-by: Xiaolong Ye <xiaolong.ye@intel.com>

Applied to dpdk-next-net-intel, Thanks.
  

Patch

diff --git a/drivers/net/e1000/em_ethdev.c b/drivers/net/e1000/em_ethdev.c
index 080cbe2df..188cda350 100644
--- a/drivers/net/e1000/em_ethdev.c
+++ b/drivers/net/e1000/em_ethdev.c
@@ -1605,7 +1605,7 @@  eth_em_interrupt_action(struct rte_eth_dev *dev,
 	} else {
 		PMD_INIT_LOG(INFO, " Port %d: Link Down", dev->data->port_id);
 	}
-	PMD_INIT_LOG(DEBUG, "PCI Address: %04d:%02d:%02d:%d",
+	PMD_INIT_LOG(DEBUG, "PCI Address: " PCI_PRI_FMT,
 		     pci_dev->addr.domain, pci_dev->addr.bus,
 		     pci_dev->addr.devid, pci_dev->addr.function);
 
diff --git a/drivers/net/e1000/igb_ethdev.c b/drivers/net/e1000/igb_ethdev.c
index a3e30dbe5..30e303c9b 100644
--- a/drivers/net/e1000/igb_ethdev.c
+++ b/drivers/net/e1000/igb_ethdev.c
@@ -2914,7 +2914,7 @@  eth_igb_interrupt_action(struct rte_eth_dev *dev,
 				     dev->data->port_id);
 		}
 
-		PMD_INIT_LOG(DEBUG, "PCI Address: %04d:%02d:%02d:%d",
+		PMD_INIT_LOG(DEBUG, "PCI Address: " PCI_PRI_FMT,
 			     pci_dev->addr.domain,
 			     pci_dev->addr.bus,
 			     pci_dev->addr.devid,