diff mbox series

raw/octeontx2_ep: fix shared library

Message ID 20200120110539.1963221-1-thomas@monjalon.net (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers
Series raw/octeontx2_ep: fix shared library |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK
ci/travis-robot success Travis build: passed

Commit Message

Thomas Monjalon Jan. 20, 2020, 11:05 a.m. UTC 
  The version of the PMD should not be overwritten with LIBABIVER.
All internal libs must have the same version.

Moreover, specifying LIBABIVER in the driver causes a symbolic link loop:
librte_rawdev_octeontx2_ep.so.1 -> librte_rawdev_octeontx2_ep.so.1

Fixes: 56d46d13f736 ("raw/octeontx2_ep: add build infra and device probe")

Reported-by: Ferruh Yigit <ferruh.yigit@intel.com>
Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
---
 drivers/raw/octeontx2_ep/Makefile | 2 --
 1 file changed, 2 deletions(-)

Comments

Ferruh Yigit Jan. 20, 2020, 11:06 a.m. UTC | #1 
On 1/20/2020 11:05 AM, Thomas Monjalon wrote:
> The version of the PMD should not be overwritten with LIBABIVER.
> All internal libs must have the same version.
> 
> Moreover, specifying LIBABIVER in the driver causes a symbolic link loop:
> librte_rawdev_octeontx2_ep.so.1 -> librte_rawdev_octeontx2_ep.so.1
> 
> Fixes: 56d46d13f736 ("raw/octeontx2_ep: add build infra and device probe")
> 
> Reported-by: Ferruh Yigit <ferruh.yigit@intel.com>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>

Tested-by: Ferruh Yigit <ferruh.yigit@intel.com>
Thomas Monjalon Jan. 20, 2020, 11:44 a.m. UTC | #2 
20/01/2020 12:06, Ferruh Yigit:
> On 1/20/2020 11:05 AM, Thomas Monjalon wrote:
> > The version of the PMD should not be overwritten with LIBABIVER.
> > All internal libs must have the same version.
> > 
> > Moreover, specifying LIBABIVER in the driver causes a symbolic link loop:
> > librte_rawdev_octeontx2_ep.so.1 -> librte_rawdev_octeontx2_ep.so.1
> > 
> > Fixes: 56d46d13f736 ("raw/octeontx2_ep: add build infra and device probe")
> > 
> > Reported-by: Ferruh Yigit <ferruh.yigit@intel.com>
> > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> 
> Tested-by: Ferruh Yigit <ferruh.yigit@intel.com>

Applied, thanks Ferruh
diff mbox series

Patch

diff --git a/drivers/raw/octeontx2_ep/Makefile b/drivers/raw/octeontx2_ep/Makefile
index 44fdf89599..1a54bf56f0 100644
--- a/drivers/raw/octeontx2_ep/Makefile
+++ b/drivers/raw/octeontx2_ep/Makefile
@@ -30,8 +30,6 @@  endif
 
 EXPORT_MAP := rte_rawdev_octeontx2_ep_version.map
 
-LIBABIVER := 1
-
 #
 # All source are stored in SRCS-y
 #