From patchwork Thu Feb 6 20:01:46 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Manish Chopra X-Patchwork-Id: 65642 X-Patchwork-Delegate: jerinj@marvell.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 67A31A0541; Thu, 6 Feb 2020 21:02:04 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E8E9F1C201; Thu, 6 Feb 2020 21:01:54 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id BEA221C1FF; Thu, 6 Feb 2020 21:01:53 +0100 (CET) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 016JxiC9013705; Thu, 6 Feb 2020 12:01:53 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-type; s=pfpt0818; bh=UyDLw5tAY2nBJ0vf8Uva/uZI6T9PG6TWwIVLinz0Qoo=; b=LlwYRky2VtkSmNae/VghYr1TJyn5Lmd7D1iZ4MjmDA9HOH4pLDFKMYiEZYtgid1wgacd Of/81Ov1s+7zNX3Iz7rk8CvcMPpmI6C8zflA5RiqpVnNsFKSlbpxb1Oh/ml8B3z3E+Ma x2tEntqxBVoGOYZoImD4JmE2HQuOY/f4gLwylLkAl7aqE2l4zM/7lwyqfqIU60UXFWBJ ufjaZoZZJmfz2nPl7HWQuktPYq4cBP2XQd0UFb/a8zwnInKEoenGPV36WeQ5FJ9UC7We YRJpareb7fjh3hZazCuRGXMtYw0fwQ9Eh0AtO6WSTQIzGY+18Bi4xxDuV3u/eNe1isA2 oQ== Received: from sc-exch04.marvell.com ([199.233.58.184]) by mx0a-0016f401.pphosted.com with ESMTP id 2xyhmth5f4-2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Thu, 06 Feb 2020 12:01:52 -0800 Received: from SC-EXCH01.marvell.com (10.93.176.81) by SC-EXCH04.marvell.com (10.93.176.84) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 6 Feb 2020 12:01:51 -0800 Received: from maili.marvell.com (10.93.176.43) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Thu, 6 Feb 2020 12:01:51 -0800 Received: from dut1171.mv.qlogic.com (unknown [10.112.88.18]) by maili.marvell.com (Postfix) with ESMTP id AC3833F703F; Thu, 6 Feb 2020 12:01:51 -0800 (PST) Received: from dut1171.mv.qlogic.com (localhost [127.0.0.1]) by dut1171.mv.qlogic.com (8.14.7/8.14.7) with ESMTP id 016K1paI014849; Thu, 6 Feb 2020 12:01:51 -0800 Received: (from root@localhost) by dut1171.mv.qlogic.com (8.14.7/8.14.7/Submit) id 016K1plZ014848; Thu, 6 Feb 2020 12:01:51 -0800 From: Manish Chopra To: , CC: , , Date: Thu, 6 Feb 2020 12:01:46 -0800 Message-ID: <20200206200146.14808-2-manishc@marvell.com> X-Mailer: git-send-email 2.12.0 In-Reply-To: <20200206200146.14808-1-manishc@marvell.com> References: <20200206200146.14808-1-manishc@marvell.com> MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138, 18.0.572 definitions=2020-02-06_03:2020-02-06, 2020-02-06 signatures=0 Subject: [dpdk-dev] [PATCH 2/2] net/qede: Do not stop vport if not started. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Stopping an already disabled vport leads to firmware assert. Stop the vport only if it was started. Fixes: 2ea6f76aff40 ("qede: add core driver") Cc: stable@dpdk.org Signed-off-by: Manish Chopra Signed-off-by: Rasesh Mody --- drivers/net/qede/qede_ethdev.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_ethdev.c index 500440c2c..74dfe895a 100644 --- a/drivers/net/qede/qede_ethdev.c +++ b/drivers/net/qede/qede_ethdev.c @@ -1509,7 +1509,8 @@ static void qede_dev_close(struct rte_eth_dev *eth_dev) if (eth_dev->data->dev_started) qede_dev_stop(eth_dev); - qede_stop_vport(edev); + if (qdev->vport_started) + qede_stop_vport(edev); qdev->vport_started = false; qede_fdir_dealloc_resc(eth_dev); qede_dealloc_fp_resc(eth_dev);