diff mbox series

app/testpmd: parse flow command line for AH

Message ID 1581570460-27068-1-git-send-email-xiao.zhang@intel.com (mailing list archive)
State Superseded, archived
Delegated to: xiaolong ye
Headers
Series app/testpmd: parse flow command line for AH |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/iol-testing success Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/travis-robot warning Travis build: failed
ci/Intel-compilation success Compilation OK

Commit Message

Xiao Zhang Feb. 13, 2020, 5:07 a.m. UTC 
  add ITEM_AH
add ITEM_AH_SPI

Signed-off-by: Xiao Zhang <xiao.zhang@intel.com>
---
 app/test-pmd/cmdline_flow.c | 29 +++++++++++++++++++++++++++++
 1 file changed, 29 insertions(+)

Comments

Xiaolong Ye Feb. 13, 2020, 6:45 a.m. UTC | #1 
Hi, Xiao

On 02/13, Xiao Zhang wrote:
>add ITEM_AH
>add ITEM_AH_SPI

Better to add some descriptive sentence about this patch in commit log instead
of some simple bullets.

Thanks,
Xiaolong

>
>Signed-off-by: Xiao Zhang <xiao.zhang@intel.com>
>---
> app/test-pmd/cmdline_flow.c | 29 +++++++++++++++++++++++++++++
> 1 file changed, 29 insertions(+)
>
>diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c
>index c2cc4c5..680cb1c 100644
>--- a/app/test-pmd/cmdline_flow.c
>+++ b/app/test-pmd/cmdline_flow.c
>@@ -220,6 +220,8 @@ enum index {
> 	ITEM_L2TPV3OIP_SESSION_ID,
> 	ITEM_ESP,
> 	ITEM_ESP_SPI,
>+	ITEM_AH,
>+	ITEM_AH_SPI,
> 
> 	/* Validate/create actions. */
> 	ACTIONS,
>@@ -768,6 +770,7 @@ static const enum index next_item[] = {
> 	ITEM_TAG,
> 	ITEM_L2TPV3OIP,
> 	ITEM_ESP,
>+	ITEM_AH,
> 	END_SET,
> 	ZERO,
> };
>@@ -1046,6 +1049,12 @@ static const enum index item_esp[] = {
> 	ZERO,
> };
> 
>+static const enum index item_ah[] = {
>+	ITEM_AH_SPI,
>+	ITEM_NEXT,
>+	ZERO,
>+};
>+
> static const enum index next_set_raw[] = {
> 	SET_RAW_INDEX,
> 	ITEM_ETH,
>@@ -2699,6 +2708,19 @@ static const struct token token_list[] = {
> 		.args = ARGS(ARGS_ENTRY_HTON(struct rte_flow_item_esp,
> 				hdr.spi)),
> 	},
>+	[ITEM_AH] = {
>+		.name = "ah",
>+		.help = "match AH header",
>+		.priv = PRIV_ITEM(AH, sizeof(struct rte_flow_item_ah)),
>+		.next = NEXT(item_ah),
>+		.call = parse_vc,
>+	},
>+	[ITEM_AH_SPI] = {
>+		.name = "spi",
>+		.help = "security parameters index",
>+		.next = NEXT(item_ah, NEXT_ENTRY(UNSIGNED), item_param),
>+		.args = ARGS(ARGS_ENTRY_HTON(struct rte_flow_item_ah, spi)),
>+	},
> 	/* Validate/create actions. */
> 	[ACTIONS] = {
> 		.name = "actions",
>@@ -6444,6 +6466,9 @@ flow_item_default_mask(const struct rte_flow_item *item)
> 	case RTE_FLOW_ITEM_TYPE_ESP:
> 		mask = &rte_flow_item_esp_mask;
> 		break;
>+	case RTE_FLOW_ITEM_TYPE_AH:
>+		mask = &rte_flow_item_ah_mask;
>+		break;
> 	default:
> 		break;
> 	}
>@@ -6541,6 +6566,10 @@ cmd_set_raw_parsed(const struct buffer *in)
> 			size = sizeof(struct rte_flow_item_esp);
> 			proto = 0x32;
> 			break;
>+		case RTE_FLOW_ITEM_TYPE_AH:
>+			size = sizeof(struct rte_flow_item_ah);
>+			proto = 0x33;
>+			break;
> 		default:
> 			printf("Error - Not supported item\n");
> 			*total_size = 0;
>-- 
>2.7.4
>
Xiao Zhang Feb. 14, 2020, 1:02 a.m. UTC | #2 
> -----Original Message-----
> From: Ye, Xiaolong <xiaolong.ye@intel.com>
> Sent: Thursday, February 13, 2020 2:46 PM
> To: Zhang, Xiao <xiao.zhang@intel.com>
> Cc: dev@dpdk.org; orika@mellanox.com; Zhang, Qi Z <qi.z.zhang@intel.com>;
> Su, Simei <simei.su@intel.com>; Iremonger, Bernard
> <bernard.iremonger@intel.com>
> Subject: Re: [dpdk-dev] app/testpmd: parse flow command line for AH
> 
> Hi, Xiao
> 
> On 02/13, Xiao Zhang wrote:
> >add ITEM_AH
> >add ITEM_AH_SPI
> 
> Better to add some descriptive sentence about this patch in commit log instead
> of some simple bullets.

Yes, added more description in v2 patch.

Thanks,
Xiao

> 
> Thanks,
> Xiaolong
> 
> >
> >Signed-off-by: Xiao Zhang <xiao.zhang@intel.com>
> >---
> > app/test-pmd/cmdline_flow.c | 29 +++++++++++++++++++++++++++++
> > 1 file changed, 29 insertions(+)
> >
> >diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c
> >index c2cc4c5..680cb1c 100644
> >--- a/app/test-pmd/cmdline_flow.c
> >+++ b/app/test-pmd/cmdline_flow.c
> >@@ -220,6 +220,8 @@ enum index {
> > 	ITEM_L2TPV3OIP_SESSION_ID,
> > 	ITEM_ESP,
> > 	ITEM_ESP_SPI,
> >+	ITEM_AH,
> >+	ITEM_AH_SPI,
> >
> > 	/* Validate/create actions. */
> > 	ACTIONS,
> >@@ -768,6 +770,7 @@ static const enum index next_item[] = {
> > 	ITEM_TAG,
> > 	ITEM_L2TPV3OIP,
> > 	ITEM_ESP,
> >+	ITEM_AH,
> > 	END_SET,
> > 	ZERO,
> > };
> >@@ -1046,6 +1049,12 @@ static const enum index item_esp[] = {
> > 	ZERO,
> > };
> >
> >+static const enum index item_ah[] = {
> >+	ITEM_AH_SPI,
> >+	ITEM_NEXT,
> >+	ZERO,
> >+};
> >+
> > static const enum index next_set_raw[] = {
> > 	SET_RAW_INDEX,
> > 	ITEM_ETH,
> >@@ -2699,6 +2708,19 @@ static const struct token token_list[] = {
> > 		.args = ARGS(ARGS_ENTRY_HTON(struct rte_flow_item_esp,
> > 				hdr.spi)),
> > 	},
> >+	[ITEM_AH] = {
> >+		.name = "ah",
> >+		.help = "match AH header",
> >+		.priv = PRIV_ITEM(AH, sizeof(struct rte_flow_item_ah)),
> >+		.next = NEXT(item_ah),
> >+		.call = parse_vc,
> >+	},
> >+	[ITEM_AH_SPI] = {
> >+		.name = "spi",
> >+		.help = "security parameters index",
> >+		.next = NEXT(item_ah, NEXT_ENTRY(UNSIGNED), item_param),
> >+		.args = ARGS(ARGS_ENTRY_HTON(struct rte_flow_item_ah,
> spi)),
> >+	},
> > 	/* Validate/create actions. */
> > 	[ACTIONS] = {
> > 		.name = "actions",
> >@@ -6444,6 +6466,9 @@ flow_item_default_mask(const struct rte_flow_item
> *item)
> > 	case RTE_FLOW_ITEM_TYPE_ESP:
> > 		mask = &rte_flow_item_esp_mask;
> > 		break;
> >+	case RTE_FLOW_ITEM_TYPE_AH:
> >+		mask = &rte_flow_item_ah_mask;
> >+		break;
> > 	default:
> > 		break;
> > 	}
> >@@ -6541,6 +6566,10 @@ cmd_set_raw_parsed(const struct buffer *in)
> > 			size = sizeof(struct rte_flow_item_esp);
> > 			proto = 0x32;
> > 			break;
> >+		case RTE_FLOW_ITEM_TYPE_AH:
> >+			size = sizeof(struct rte_flow_item_ah);
> >+			proto = 0x33;
> >+			break;
> > 		default:
> > 			printf("Error - Not supported item\n");
> > 			*total_size = 0;
> >--
> >2.7.4
> >
diff mbox series

Patch

diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c
index c2cc4c5..680cb1c 100644
--- a/app/test-pmd/cmdline_flow.c
+++ b/app/test-pmd/cmdline_flow.c
@@ -220,6 +220,8 @@  enum index {
 	ITEM_L2TPV3OIP_SESSION_ID,
 	ITEM_ESP,
 	ITEM_ESP_SPI,
+	ITEM_AH,
+	ITEM_AH_SPI,
 
 	/* Validate/create actions. */
 	ACTIONS,
@@ -768,6 +770,7 @@  static const enum index next_item[] = {
 	ITEM_TAG,
 	ITEM_L2TPV3OIP,
 	ITEM_ESP,
+	ITEM_AH,
 	END_SET,
 	ZERO,
 };
@@ -1046,6 +1049,12 @@  static const enum index item_esp[] = {
 	ZERO,
 };
 
+static const enum index item_ah[] = {
+	ITEM_AH_SPI,
+	ITEM_NEXT,
+	ZERO,
+};
+
 static const enum index next_set_raw[] = {
 	SET_RAW_INDEX,
 	ITEM_ETH,
@@ -2699,6 +2708,19 @@  static const struct token token_list[] = {
 		.args = ARGS(ARGS_ENTRY_HTON(struct rte_flow_item_esp,
 				hdr.spi)),
 	},
+	[ITEM_AH] = {
+		.name = "ah",
+		.help = "match AH header",
+		.priv = PRIV_ITEM(AH, sizeof(struct rte_flow_item_ah)),
+		.next = NEXT(item_ah),
+		.call = parse_vc,
+	},
+	[ITEM_AH_SPI] = {
+		.name = "spi",
+		.help = "security parameters index",
+		.next = NEXT(item_ah, NEXT_ENTRY(UNSIGNED), item_param),
+		.args = ARGS(ARGS_ENTRY_HTON(struct rte_flow_item_ah, spi)),
+	},
 	/* Validate/create actions. */
 	[ACTIONS] = {
 		.name = "actions",
@@ -6444,6 +6466,9 @@  flow_item_default_mask(const struct rte_flow_item *item)
 	case RTE_FLOW_ITEM_TYPE_ESP:
 		mask = &rte_flow_item_esp_mask;
 		break;
+	case RTE_FLOW_ITEM_TYPE_AH:
+		mask = &rte_flow_item_ah_mask;
+		break;
 	default:
 		break;
 	}
@@ -6541,6 +6566,10 @@  cmd_set_raw_parsed(const struct buffer *in)
 			size = sizeof(struct rte_flow_item_esp);
 			proto = 0x32;
 			break;
+		case RTE_FLOW_ITEM_TYPE_AH:
+			size = sizeof(struct rte_flow_item_ah);
+			proto = 0x33;
+			break;
 		default:
 			printf("Error - Not supported item\n");
 			*total_size = 0;