diff mbox series

[v2] devtools: check c99 comment use in checkpatches.sh

Message ID 20200215170950.11628-1-lance.richardson@broadcom.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers
Series [v2] devtools: check c99 comment use in checkpatches.sh |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/iol-testing success Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/travis-robot warning Travis build: failed
ci/Intel-compilation fail apply issues

Commit Message

Lance Richardson Feb. 15, 2020, 5:09 p.m. UTC 
  C99-style comments are not permitted according to DPDK coding
style guidelines, enable checking for these by checkpatch.pl.

Signed-off-by: Lance Richardson <lance.richardson@broadcom.com>
---
v2:
* Fixed a typo in commit message.

 devtools/checkpatches.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Thomas Monjalon Feb. 22, 2020, 7:52 p.m. UTC | #1 
15/02/2020 18:09, Lance Richardson:
> C99-style comments are not permitted according to DPDK coding
> style guidelines, enable checking for these by checkpatch.pl.
> 
> Signed-off-by: Lance Richardson <lance.richardson@broadcom.com>

Applied, thanks
diff mbox series

Patch

diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh
index b16bace92..c996a8780 100755
--- a/devtools/checkpatches.sh
+++ b/devtools/checkpatches.sh
@@ -33,7 +33,7 @@  VOLATILE,PREFER_PACKED,PREFER_ALIGNED,PREFER_PRINTF,\
 PREFER_KERNEL_TYPES,BIT_MACRO,CONST_STRUCT,\
 SPLIT_STRING,LONG_LINE_STRING,\
 LINE_SPACING,PARENTHESIS_ALIGNMENT,NETWORKING_BLOCK_COMMENT_STYLE,\
-NEW_TYPEDEFS,COMPARISON_TO_NULL"
+NEW_TYPEDEFS,COMPARISON_TO_NULL,C99_COMMENT_TOLERANCE"
 options="$options $DPDK_CHECKPATCH_OPTIONS"
 
 print_usage () {