net/sfc: fix log format specifiers
Checks
Commit Message
The format specifier for the 'size_t' format should be '%z'.
Also this fix enables compiling PMD for 32bit architecture.
Fixes: ba641f207642 ("net/sfc: add init on attach")
Fixes: 82faef507608 ("net/sfc: set RSS key and hash types config")
Fixes: 7803554a9e38 ("net/sfc: process RSS settings on Rx configure step")
Cc: stable@dpdk.org
Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
Cc: arybchenko@solarflare.com
Cc: ivan.malov@oktetlabs.ru
---
drivers/net/sfc/sfc.c | 2 +-
drivers/net/sfc/sfc_ethdev.c | 2 +-
drivers/net/sfc/sfc_rx.c | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
Comments
On 2/19/20 5:04 PM, Ferruh Yigit wrote:
> The format specifier for the 'size_t' format should be '%z'.
>
> Also this fix enables compiling PMD for 32bit architecture.
>
> Fixes: ba641f207642 ("net/sfc: add init on attach")
> Fixes: 82faef507608 ("net/sfc: set RSS key and hash types config")
> Fixes: 7803554a9e38 ("net/sfc: process RSS settings on Rx configure step")
> Cc: stable@dpdk.org
>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
Reviewed-by: Andrew Rybchenko <arybchenko@solarflare.com>
Thanks.
On 2/19/2020 2:11 PM, Andrew Rybchenko wrote:
> On 2/19/20 5:04 PM, Ferruh Yigit wrote:
>> The format specifier for the 'size_t' format should be '%z'.
>>
>> Also this fix enables compiling PMD for 32bit architecture.
>>
>> Fixes: ba641f207642 ("net/sfc: add init on attach")
>> Fixes: 82faef507608 ("net/sfc: set RSS key and hash types config")
>> Fixes: 7803554a9e38 ("net/sfc: process RSS settings on Rx configure step")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
>
> Reviewed-by: Andrew Rybchenko <arybchenko@solarflare.com>
>
Applied to dpdk-next-net/master, thanks.
@@ -30,7 +30,7 @@ sfc_dma_alloc(const struct sfc_adapter *sa, const char *name, uint16_t id,
{
const struct rte_memzone *mz;
- sfc_log_init(sa, "name=%s id=%u len=%lu socket_id=%d",
+ sfc_log_init(sa, "name=%s id=%u len=%zu socket_id=%d",
name, id, len, socket_id);
mz = rte_eth_dma_zone_reserve(sa->eth_dev, name, id, len,
@@ -1520,7 +1520,7 @@ sfc_dev_rss_hash_update(struct rte_eth_dev *dev,
if ((rss_conf->rss_key != NULL) &&
(rss_conf->rss_key_len != sizeof(rss->key))) {
- sfc_err(sa, "RSS key size is wrong (should be %lu)",
+ sfc_err(sa, "RSS key size is wrong (should be %zu)",
sizeof(rss->key));
return -EINVAL;
}
@@ -1403,7 +1403,7 @@ sfc_rx_process_adv_conf_rss(struct sfc_adapter *sa,
if (conf->rss_key != NULL) {
if (conf->rss_key_len != sizeof(rss->key)) {
- sfc_err(sa, "RSS key size is wrong (should be %lu)",
+ sfc_err(sa, "RSS key size is wrong (should be %zu)",
sizeof(rss->key));
return EINVAL;
}