diff mbox series

[v1] eal: fix structure marker 4B type error

Message ID 20200308041824.8220-1-haiyue.wang@intel.com (mailing list archive)
State Accepted, archived
Delegated to: David Marchand
Headers
Series [v1] eal: fix structure marker 4B type error |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-testing success Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/travis-robot success Travis build: passed
ci/Intel-compilation success Compilation OK

Commit Message

Wang, Haiyue March 8, 2020, 4:18 a.m. UTC 
  Use the 32bit typedef for structure 4B alignment marking.

Fixes: 2b393160a480 ("eal: introduce structure markers")
Cc: stable@dpdk.org

Signed-off-by: Haiyue Wang <haiyue.wang@intel.com>
---
 lib/librte_eal/common/include/rte_common.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Xiaolong Ye March 8, 2020, 5:24 a.m. UTC | #1 
On 03/08, Haiyue Wang wrote:
>Use the 32bit typedef for structure 4B alignment marking.
>
>Fixes: 2b393160a480 ("eal: introduce structure markers")
>Cc: stable@dpdk.org
>
>Signed-off-by: Haiyue Wang <haiyue.wang@intel.com>
>---
> lib/librte_eal/common/include/rte_common.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/lib/librte_eal/common/include/rte_common.h b/lib/librte_eal/common/include/rte_common.h
>index 4b5f3a31f..3662545d2 100644
>--- a/lib/librte_eal/common/include/rte_common.h
>+++ b/lib/librte_eal/common/include/rte_common.h
>@@ -344,7 +344,7 @@ __extension__ typedef uint8_t  RTE_MARKER8[0];
> /** Marker for 2B alignment in a structure. */
> __extension__ typedef uint16_t RTE_MARKER16[0];
> /** Marker for 4B alignment in a structure. */
>-__extension__ typedef uint16_t RTE_MARKER32[0];
>+__extension__ typedef uint32_t RTE_MARKER32[0];
> /** Marker for 8B alignment in a structure. */
> __extension__ typedef uint64_t RTE_MARKER64[0];
> 
>-- 
>2.25.1
>

Acked-by: Xiaolong Ye <xiaolong.ye@intel.com>
Jerin Jacob March 9, 2020, 5:07 a.m. UTC | #2 
On Sun, Mar 8, 2020 at 10:57 AM Ye Xiaolong <xiaolong.ye@intel.com> wrote:
>
> On 03/08, Haiyue Wang wrote:
> >Use the 32bit typedef for structure 4B alignment marking.
> >
> >Fixes: 2b393160a480 ("eal: introduce structure markers")
> >Cc: stable@dpdk.org
> >
> >Signed-off-by: Haiyue Wang <haiyue.wang@intel.com>
> >---
> > lib/librte_eal/common/include/rte_common.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> >diff --git a/lib/librte_eal/common/include/rte_common.h b/lib/librte_eal/common/include/rte_common.h
> >index 4b5f3a31f..3662545d2 100644
> >--- a/lib/librte_eal/common/include/rte_common.h
> >+++ b/lib/librte_eal/common/include/rte_common.h
> >@@ -344,7 +344,7 @@ __extension__ typedef uint8_t  RTE_MARKER8[0];
> > /** Marker for 2B alignment in a structure. */
> > __extension__ typedef uint16_t RTE_MARKER16[0];
> > /** Marker for 4B alignment in a structure. */
> >-__extension__ typedef uint16_t RTE_MARKER32[0];
> >+__extension__ typedef uint32_t RTE_MARKER32[0];
> > /** Marker for 8B alignment in a structure. */
> > __extension__ typedef uint64_t RTE_MARKER64[0];
> >
> >--
> >2.25.1
> >
>
> Acked-by: Xiaolong Ye <xiaolong.ye@intel.com>

Acked-by: Jerin Jacob <jerinj@marvell.com>
David Marchand March 13, 2020, 9:43 a.m. UTC | #3 
On Sun, Mar 8, 2020 at 5:22 AM Haiyue Wang <haiyue.wang@intel.com> wrote:
> Use the 32bit typedef for structure 4B alignment marking.
>
> Fixes: 2b393160a480 ("eal: introduce structure markers")
> Cc: stable@dpdk.org
>
> Signed-off-by: Haiyue Wang <haiyue.wang@intel.com>
Acked-by: Xiaolong Ye <xiaolong.ye@intel.com>
Acked-by: Jerin Jacob <jerinj@marvell.com>

Applied, thanks.
diff mbox series

Patch

diff --git a/lib/librte_eal/common/include/rte_common.h b/lib/librte_eal/common/include/rte_common.h
index 4b5f3a31f..3662545d2 100644
--- a/lib/librte_eal/common/include/rte_common.h
+++ b/lib/librte_eal/common/include/rte_common.h
@@ -344,7 +344,7 @@  __extension__ typedef uint8_t  RTE_MARKER8[0];
 /** Marker for 2B alignment in a structure. */
 __extension__ typedef uint16_t RTE_MARKER16[0];
 /** Marker for 4B alignment in a structure. */
-__extension__ typedef uint16_t RTE_MARKER32[0];
+__extension__ typedef uint32_t RTE_MARKER32[0];
 /** Marker for 8B alignment in a structure. */
 __extension__ typedef uint64_t RTE_MARKER64[0];