diff mbox series

doc: use glob terminology

Message ID 20200412144047.2125201-1-jerinj@marvell.com (mailing list archive)
State Superseded, archived
Delegated to: Thomas Monjalon
Headers
Series doc: use glob terminology |

Checks

Context Check Description
ci/checkpatch warning coding style issues
ci/Intel-compilation success Compilation OK
ci/travis-robot success Travis build: passed

Commit Message

Jerin Jacob Kollanukkaran April 12, 2020, 2:40 p.m. UTC 
  From: Jerin Jacob <jerinj@marvell.com>

Globbing is the word used on fnmatch man page. Use globing
terminology accross dpdk repo for shell pattern.

Signed-off-by: Jerin Jacob <jerinj@marvell.com>
---
 devtools/check-includes.sh       | 2 +-
 lib/librte_eal/include/rte_log.h | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

Comments

Thomas Monjalon April 12, 2020, 3:05 p.m. UTC | #1 
12/04/2020 16:40, jerinj@marvell.com:
> From: Jerin Jacob <jerinj@marvell.com>
> 
> Globbing is the word used on fnmatch man page. Use globing
> terminology accross dpdk repo for shell pattern.
> 
> Signed-off-by: Jerin Jacob <jerinj@marvell.com>
[...]
> --- a/lib/librte_eal/include/rte_log.h
> +++ b/lib/librte_eal/include/rte_log.h
> - * Set the log level for a given type based on shell pattern.
> + * Set the log level for a given type based on globbing.
>   *
>   * @param pattern
>   *   The match pattern identifying the log type.

"match pattern" can be replaced with "globbing pattern".

I think there are few other places which can be improved.

I see this one in lib/librte_eal/common/eal_common_log.c:
	glob (file match) pattern
I suggest "globbing pattern"

And "Glob match string option" -> "Globbing pattern option"
diff mbox series

Patch

diff --git a/devtools/check-includes.sh b/devtools/check-includes.sh
index 3629ab4c7..743e77675 100755
--- a/devtools/check-includes.sh
+++ b/devtools/check-includes.sh
@@ -23,7 +23,7 @@ 
 # PEDANTIC_CFLAGS, PEDANTIC_CXXFLAGS and PEDANTIC_CPPFLAGS provide strict
 # C/C++ compilation flags.
 #
-# IGNORE contains a list of shell patterns matching files (relative to the
+# IGNORE contains a list of globbing matching files (relative to the
 # include directory) to avoid. It is set by default to known DPDK headers
 # which must not be included on their own.
 #
diff --git a/lib/librte_eal/include/rte_log.h b/lib/librte_eal/include/rte_log.h
index a497e195d..05761a3b6 100644
--- a/lib/librte_eal/include/rte_log.h
+++ b/lib/librte_eal/include/rte_log.h
@@ -158,7 +158,7 @@  __rte_experimental
 bool rte_log_can_log(uint32_t logtype, uint32_t loglevel);
 
 /**
- * Set the log level for a given type based on shell pattern.
+ * Set the log level for a given type based on globbing.
  *
  * @param pattern
  *   The match pattern identifying the log type.