abi: change references to abi 20.0.1 to abi v21
Checks
Commit Message
Change references to abi 20.0.1 to use abi v21.0, add myself as the map
file maintainer to more closely monitor future abi changes.
Signed-off-by: Ray Kinsella <mdr@ashroe.eu>
---
MAINTAINERS | 2 ++
drivers/common/iavf/rte_common_iavf_version.map | 2 +-
drivers/common/mlx5/rte_common_mlx5_version.map | 2 +-
drivers/common/octeontx2/rte_common_octeontx2_version.map | 2 +-
drivers/net/ionic/rte_pmd_ionic_version.map | 2 +-
drivers/raw/octeontx2_ep/rte_rawdev_octeontx2_ep_version.map | 2 +-
drivers/vdpa/mlx5/rte_pmd_mlx5_vdpa_version.map | 2 +-
lib/librte_meter/rte_meter_version.map | 2 +-
8 files changed, 9 insertions(+), 7 deletions(-)
Comments
Travis ABI check warnings, can be safely ignored in this case, I think.
https://travis-ci.com/github/ovsrobot/dpdk/builds/161009923
Ray K
On 20/04/2020 10:34, Ray Kinsella wrote:
> Change references to abi 20.0.1 to use abi v21.0, add myself as the map
> file maintainer to more closely monitor future abi changes.
>
> Signed-off-by: Ray Kinsella <mdr@ashroe.eu>
> ---
> MAINTAINERS | 2 ++
> drivers/common/iavf/rte_common_iavf_version.map | 2 +-
> drivers/common/mlx5/rte_common_mlx5_version.map | 2 +-
> drivers/common/octeontx2/rte_common_octeontx2_version.map | 2 +-
> drivers/net/ionic/rte_pmd_ionic_version.map | 2 +-
> drivers/raw/octeontx2_ep/rte_rawdev_octeontx2_ep_version.map | 2 +-
> drivers/vdpa/mlx5/rte_pmd_mlx5_vdpa_version.map | 2 +-
> lib/librte_meter/rte_meter_version.map | 2 +-
> 8 files changed, 9 insertions(+), 7 deletions(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 1bf00d7e5..c352e7815 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -86,6 +86,8 @@ F: doc/
> ABI Policy
> M: Ray Kinsella <mdr@ashroe.eu>
> F: doc/guides/contributing/abi_*.rst
> +F: drivers/*/*/*.map
> +F: lib/*/*.map
>
> Developers and Maintainers Tools
> M: Thomas Monjalon <thomas@monjalon.net>
> diff --git a/drivers/common/iavf/rte_common_iavf_version.map b/drivers/common/iavf/rte_common_iavf_version.map
> index 2f11d67c0..b9ca81aea 100644
> --- a/drivers/common/iavf/rte_common_iavf_version.map
> +++ b/drivers/common/iavf/rte_common_iavf_version.map
> @@ -1,4 +1,4 @@
> -DPDK_20.0.1 {
> +DPDK_21.0 {
> global:
>
> iavf_init_adminq;
> diff --git a/drivers/common/mlx5/rte_common_mlx5_version.map b/drivers/common/mlx5/rte_common_mlx5_version.map
> index aede2a0a5..7bfea95fb 100644
> --- a/drivers/common/mlx5/rte_common_mlx5_version.map
> +++ b/drivers/common/mlx5/rte_common_mlx5_version.map
> @@ -1,4 +1,4 @@
> -DPDK_20.0.1 {
> +DPDK_21.0 {
> global:
>
> mlx5_class_get;
> diff --git a/drivers/common/octeontx2/rte_common_octeontx2_version.map b/drivers/common/octeontx2/rte_common_octeontx2_version.map
> index 8f2404bd9..68392ff79 100644
> --- a/drivers/common/octeontx2/rte_common_octeontx2_version.map
> +++ b/drivers/common/octeontx2/rte_common_octeontx2_version.map
> @@ -34,7 +34,7 @@ DPDK_20.0 {
> local: *;
> };
>
> -DPDK_20.0.1 {
> +DPDK_21.0 {
> global:
>
> otx2_eth_dev_is_sec_capable;
> diff --git a/drivers/net/ionic/rte_pmd_ionic_version.map b/drivers/net/ionic/rte_pmd_ionic_version.map
> index bc8fd6d4d..cd8100ee4 100644
> --- a/drivers/net/ionic/rte_pmd_ionic_version.map
> +++ b/drivers/net/ionic/rte_pmd_ionic_version.map
> @@ -1,4 +1,4 @@
> -DPDK_20.0.1 {
> +DPDK_21.0 {
>
> local: *;
> };
> diff --git a/drivers/raw/octeontx2_ep/rte_rawdev_octeontx2_ep_version.map b/drivers/raw/octeontx2_ep/rte_rawdev_octeontx2_ep_version.map
> index bc8fd6d4d..cd8100ee4 100644
> --- a/drivers/raw/octeontx2_ep/rte_rawdev_octeontx2_ep_version.map
> +++ b/drivers/raw/octeontx2_ep/rte_rawdev_octeontx2_ep_version.map
> @@ -1,4 +1,4 @@
> -DPDK_20.0.1 {
> +DPDK_21.0 {
>
> local: *;
> };
> diff --git a/drivers/vdpa/mlx5/rte_pmd_mlx5_vdpa_version.map b/drivers/vdpa/mlx5/rte_pmd_mlx5_vdpa_version.map
> index 179f7f1ae..299ae632d 100644
> --- a/drivers/vdpa/mlx5/rte_pmd_mlx5_vdpa_version.map
> +++ b/drivers/vdpa/mlx5/rte_pmd_mlx5_vdpa_version.map
> @@ -1,3 +1,3 @@
> -DPDK_20.0.1 {
> +DPDK_21.0 {
> local: *;
> };
> diff --git a/lib/librte_meter/rte_meter_version.map b/lib/librte_meter/rte_meter_version.map
> index fc12cc0bf..10c56756c 100644
> --- a/lib/librte_meter/rte_meter_version.map
> +++ b/lib/librte_meter/rte_meter_version.map
> @@ -13,7 +13,7 @@ DPDK_20.0 {
> local: *;
> };
>
> -DPDK_20.0.1 {
> +DPDK_21.0 {
> global:
>
> rte_meter_trtcm_rfc4115_color_aware_check;
>
On Mon, Apr 20, 2020 at 1:57 PM Ray Kinsella <mdr@ashroe.eu> wrote:
>
> Travis ABI check warnings, can be safely ignored in this case, I think.
>
> https://travis-ci.com/github/ovsrobot/dpdk/builds/161009923
How about comparing to 19.11 ABI then?
--- a/.travis.yml
+++ b/.travis.yml
@@ -36,7 +36,7 @@ script: ./.ci/${TRAVIS_OS_NAME}-build.sh
env:
global:
- - REF_GIT_TAG=v20.02
+ - REF_GIT_TAG=v19.11
jobs:
include:
On 20/04/2020 13:20, David Marchand wrote:
> On Mon, Apr 20, 2020 at 1:57 PM Ray Kinsella <mdr@ashroe.eu> wrote:
>>
>> Travis ABI check warnings, can be safely ignored in this case, I think.
>>
>> https://travis-ci.com/github/ovsrobot/dpdk/builds/161009923
>
> How about comparing to 19.11 ABI then?
Theory is we should always be checking against v19.11 abi.
So this _should_ be v19.11 ...
I will change in v2 and see what it throws up.
>
> --- a/.travis.yml
> +++ b/.travis.yml
> @@ -36,7 +36,7 @@ script: ./.ci/${TRAVIS_OS_NAME}-build.sh
>
> env:
> global:
> - - REF_GIT_TAG=v20.02
> + - REF_GIT_TAG=v19.11
>
> jobs:
> include:
>
>
Concluded on separate thread it is best to leave this as v20.02.
Thanks,
Ray K
On 20/04/2020 13:20, David Marchand wrote:
> On Mon, Apr 20, 2020 at 1:57 PM Ray Kinsella <mdr@ashroe.eu> wrote:
>>
>> Travis ABI check warnings, can be safely ignored in this case, I think.
>>
>> https://travis-ci.com/github/ovsrobot/dpdk/builds/161009923
>
> How about comparing to 19.11 ABI then?
>
>
> --- a/.travis.yml
> +++ b/.travis.yml
> @@ -36,7 +36,7 @@ script: ./.ci/${TRAVIS_OS_NAME}-build.sh
>
> env:
> global:
> - - REF_GIT_TAG=v20.02
> + - REF_GIT_TAG=v19.11
>
> jobs:
> include:
>
>
On Wed, Apr 22, 2020 at 10:08 AM Ray Kinsella <mdr@ashroe.eu> wrote:
>
> Concluded on separate thread it is best to leave this as v20.02.
Ok, thanks for confirming.
22/04/2020 10:07, Ray Kinsella:
> On 20/04/2020 13:20, David Marchand wrote:
> > On Mon, Apr 20, 2020 at 1:57 PM Ray Kinsella <mdr@ashroe.eu> wrote:
> >>
> >> Travis ABI check warnings, can be safely ignored in this case, I think.
> >>
> >> https://travis-ci.com/github/ovsrobot/dpdk/builds/161009923
> >
> > How about comparing to 19.11 ABI then?
> >
> Concluded on separate thread it is best to leave this as v20.02.
It means the ABI tool will be reporting a failure?
The tool needs to reliably report zero false positive.
How can we mitigate this issue?
On 22/04/2020 09:18, Thomas Monjalon wrote:
> 22/04/2020 10:07, Ray Kinsella:
>> On 20/04/2020 13:20, David Marchand wrote:
>>> On Mon, Apr 20, 2020 at 1:57 PM Ray Kinsella <mdr@ashroe.eu> wrote:
>>>>
>>>> Travis ABI check warnings, can be safely ignored in this case, I think.
>>>>
>>>> https://travis-ci.com/github/ovsrobot/dpdk/builds/161009923
>>>
>>> How about comparing to 19.11 ABI then?
>>>
>> Concluded on separate thread it is best to leave this as v20.02.
>
> It means the ABI tool will be reporting a failure?
> The tool needs to reliably report zero false positive.
> How can we mitigate this issue?
>
>
So I suggest we handle by adding
[suppress_function]
symbol_version = 20.0.1
[suppress_variable]
symbol_version = 20.0.1
to libabigail.abignore.
libabigail will then ignore the removals?
Ray K
v3:
* Removed libabigail supressions in previous version.
* Clarified abi policy for only major abi versions in git commit.
Ray Kinsella (1):
abi: change references to abi 20.0.1 to abi v21
MAINTAINERS | 2 ++
drivers/common/iavf/rte_common_iavf_version.map | 2 +-
drivers/common/mlx5/rte_common_mlx5_version.map | 2 +-
drivers/common/octeontx2/rte_common_octeontx2_version.map | 2 +-
drivers/net/ionic/rte_pmd_ionic_version.map | 2 +-
drivers/raw/octeontx2_ep/rte_rawdev_octeontx2_ep_version.map | 2 +-
drivers/vdpa/mlx5/rte_pmd_mlx5_vdpa_version.map | 2 +-
lib/librte_meter/rte_meter_version.map | 2 +-
8 files changed, 9 insertions(+), 7 deletions(-)
--
2.7.4
v4:
* restored suppressions for v20.0.1 incorrectly removed in v3.
Ray Kinsella (1):
abi: change references to abi 20.0.1 to abi v21
MAINTAINERS | 2 ++
devtools/libabigail.abignore | 5 +++++
drivers/common/iavf/rte_common_iavf_version.map | 2 +-
drivers/common/mlx5/rte_common_mlx5_version.map | 2 +-
drivers/common/octeontx2/rte_common_octeontx2_version.map | 2 +-
drivers/net/ionic/rte_pmd_ionic_version.map | 2 +-
drivers/raw/octeontx2_ep/rte_rawdev_octeontx2_ep_version.map | 2 +-
drivers/vdpa/mlx5/rte_pmd_mlx5_vdpa_version.map | 2 +-
lib/librte_meter/rte_meter_version.map | 2 +-
9 files changed, 14 insertions(+), 7 deletions(-)
--
2.7.4
Sending again, as I missed the cover letter last time.
v6:
* combined policy and versioning in the maintainers file.
Ray Kinsella (1):
abi: change references to abi 20.0.1 to abi v21
MAINTAINERS | 10 +++++-----
devtools/libabigail.abignore | 5 +++++
drivers/common/iavf/rte_common_iavf_version.map | 2 +-
drivers/common/mlx5/rte_common_mlx5_version.map | 2 +-
.../common/octeontx2/rte_common_octeontx2_version.map | 2 +-
drivers/net/ionic/rte_pmd_ionic_version.map | 2 +-
.../octeontx2_ep/rte_rawdev_octeontx2_ep_version.map | 2 +-
drivers/vdpa/mlx5/rte_pmd_mlx5_vdpa_version.map | 2 +-
lib/librte_meter/rte_meter_version.map | 2 +-
9 files changed, 17 insertions(+), 12 deletions(-)
--
2.23.0
30/04/2020 12:27, Ray Kinsella:
> Sending again, as I missed the cover letter last time.
You don't need a cover letter for a single patch.
The changelog can be added below --- in a patch.
@@ -86,6 +86,8 @@ F: doc/
ABI Policy
M: Ray Kinsella <mdr@ashroe.eu>
F: doc/guides/contributing/abi_*.rst
+F: drivers/*/*/*.map
+F: lib/*/*.map
Developers and Maintainers Tools
M: Thomas Monjalon <thomas@monjalon.net>
@@ -1,4 +1,4 @@
-DPDK_20.0.1 {
+DPDK_21.0 {
global:
iavf_init_adminq;
@@ -1,4 +1,4 @@
-DPDK_20.0.1 {
+DPDK_21.0 {
global:
mlx5_class_get;
@@ -34,7 +34,7 @@ DPDK_20.0 {
local: *;
};
-DPDK_20.0.1 {
+DPDK_21.0 {
global:
otx2_eth_dev_is_sec_capable;
@@ -1,4 +1,4 @@
-DPDK_20.0.1 {
+DPDK_21.0 {
local: *;
};
@@ -1,4 +1,4 @@
-DPDK_20.0.1 {
+DPDK_21.0 {
local: *;
};
@@ -1,3 +1,3 @@
-DPDK_20.0.1 {
+DPDK_21.0 {
local: *;
};
@@ -13,7 +13,7 @@ DPDK_20.0 {
local: *;
};
-DPDK_20.0.1 {
+DPDK_21.0 {
global:
rte_meter_trtcm_rfc4115_color_aware_check;