[v6,1/1] abi: change references to abi 20.0.1 to abi v21

Message ID 20200430102726.295773-2-mdr@ashroe.eu (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers
Series [v6,1/1] abi: change references to abi 20.0.1 to abi v21 |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-nxp-Performance success Performance Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/Intel-compilation success Compilation OK
ci/iol-testing success Testing PASS

Commit Message

Ray Kinsella April 30, 2020, 10:27 a.m. UTC
  Change references to abi 20.0.1 to use abi v21, see
https://doc.dpdk.org/guides/contributing/abi_policy.html#general-guidelines

"Major ABI versions are declared no more frequently than yearly.
Compatibility with the major ABI version is mandatory in subsequent
releases until a new major ABI version is declared."

Combined abi policy and versioning in maintainers, add map files to the
filter to more closely monitor future abi changes.

Signed-off-by: Ray Kinsella <mdr@ashroe.eu>
---
 MAINTAINERS                                            | 10 +++++-----
 devtools/libabigail.abignore                           |  5 +++++
 drivers/common/iavf/rte_common_iavf_version.map        |  2 +-
 drivers/common/mlx5/rte_common_mlx5_version.map        |  2 +-
 .../common/octeontx2/rte_common_octeontx2_version.map  |  2 +-
 drivers/net/ionic/rte_pmd_ionic_version.map            |  2 +-
 .../octeontx2_ep/rte_rawdev_octeontx2_ep_version.map   |  2 +-
 drivers/vdpa/mlx5/rte_pmd_mlx5_vdpa_version.map        |  2 +-
 lib/librte_meter/rte_meter_version.map                 |  2 +-
 9 files changed, 17 insertions(+), 12 deletions(-)
  

Comments

Thomas Monjalon May 4, 2020, 10:23 p.m. UTC | #1
30/04/2020 12:27, Ray Kinsella:
> Change references to abi 20.0.1 to use abi v21, see
> https://doc.dpdk.org/guides/contributing/abi_policy.html#general-guidelines
> 
> "Major ABI versions are declared no more frequently than yearly.
> Compatibility with the major ABI version is mandatory in subsequent
> releases until a new major ABI version is declared."
> 
> Combined abi policy and versioning in maintainers, add map files to the
> filter to more closely monitor future abi changes.
> 
> Signed-off-by: Ray Kinsella <mdr@ashroe.eu>

Applied with added change for recent igc PMD:

--- a/drivers/net/igc/rte_pmd_igc_version.map
+++ b/drivers/net/igc/rte_pmd_igc_version.map
@@ -1,3 +1,3 @@
-DPDK_20.0.2 {
+DPDK_21 {
        local: *;
 };
  

Patch

diff --git a/MAINTAINERS b/MAINTAINERS
index e05c80504..9756cb752 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -83,10 +83,6 @@  M: Marko Kovacevic <marko.kovacevic@intel.com>
 F: README
 F: doc/
 
-ABI Policy
-M: Ray Kinsella <mdr@ashroe.eu>
-F: doc/guides/contributing/abi_*.rst
-
 Developers and Maintainers Tools
 M: Thomas Monjalon <thomas@monjalon.net>
 F: MAINTAINERS
@@ -140,10 +136,12 @@  M: Michael Santana <maicolgabriel@hotmail.com>
 F: .travis.yml
 F: .ci/
 
-ABI versioning
+ABI policy & versioning
+M: Ray Kinsella <mdr@ashroe.eu>
 M: Neil Horman <nhorman@tuxdriver.com>
 F: lib/librte_eal/include/rte_compat.h
 F: lib/librte_eal/include/rte_function_versioning.h
+F: doc/guides/contributing/abi_*.rst
 F: doc/guides/rel_notes/deprecation.rst
 F: devtools/check-abi.sh
 F: devtools/check-abi-version.sh
@@ -155,6 +153,8 @@  F: devtools/update_version_map_abi.py
 F: devtools/validate-abi.sh
 F: buildtools/check-symbols.sh
 F: buildtools/map-list-symbol.sh
+F: drivers/*/*/*.map
+F: lib/*/*.map
 
 Driver information
 M: Neil Horman <nhorman@tuxdriver.com>
diff --git a/devtools/libabigail.abignore b/devtools/libabigail.abignore
index 986a52771..b0147fde6 100644
--- a/devtools/libabigail.abignore
+++ b/devtools/libabigail.abignore
@@ -29,3 +29,8 @@ 
         type_kind = enum
         name = rte_eth_event_type
         changed_enumerators = RTE_ETH_EVENT_MAX
+; Explicit ignore ABI 20.0.1
+[suppress_function]
+        symbol_version = DPDK_20.0.1
+[suppress_variable]
+        symbol_version = DPDK_20.0.1
diff --git a/drivers/common/iavf/rte_common_iavf_version.map b/drivers/common/iavf/rte_common_iavf_version.map
index 2f11d67c0..92ceac108 100644
--- a/drivers/common/iavf/rte_common_iavf_version.map
+++ b/drivers/common/iavf/rte_common_iavf_version.map
@@ -1,4 +1,4 @@ 
-DPDK_20.0.1 {
+DPDK_21 {
 	global:
 
 	iavf_init_adminq;
diff --git a/drivers/common/mlx5/rte_common_mlx5_version.map b/drivers/common/mlx5/rte_common_mlx5_version.map
index b58a37827..564a9a7fb 100644
--- a/drivers/common/mlx5/rte_common_mlx5_version.map
+++ b/drivers/common/mlx5/rte_common_mlx5_version.map
@@ -1,4 +1,4 @@ 
-DPDK_20.0.1 {
+DPDK_21 {
 	global:
 
 	mlx5_class_get;
diff --git a/drivers/common/octeontx2/rte_common_octeontx2_version.map b/drivers/common/octeontx2/rte_common_octeontx2_version.map
index 8f2404bd9..01279c339 100644
--- a/drivers/common/octeontx2/rte_common_octeontx2_version.map
+++ b/drivers/common/octeontx2/rte_common_octeontx2_version.map
@@ -34,7 +34,7 @@  DPDK_20.0 {
 	local: *;
 };
 
-DPDK_20.0.1 {
+DPDK_21 {
 	global:
 
 	otx2_eth_dev_is_sec_capable;
diff --git a/drivers/net/ionic/rte_pmd_ionic_version.map b/drivers/net/ionic/rte_pmd_ionic_version.map
index bc8fd6d4d..acdaf587d 100644
--- a/drivers/net/ionic/rte_pmd_ionic_version.map
+++ b/drivers/net/ionic/rte_pmd_ionic_version.map
@@ -1,4 +1,4 @@ 
-DPDK_20.0.1 {
+DPDK_21 {
 
 	local: *;
 };
diff --git a/drivers/raw/octeontx2_ep/rte_rawdev_octeontx2_ep_version.map b/drivers/raw/octeontx2_ep/rte_rawdev_octeontx2_ep_version.map
index bc8fd6d4d..acdaf587d 100644
--- a/drivers/raw/octeontx2_ep/rte_rawdev_octeontx2_ep_version.map
+++ b/drivers/raw/octeontx2_ep/rte_rawdev_octeontx2_ep_version.map
@@ -1,4 +1,4 @@ 
-DPDK_20.0.1 {
+DPDK_21 {
 
 	local: *;
 };
diff --git a/drivers/vdpa/mlx5/rte_pmd_mlx5_vdpa_version.map b/drivers/vdpa/mlx5/rte_pmd_mlx5_vdpa_version.map
index 179f7f1ae..4a76d1d52 100644
--- a/drivers/vdpa/mlx5/rte_pmd_mlx5_vdpa_version.map
+++ b/drivers/vdpa/mlx5/rte_pmd_mlx5_vdpa_version.map
@@ -1,3 +1,3 @@ 
-DPDK_20.0.1 {
+DPDK_21 {
 	local: *;
 };
diff --git a/lib/librte_meter/rte_meter_version.map b/lib/librte_meter/rte_meter_version.map
index fc12cc0bf..2c7dadbca 100644
--- a/lib/librte_meter/rte_meter_version.map
+++ b/lib/librte_meter/rte_meter_version.map
@@ -13,7 +13,7 @@  DPDK_20.0 {
 	local: *;
 };
 
-DPDK_20.0.1 {
+DPDK_21 {
 	global:
 
 	rte_meter_trtcm_rfc4115_color_aware_check;