diff mbox series

net/ice/base: fix pppoe-ipv6 dummy packet error

Message ID 20200507011541.66624-1-wei.zhao1@intel.com (mailing list archive)
State Accepted, archived
Delegated to: xiaolong ye
Headers
Series net/ice/base: fix pppoe-ipv6 dummy packet error |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-nxp-Performance success Performance Testing PASS
ci/travis-robot warning Travis build: failed
ci/Intel-compilation fail Compilation issues
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-testing success Testing PASS

Commit Message

Zhao1, Wei May 7, 2020, 1:15 a.m. UTC 
  The dummy packet for pppoe-ipv6 has an error, we should
use 0x3b for next header in ipv6 header in the dummy packet,
or some case can not be download, such as:

"eth / pppoes seid is 3 / pppoe_proto_id is 0x0057 /
end actions vf id 1 / end"

Fixes: 55d61fb27a5e ("net/ice/base: add PPPoE IPv6 dummy packet")

Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
---
 drivers/net/ice/base/ice_switch.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Lu, Nannan May 7, 2020, 1:52 a.m. UTC | #1 
Tested-by: Lu, Nannan <nannan.lu@intel.com>

-----Original Message-----
From: Zhao1, Wei 
Sent: Thursday, May 7, 2020 9:16 AM
To: dev@dpdk.org
Cc: Zhang, Qi Z <qi.z.zhang@intel.com>; Lu, Nannan <nannan.lu@intel.com>; Zhao1, Wei <wei.zhao1@intel.com>
Subject: [PATCH] net/ice/base: fix pppoe-ipv6 dummy packet error

The dummy packet for pppoe-ipv6 has an error, we should use 0x3b for next header in ipv6 header in the dummy packet, or some case can not be download, such as:

"eth / pppoes seid is 3 / pppoe_proto_id is 0x0057 / end actions vf id 1 / end"

Fixes: 55d61fb27a5e ("net/ice/base: add PPPoE IPv6 dummy packet")

Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
---
 drivers/net/ice/base/ice_switch.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ice/base/ice_switch.c b/drivers/net/ice/base/ice_switch.c
index 957142a10..a07ceea70 100644
--- a/drivers/net/ice/base/ice_switch.c
+++ b/drivers/net/ice/base/ice_switch.c
@@ -577,7 +577,7 @@ static const u8 dummy_pppoe_ipv6_packet[] = {
 	0x00, 0x57,		/* PPP Link Layer 24 */
 
 	0x60, 0x00, 0x00, 0x00, /* ICE_IPV6_OFOS 26 */
-	0x00, 0x00, 0x00, 0x00,
+	0x00, 0x00, 0x3b, 0x00,
 	0x00, 0x00, 0x00, 0x00,
 	0x00, 0x00, 0x00, 0x00,
 	0x00, 0x00, 0x00, 0x00,
--
2.19.1
Qi Zhang May 9, 2020, 5:36 a.m. UTC | #2 
> -----Original Message-----
> From: Lu, Nannan <nannan.lu@intel.com>
> Sent: Thursday, May 7, 2020 9:52 AM
> To: Zhao1, Wei <wei.zhao1@intel.com>; dev@dpdk.org
> Cc: Zhang, Qi Z <qi.z.zhang@intel.com>
> Subject: RE: [PATCH] net/ice/base: fix pppoe-ipv6 dummy packet error
> 
> Tested-by: Lu, Nannan <nannan.lu@intel.com>
> 
> -----Original Message-----
> From: Zhao1, Wei
> Sent: Thursday, May 7, 2020 9:16 AM
> To: dev@dpdk.org
> Cc: Zhang, Qi Z <qi.z.zhang@intel.com>; Lu, Nannan <nannan.lu@intel.com>;
> Zhao1, Wei <wei.zhao1@intel.com>
> Subject: [PATCH] net/ice/base: fix pppoe-ipv6 dummy packet error
> 
> The dummy packet for pppoe-ipv6 has an error, we should use 0x3b for next
> header in ipv6 header in the dummy packet, or some case can not be download,
> such as:
> 
> "eth / pppoes seid is 3 / pppoe_proto_id is 0x0057 / end actions vf id 1 / end"
> 
> Fixes: 55d61fb27a5e ("net/ice/base: add PPPoE IPv6 dummy packet")
> 
> Signed-off-by: Wei Zhao <wei.zhao1@intel.com>

Acked-by: Qi Zhang <qi.z.zhang@intel.com>
Xiaolong Ye May 11, 2020, 2:55 a.m. UTC | #3 
On 05/07, Wei Zhao wrote:
>The dummy packet for pppoe-ipv6 has an error, we should
>use 0x3b for next header in ipv6 header in the dummy packet,
>or some case can not be download, such as:
>
>"eth / pppoes seid is 3 / pppoe_proto_id is 0x0057 /
>end actions vf id 1 / end"
>
>Fixes: 55d61fb27a5e ("net/ice/base: add PPPoE IPv6 dummy packet")
>
>Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
>---
> drivers/net/ice/base/ice_switch.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/net/ice/base/ice_switch.c b/drivers/net/ice/base/ice_switch.c
>index 957142a10..a07ceea70 100644
>--- a/drivers/net/ice/base/ice_switch.c
>+++ b/drivers/net/ice/base/ice_switch.c
>@@ -577,7 +577,7 @@ static const u8 dummy_pppoe_ipv6_packet[] = {
> 	0x00, 0x57,		/* PPP Link Layer 24 */
> 
> 	0x60, 0x00, 0x00, 0x00, /* ICE_IPV6_OFOS 26 */
>-	0x00, 0x00, 0x00, 0x00,
>+	0x00, 0x00, 0x3b, 0x00,
> 	0x00, 0x00, 0x00, 0x00,
> 	0x00, 0x00, 0x00, 0x00,
> 	0x00, 0x00, 0x00, 0x00,
>-- 
>2.19.1
>

Applied to dpdk-next-net-intel, Thanks.
diff mbox series

Patch

diff --git a/drivers/net/ice/base/ice_switch.c b/drivers/net/ice/base/ice_switch.c
index 957142a10..a07ceea70 100644
--- a/drivers/net/ice/base/ice_switch.c
+++ b/drivers/net/ice/base/ice_switch.c
@@ -577,7 +577,7 @@  static const u8 dummy_pppoe_ipv6_packet[] = {
 	0x00, 0x57,		/* PPP Link Layer 24 */
 
 	0x60, 0x00, 0x00, 0x00, /* ICE_IPV6_OFOS 26 */
-	0x00, 0x00, 0x00, 0x00,
+	0x00, 0x00, 0x3b, 0x00,
 	0x00, 0x00, 0x00, 0x00,
 	0x00, 0x00, 0x00, 0x00,
 	0x00, 0x00, 0x00, 0x00,