From patchwork Tue May 12 08:03:05 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Phil Yang X-Patchwork-Id: 70100 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 48242A04A2; Tue, 12 May 2020 10:04:30 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A45D51C19C; Tue, 12 May 2020 10:04:28 +0200 (CEST) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by dpdk.org (Postfix) with ESMTP id 642611C195 for ; Tue, 12 May 2020 10:04:27 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E2F7D1FB; Tue, 12 May 2020 01:04:26 -0700 (PDT) Received: from phil-VirtualBox.shanghai.arm.com (phil-VirtualBox.shanghai.arm.com [10.169.109.147]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 83F6C3F305; Tue, 12 May 2020 01:04:19 -0700 (PDT) From: Phil Yang To: thomas@monjalon.net, dev@dpdk.org Cc: bruce.richardson@intel.com, ferruh.yigit@intel.com, hemant.agrawal@nxp.com, honnappa.nagarahalli@arm.com, jerinj@marvell.com, ktraynor@redhat.com, konstantin.ananyev@intel.com, maxime.coquelin@redhat.com, olivier.matz@6wind.com, stephen@networkplumber.org, mb@smartsharesystems.com, mattias.ronnblom@ericsson.com, harry.van.haaren@intel.com, erik.g.carrillo@intel.com, phil.yang@arm.com, nd@arm.com Date: Tue, 12 May 2020 16:03:05 +0800 Message-Id: <1589270586-4480-4-git-send-email-phil.yang@arm.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1589270586-4480-1-git-send-email-phil.yang@arm.com> References: <1584407863-774-1-git-send-email-phil.yang@arm.com> <1589270586-4480-1-git-send-email-phil.yang@arm.com> Subject: [dpdk-dev] [PATCH v4 3/4] devtools: prevent use of rte atomic APIs in future patches X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" In order to deprecate the rte_atomic APIs, prevent the patches from using rte_atomic APIs in the converted modules and compilers __sync built-ins in all modules. The converted modules: lib/librte_distributor lib/librte_hash lib/librte_kni lib/librte_lpm lib/librte_rcu lib/librte_ring lib/librte_stack lib/librte_vhost lib/librte_timer lib/librte_ipsec drivers/event/octeontx drivers/event/octeontx2 drivers/event/opdl drivers/net/bnx2x drivers/net/hinic drivers/net/hns3 drivers/net/memif drivers/net/thunderx drivers/net/virtio examples/l2fwd-event Signed-off-by: Phil Yang Reviewed-by: Honnappa Nagarahalli --- devtools/checkpatches.sh | 23 +++++++++++++++++++++++ 1 file changed, 23 insertions(+) diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh index 42b833e..002586d 100755 --- a/devtools/checkpatches.sh +++ b/devtools/checkpatches.sh @@ -69,6 +69,29 @@ check_forbidden_additions() { # -f $(dirname $(readlink -f $0))/check-forbidden-tokens.awk \ "$1" || res=1 + # refrain from new additions of 16/32/64 bits rte_atomic_xxx() + # multiple folders and expressions are separated by spaces + awk -v FOLDERS="lib/librte_distributor lib/librte_hash lib/librte_kni + lib/librte_lpm lib/librte_rcu lib/librte_ring + lib/librte_stack lib/librte_vhost drivers/event/octeontx + drivers/event/octeontx2 drivers/event/opdl + drivers/net/bnx2x drivers/net/hinic drivers/net/hns3 + drivers/net/memif drivers/net/thunderx + drivers/net/virtio examples/l2fwd-event" \ + -v EXPRESSIONS="rte_atomic[0-9][0-9]_.*\\\(" \ + -v RET_ON_FAIL=1 \ + -v MESSAGE='Use of rte_atomicNN_xxx APIs not allowed, use rte_atomic_xxx APIs' \ + -f $(dirname $(readlink -f $0))/check-forbidden-tokens.awk \ + "$1" || res=1 + + # refrain from using compiler __sync built-ins + awk -v FOLDERS="lib drivers app examples" \ + -v EXPRESSIONS="__sync_.*\\\(" \ + -v RET_ON_FAIL=1 \ + -v MESSAGE='Use of __sync_xxx built-ins not allowed, use rte_atomic_xxx APIs' \ + -f $(dirname $(readlink -f $0))/check-forbidden-tokens.awk \ + "$1" || res=1 + # svg figures must be included with wildcard extension # because of png conversion for pdf docs awk -v FOLDERS='doc' \